linux-fscrypt.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: "Aleksander Adamowski" <olo@fb.com>,
	"Tomasz Kłoczko" <kloczko.tomasz@gmail.com>
Cc: linux-fscrypt@vger.kernel.org
Subject: Re: [fsverity-utils] 1.4: test suite does not build
Date: Sat, 18 Sep 2021 13:04:32 -0700	[thread overview]
Message-ID: <YUZGUIRpVjNpupSi@sol.localdomain> (raw)
In-Reply-To: <CABB28CwFNRhjgrT7NL6xqnasFQRJwhHZ4F0Xrd2XO-AZEyRBHQ@mail.gmail.com>

On Sat, Sep 18, 2021 at 02:20:45PM +0100, Tomasz Kłoczko wrote:
> Hi,
> 
> Looks like it some issue with test suite because it does not link correctly
> 
> + cd fsverity-utils-1.4

It looks like you're actually building from the master branch, not 1.4?
1.4 doesn't have the code that is causing warnings below.

> lib/sign_digest.c: In function 'load_pkcs11_private_key':
> lib/sign_digest.c:351:9: warning: 'ENGINE_by_id' is deprecated: Since
> OpenSSL 3.0 [-Wdeprecated-declarations]
>   351 |         engine = ENGINE_by_id("dynamic");
>       |         ^~~~~~
> In file included from lib/sign_digest.c:23:
> /usr/include/openssl/engine.h:336:31: note: declared here
>   336 | OSSL_DEPRECATEDIN_3_0 ENGINE *ENGINE_by_id(const char *id);
>       |                               ^~~~~~~~~~~~
> lib/sign_digest.c:356:9: warning: 'ENGINE_ctrl_cmd_string' is
> deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
>   356 |         if (!ENGINE_ctrl_cmd_string(engine, "SO_PATH",
>       |         ^~
> In file included from lib/sign_digest.c:23:
> /usr/include/openssl/engine.h:479:5: note: declared here
>   479 | int ENGINE_ctrl_cmd_string(ENGINE *e, const char *cmd_name,
> const char *arg,
>       |     ^~~~~~~~~~~~~~~~~~~~~~
> lib/sign_digest.c:358:13: warning: 'ENGINE_ctrl_cmd_string' is
> deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
>   358 |             !ENGINE_ctrl_cmd_string(engine, "ID", "pkcs11", 0) ||

Aleksander, can you look into these?

- Eric

  reply	other threads:[~2021-09-18 20:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-18 13:20 1.4: test suite does not build Tomasz Kłoczko
2021-09-18 20:04 ` Eric Biggers [this message]
2021-09-20 20:05   ` [fsverity-utils] " Aleksander Adamowski
2021-09-20 21:19     ` Eric Biggers
2021-09-20 21:52       ` Aleksander Adamowski
2021-09-22 18:57         ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUZGUIRpVjNpupSi@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=kloczko.tomasz@gmail.com \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=olo@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).