* [PATCH v1] fcntl: Remove logically dead code
@ 2019-02-11 13:43 Stanley Chu
0 siblings, 0 replies; only message in thread
From: Stanley Chu @ 2019-02-11 13:43 UTC (permalink / raw)
To: linux-fsdevel, viro
Cc: jlayton, bfields, wsd_upstream, linux-mediatek, kuohong.wang,
Stanley Chu
The commit d08477aa975e ("fcntl: Don't use ambiguous
SIG_POLL si_codes") added BUG_ON for below case,
(reason - POLL_IN) >= NSIGPOLL
Thus some statements become logically dead code and
can be removed.
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
---
fs/fcntl.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/fcntl.c b/fs/fcntl.c
index 083185174c6d..11ec59bf421c 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -762,10 +762,7 @@ static void send_sigio_to_task(struct task_struct *p,
reasons, otherwise we could leak kernel stack into
userspace. */
BUG_ON((reason < POLL_IN) || ((reason - POLL_IN) >= NSIGPOLL));
- if (reason - POLL_IN >= NSIGPOLL)
- si.si_band = ~0L;
- else
- si.si_band = mangle_poll(band_table[reason - POLL_IN]);
+ si.si_band = mangle_poll(band_table[reason - POLL_IN]);
si.si_fd = fd;
if (!do_send_sig_info(signum, &si, p, type))
break;
--
2.18.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-02-11 13:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-11 13:43 [PATCH v1] fcntl: Remove logically dead code Stanley Chu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).