* [GIT PULL] afs: Miscellaneous fixes
@ 2019-12-11 21:17 David Howells
2019-12-12 2:50 ` pr-tracker-bot
0 siblings, 1 reply; 10+ messages in thread
From: David Howells @ 2019-12-11 21:17 UTC (permalink / raw)
To: torvalds
Cc: dhowells, marc.dionne, jsbillings, linux-afs, linux-fsdevel,
linux-kernel
Hi Linus,
Can you pull these fixes for AFS plus one patch to make debugging easier:
(1) Fix how addresses are matched to server records. This is currently
incorrect which means cache invalidation callbacks from the server
don't necessarily get delivered correctly. This causes stale data and
metadata to be seen under some circumstances.
(2) Make the dynamic root superblock R/W so that rpm/dnf can reapply the
SELinux label to it when upgrading the Fedora filesystem-afs package.
If the filesystem is R/O, this fails and the upgrade fails.
It might be better in future to allow setxattr from an LSM to bypass
the R/O protections, if only for pseudo-filesystems.
(3) Fix the parsing of mountpoint strings. The mountpoint object has to
have a terminal dot, whereas the source/device string passed to mount
should not. This confuses type-forcing suffix detection leading to
the wrong volume variant being mounted.
(4) Make lookups in the dynamic root superblock for creation events (such
as mkdir) fail with EOPNOTSUPP rather than something like EEXIST. The
dynamic root only allows implicit creation by the ->lookup() method -
and only if the target cell exists.
(5) Fix the looking up of an AFS superblock to include the cell in the
matching key - otherwise all volumes with the same ID number are
treated as the same thing, irrespective of which cell they're in.
(6) Show the volume name of each volume in the volume records displayed in
/proc/net/afs/<cell>/volumes. This proved useful in debugging (5) as
it provides a way to map the volume IDs to names, where the names are
what appear in /proc/mounts.
Patch (6) can be dropped and deferred to the next merge window if you'd
prefer as it's not strictly a fix.
David
---
The following changes since commit e42617b825f8073569da76dc4510bfa019b1c35a:
Linux 5.5-rc1 (2019-12-08 14:57:55 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/afs-fixes-20191211
for you to fetch changes up to 50559800b76a7a2a46da303100da639536261808:
afs: Show volume name in /proc/net/afs/<cell>/volumes (2019-12-11 17:48:20 +0000)
----------------------------------------------------------------
AFS fixes
----------------------------------------------------------------
David Howells (5):
afs: Fix SELinux setting security label on /afs
afs: Fix mountpoint parsing
afs: Fix creation calls in the dynamic root to fail with EOPNOTSUPP
afs: Fix missing cell comparison in afs_test_super()
afs: Show volume name in /proc/net/afs/<cell>/volumes
Marc Dionne (1):
afs: Fix afs_find_server lookups for ipv4 peers
fs/afs/dynroot.c | 3 +++
fs/afs/mntpt.c | 6 ++++--
fs/afs/proc.c | 7 ++++---
fs/afs/server.c | 21 ++++++++-------------
fs/afs/super.c | 2 +-
5 files changed, 20 insertions(+), 19 deletions(-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [GIT PULL] afs: Miscellaneous fixes
@ 2020-04-24 16:12 David Howells
2020-04-24 17:35 ` Linus Torvalds
2020-04-24 18:40 ` pr-tracker-bot
0 siblings, 2 replies; 10+ messages in thread
From: David Howells @ 2020-04-24 16:12 UTC (permalink / raw)
To: torvalds; +Cc: dhowells, linux-afs, linux-fsdevel, linux-kernel
Hi Linus,
Could you pull these three miscellaneous fixes to the afs filesystem:
(1) Remove some struct members that aren't used, aren't set or aren't
read, plus a wake up that nothing ever waits for.
(2) Actually set the AFS_SERVER_FL_HAVE_EPOCH flag so that the code that
depends on it can work.
(3) Make a couple of waits uninterruptible if they're done for an
operation that isn't supposed to be interruptible.
Thanks,
David
---
The following changes since commit ae83d0b416db002fe95601e7f97f64b59514d936:
Linux 5.7-rc2 (2020-04-19 14:35:30 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/afs-fixes-20200424
for you to fetch changes up to c4bfda16d1b40d1c5941c61b5aa336bdd2d9904a:
afs: Make record checking use TASK_UNINTERRUPTIBLE when appropriate (2020-04-24 16:33:32 +0100)
----------------------------------------------------------------
AFS miscellany
----------------------------------------------------------------
David Howells (3):
afs: Remove some unused bits
afs: Fix to actually set AFS_SERVER_FL_HAVE_EPOCH
afs: Make record checking use TASK_UNINTERRUPTIBLE when appropriate
fs/afs/cmservice.c | 2 +-
fs/afs/fs_probe.c | 5 +----
fs/afs/internal.h | 4 +---
fs/afs/rotate.c | 6 +++---
fs/afs/server.c | 7 ++-----
fs/afs/vl_rotate.c | 4 ++--
fs/afs/volume.c | 8 +++++---
7 files changed, 15 insertions(+), 21 deletions(-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] afs: Miscellaneous fixes
2020-04-24 16:12 David Howells
@ 2020-04-24 17:35 ` Linus Torvalds
2020-04-24 18:40 ` pr-tracker-bot
1 sibling, 0 replies; 10+ messages in thread
From: Linus Torvalds @ 2020-04-24 17:35 UTC (permalink / raw)
To: David Howells; +Cc: linux-afs, linux-fsdevel, Linux Kernel Mailing List
On Fri, Apr 24, 2020 at 9:12 AM David Howells <dhowells@redhat.com> wrote:
>
> (3) Make a couple of waits uninterruptible if they're done for an
> operation that isn't supposed to be interruptible.
Should they not even be killable?
Anyway, pulled.
Linus
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] afs: Miscellaneous fixes
2020-04-24 16:12 David Howells
2020-04-24 17:35 ` Linus Torvalds
@ 2020-04-24 18:40 ` pr-tracker-bot
1 sibling, 0 replies; 10+ messages in thread
From: pr-tracker-bot @ 2020-04-24 18:40 UTC (permalink / raw)
To: David Howells; +Cc: torvalds, dhowells, linux-afs, linux-fsdevel, linux-kernel
The pull request you sent on Fri, 24 Apr 2020 17:12:22 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/afs-fixes-20200424
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/9a195628522c08f36b3bbd0df96582a07ab272bf
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker
^ permalink raw reply [flat|nested] 10+ messages in thread
* [GIT PULL] afs: Miscellaneous fixes
@ 2021-07-21 14:22 David Howells
2021-07-21 19:47 ` pr-tracker-bot
0 siblings, 1 reply; 10+ messages in thread
From: David Howells @ 2021-07-21 14:22 UTC (permalink / raw)
To: torvalds
Cc: dhowells, linux-afs, Steven Rostedt (VMware),
Tom Rix, Marc Dionne, Alexey Dobriyan (SK hynix),
Jiapeng Chong, Abaci Robot, Andrew Morton, linux-fsdevel,
linux-kernel
Hi Linus,
Can you pull these miscellaneous fixes for afs please?
(1) Fix a tracepoint that causes one of the tracing subsystem query files
to crash if the module is loaded[1].
(2) Fix afs_writepages() to take account of whether the storage rpc
actually succeeded when updating the cyclic writeback counter[2].
(3) Fix some error code propagation/handling[3].
(4) Fix place where afs_writepages() was setting writeback_index to a file
position rather than a page index[4].
Changes
=======
ver #2:
- Fix an additional case of afs_writepages() setting writeback_index on
error[4].
- Fix afs_writepages() setting writeback_index to a file pos[4].
Thanks,
David
Link: https://lore.kernel.org/r/162430903582.2896199.6098150063997983353.stgit@warthog.procyon.org.uk/ [1]
Link: https://lore.kernel.org/r/20210430155031.3287870-1-trix@redhat.com [2]
Link: https://lore.kernel.org/r/1619691492-83866-1-git-send-email-jiapeng.chong@linux.alibaba.com [3]
Link: https://lore.kernel.org/r/CAB9dFdvHsLsw7CMnB+4cgciWDSqVjuij4mH3TaXnHQB8sz5rHw@mail.gmail.com/ [4]
Link: https://lore.kernel.org/r/162609463116.3133237.11899334298425929820.stgit@warthog.procyon.org.uk/ # v1
Link: https://lore.kernel.org/r/162610726011.3408253.2771348573083023654.stgit@warthog.procyon.org.uk/ # v2
---
The following changes since commit e73f0f0ee7541171d89f2e2491130c7771ba58d3:
Linux 5.14-rc1 (2021-07-11 15:07:40 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/afs-fixes-20210721
for you to fetch changes up to b428081282f85db8a0d4ae6206a8c39db9c8341b:
afs: Remove redundant assignment to ret (2021-07-21 15:11:22 +0100)
----------------------------------------------------------------
AFS fixes
----------------------------------------------------------------
David Howells (2):
afs: Fix tracepoint string placement with built-in AFS
afs: Fix setting of writeback_index
Jiapeng Chong (1):
afs: Remove redundant assignment to ret
Tom Rix (1):
afs: check function return
fs/afs/cmservice.c | 25 +++++------------
fs/afs/dir.c | 10 ++++---
fs/afs/write.c | 18 ++++++++-----
include/trace/events/afs.h | 67 ++++++++++++++++++++++++++++++++++++++++++----
4 files changed, 87 insertions(+), 33 deletions(-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] afs: Miscellaneous fixes
2021-07-21 14:22 David Howells
@ 2021-07-21 19:47 ` pr-tracker-bot
0 siblings, 0 replies; 10+ messages in thread
From: pr-tracker-bot @ 2021-07-21 19:47 UTC (permalink / raw)
To: David Howells
Cc: torvalds, dhowells, linux-afs, Steven Rostedt (VMware),
Tom Rix, Marc Dionne, Alexey Dobriyan (SK hynix),
Jiapeng Chong, Abaci Robot, Andrew Morton, linux-fsdevel,
linux-kernel
The pull request you sent on Wed, 21 Jul 2021 15:22:06 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/afs-fixes-20210721
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/b4e62aaf95e8a340f3a6e0e2fc9a649f875034b3
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* [GIT PULL] afs: Miscellaneous fixes
@ 2023-11-24 15:52 David Howells
2023-11-24 18:39 ` Linus Torvalds
2023-11-24 18:54 ` pr-tracker-bot
0 siblings, 2 replies; 10+ messages in thread
From: David Howells @ 2023-11-24 15:52 UTC (permalink / raw)
To: torvalds; +Cc: dhowells, Marc Dionne, linux-afs, linux-fsdevel, linux-kernel
Hi Linus,
Here are a set of miscellaneous small fixes to the afs filesystem
including:
(1) Fix the afs_server_list struct to be cleaned up with RCU.
(2) Fix afs to translate a no-data result from a DNS lookup into ENOENT,
not EDESTADDRREQ for consistency with OpenAFS.
(3) Fix afs to translate a negative DNS lookup result into ENOENT rather
than EDESTADDRREQ.
(4) Fix file locking on R/O volumes to operate in local mode as the server
doesn't handle exclusive locks on such files.
(5) Set SB_RDONLY on superblocks for RO and Backup volumes so that the VFS
can see that they're read only.
Btw, I did want to ask about (5): Does a superblock being marked SB_RDONLY
imply immutability to the application? A 'read only' AFS volume is a snapshot
of a writable volume and can be updated. It's only read-only in the sense you
can't perform normal filesystem modification ops on it.
Link: https://lore.kernel.org/r/20231116155312.156593-1-dhowells@redhat.com/ # v1
Reviewed-by: Jeffrey Altman <jaltman@auristor.com>
Thanks,
David
---
The following changes since commit 76df934c6d5f5c93ba7a0112b1818620ddc10b19:
MAINTAINERS: Add netdev subsystem profile link (2023-11-17 03:44:21 +0000)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/afs-fixes-20231124
for you to fetch changes up to 68516f60c1d8b0a71e516d630f66b99cb50e0150:
afs: Mark a superblock for an R/O or Backup volume as SB_RDONLY (2023-11-24 14:52:24 +0000)
----------------------------------------------------------------
AFS Fixes
----------------------------------------------------------------
David Howells (5):
afs: Fix afs_server_list to be cleaned up with RCU
afs: Make error on cell lookup failure consistent with OpenAFS
afs: Return ENOENT if no cell DNS record can be found
afs: Fix file locking on R/O volumes to operate in local mode
afs: Mark a superblock for an R/O or Backup volume as SB_RDONLY
fs/afs/dynroot.c | 4 ++--
fs/afs/internal.h | 1 +
fs/afs/server_list.c | 2 +-
fs/afs/super.c | 4 ++++
fs/afs/vl_rotate.c | 10 ++++++++++
5 files changed, 18 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] afs: Miscellaneous fixes
2023-11-24 15:52 David Howells
@ 2023-11-24 18:39 ` Linus Torvalds
2023-11-24 18:54 ` pr-tracker-bot
1 sibling, 0 replies; 10+ messages in thread
From: Linus Torvalds @ 2023-11-24 18:39 UTC (permalink / raw)
To: David Howells; +Cc: Marc Dionne, linux-afs, linux-fsdevel, linux-kernel
On Fri, 24 Nov 2023 at 07:52, David Howells <dhowells@redhat.com> wrote:
> Btw, I did want to ask about (5): Does a superblock being marked SB_RDONLY
> imply immutability to the application?
Obviously not - any network filesystem can and will change from under
you, even if the local copy is read-only.
So SB_RDONLY can only mean that writes to that instance of the
filesystem will fail.
It's a bit stronger than MNT_READONLY, in that for a *local*
filesystem, SB_RDONLY tends to mean that it's truly immutable (while
MNT_READONLY is obviously per mount) but even then some sub-mount
thing (and I guess the AFS snapshot is a good example of that) might
expose the same filesystem through multiple superblocks.
Exactly like a network filesystem inevitably will.
In any case, any user space that thinks SB_RDONLY is some kind of
immutability signal is clearly buggy. At a minimum, such user space
would have to limit itself to particular filesystem types and say "I
know _this_ filesystem can have only one superblock"). And I'd argue
that while that might work in practice, it's insane.
Linus
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] afs: Miscellaneous fixes
2023-11-24 15:52 David Howells
2023-11-24 18:39 ` Linus Torvalds
@ 2023-11-24 18:54 ` pr-tracker-bot
1 sibling, 0 replies; 10+ messages in thread
From: pr-tracker-bot @ 2023-11-24 18:54 UTC (permalink / raw)
To: David Howells
Cc: torvalds, dhowells, Marc Dionne, linux-afs, linux-fsdevel, linux-kernel
The pull request you sent on Fri, 24 Nov 2023 15:52:20 +0000:
> git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/afs-fixes-20231124
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/5b7ad877e4d81f8904ce83982b1ba5c6e83deccb
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-11-24 18:54 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-11 21:17 [GIT PULL] afs: Miscellaneous fixes David Howells
2019-12-12 2:50 ` pr-tracker-bot
2020-04-24 16:12 David Howells
2020-04-24 17:35 ` Linus Torvalds
2020-04-24 18:40 ` pr-tracker-bot
2021-07-21 14:22 David Howells
2021-07-21 19:47 ` pr-tracker-bot
2023-11-24 15:52 David Howells
2023-11-24 18:39 ` Linus Torvalds
2023-11-24 18:54 ` pr-tracker-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).