From: Christoph Hellwig <hch@infradead.org>
To: adam.manzanares@wdc.com
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
axboe@kernel.dk, bcrl@kvack.org, mingo@kernel.org,
peterz@infradead.org, pombredanne@nexb.com,
gregkh@linuxfoundation.org, bigeasy@linutronix.de,
rgoldwyn@suse.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-aio@kvack.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH v4 3/3] fs: Add aio iopriority support for block_dev
Date: Fri, 18 May 2018 09:06:36 -0700 [thread overview]
Message-ID: <20180518160636.GH22791@infradead.org> (raw)
In-Reply-To: <20180517203803.2664-4-adam.manzanares@wdc.com>
Looks fine, although I'd split it into a aio and block_dev patch.
Also please wire this up for the fs/iomap.c direct I/O code, it should
be essentially the same sniplet as in the block_dev.c code.
next prev parent reply other threads:[~2018-05-18 16:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 20:38 [PATCH v4 0/3] AIO add per-command iopriority adam.manzanares
2018-05-17 20:38 ` [PATCH v4 1/3] block: add ioprio_check_cap function adam.manzanares
2018-05-18 16:04 ` Christoph Hellwig
2018-05-17 20:38 ` [PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16 adam.manzanares
2018-05-18 16:05 ` Christoph Hellwig
2018-05-18 19:53 ` Adam Manzanares
2018-05-17 20:38 ` [PATCH v4 3/3] fs: Add aio iopriority support for block_dev adam.manzanares
2018-05-18 15:14 ` Jens Axboe
2018-05-18 15:29 ` Adam Manzanares
2018-05-18 16:06 ` Christoph Hellwig [this message]
2018-05-18 19:54 ` Adam Manzanares
2018-05-18 20:08 ` kbuild test robot
2018-05-18 2:41 ` [PATCH v4 0/3] AIO add per-command iopriority Jens Axboe
2018-05-18 15:03 ` Adam Manzanares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518160636.GH22791@infradead.org \
--to=hch@infradead.org \
--cc=adam.manzanares@wdc.com \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-aio@kvack.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pombredanne@nexb.com \
--cc=rgoldwyn@suse.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).