From: Adam Manzanares <Adam.Manzanares@wdc.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"bcrl@kvack.org" <bcrl@kvack.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"pombredanne@nexb.com" <pombredanne@nexb.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"bigeasy@linutronix.de" <bigeasy@linutronix.de>,
"rgoldwyn@suse.com" <rgoldwyn@suse.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-aio@kvack.org" <linux-aio@kvack.org>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16
Date: Fri, 18 May 2018 19:53:36 +0000 [thread overview]
Message-ID: <db91bfca-4ec9-726d-aac1-fa5979c65692@wdc.com> (raw)
In-Reply-To: <20180518160512.GG22791@infradead.org>
On 5/18/18 9:05 AM, Christoph Hellwig wrote:
>> +/* ki_hint changed from enum to u16, make sure rw_hint fits into u16 */
>
> I don't think this comment is very useful.
>
>> +static inline u16 ki_hint_valid(enum rw_hint hint)
>
> I'd call this ki_hint_validate.
>
>> +{
>> + if (hint > MAX_KI_HINT)
>> + return 0;
>> +
>> + return hint;
>
> Nit: kill the empty line.
>
I'll clean this up in the next revision.
next prev parent reply other threads:[~2018-05-18 19:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 20:38 [PATCH v4 0/3] AIO add per-command iopriority adam.manzanares
2018-05-17 20:38 ` [PATCH v4 1/3] block: add ioprio_check_cap function adam.manzanares
2018-05-18 16:04 ` Christoph Hellwig
2018-05-17 20:38 ` [PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16 adam.manzanares
2018-05-18 16:05 ` Christoph Hellwig
2018-05-18 19:53 ` Adam Manzanares [this message]
2018-05-17 20:38 ` [PATCH v4 3/3] fs: Add aio iopriority support for block_dev adam.manzanares
2018-05-18 15:14 ` Jens Axboe
2018-05-18 15:29 ` Adam Manzanares
2018-05-18 16:06 ` Christoph Hellwig
2018-05-18 19:54 ` Adam Manzanares
2018-05-18 20:08 ` kbuild test robot
2018-05-18 2:41 ` [PATCH v4 0/3] AIO add per-command iopriority Jens Axboe
2018-05-18 15:03 ` Adam Manzanares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db91bfca-4ec9-726d-aac1-fa5979c65692@wdc.com \
--to=adam.manzanares@wdc.com \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-aio@kvack.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pombredanne@nexb.com \
--cc=rgoldwyn@suse.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).