* [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote
@ 2018-08-02 2:04 zhong jiang
2018-08-02 2:51 ` zhong jiang
2018-08-02 3:05 ` Al Viro
0 siblings, 2 replies; 3+ messages in thread
From: zhong jiang @ 2018-08-02 2:04 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, linux-kernel
It is unncessary to use double test for a expression. so just
remove one of them.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
fs/binfmt_elf_fdpic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c
index b53bb37..5162372 100644
--- a/fs/binfmt_elf_fdpic.c
+++ b/fs/binfmt_elf_fdpic.c
@@ -1288,7 +1288,7 @@ static int writenote(struct memelfnote *men, struct coredump_params *cprm)
return dump_emit(cprm, &en, sizeof(en)) &&
dump_emit(cprm, men->name, en.n_namesz) && dump_align(cprm, 4) &&
- dump_emit(cprm, men->data, men->datasz) && dump_align(cprm, 4);
+ dump_emit(cprm, men->data, men->datasz);
}
static inline void fill_elf_fdpic_header(struct elfhdr *elf, int segs)
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote
2018-08-02 2:04 [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote zhong jiang
@ 2018-08-02 2:51 ` zhong jiang
2018-08-02 3:05 ` Al Viro
1 sibling, 0 replies; 3+ messages in thread
From: zhong jiang @ 2018-08-02 2:51 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, linux-kernel
plese ingore it.
On 2018/8/2 10:04, zhong jiang wrote:
> It is unncessary to use double test for a expression. so just
> remove one of them.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> fs/binfmt_elf_fdpic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c
> index b53bb37..5162372 100644
> --- a/fs/binfmt_elf_fdpic.c
> +++ b/fs/binfmt_elf_fdpic.c
> @@ -1288,7 +1288,7 @@ static int writenote(struct memelfnote *men, struct coredump_params *cprm)
>
> return dump_emit(cprm, &en, sizeof(en)) &&
> dump_emit(cprm, men->name, en.n_namesz) && dump_align(cprm, 4) &&
> - dump_emit(cprm, men->data, men->datasz) && dump_align(cprm, 4);
> + dump_emit(cprm, men->data, men->datasz);
> }
>
> static inline void fill_elf_fdpic_header(struct elfhdr *elf, int segs)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote
2018-08-02 2:04 [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote zhong jiang
2018-08-02 2:51 ` zhong jiang
@ 2018-08-02 3:05 ` Al Viro
1 sibling, 0 replies; 3+ messages in thread
From: Al Viro @ 2018-08-02 3:05 UTC (permalink / raw)
To: zhong jiang; +Cc: linux-fsdevel, linux-kernel
On Thu, Aug 02, 2018 at 10:04:34AM +0800, zhong jiang wrote:
> It is unncessary to use double test for a expression. so just
> remove one of them.
... except when something in that expression might have side effects,
that is.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-02 4:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-02 2:04 [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote zhong jiang
2018-08-02 2:51 ` zhong jiang
2018-08-02 3:05 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).