* [PATCH RESEND] fs/namespace.c: make to_mnt_ns() static
@ 2019-01-10 20:41 Eric Biggers
2019-02-07 23:39 ` Eric Biggers
0 siblings, 1 reply; 3+ messages in thread
From: Eric Biggers @ 2019-01-10 20:41 UTC (permalink / raw)
To: linux-fsdevel, Alexander Viro
From: Eric Biggers <ebiggers@google.com>
to_mnt_ns() is only used in fs/namespace.c, so make it static.
This addresses a gcc warning when -Wmissing-prototypes is enabled.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/namespace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/namespace.c b/fs/namespace.c
index a677b59efd74e..2ba0dbd8573a2 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1688,7 +1688,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
dentry->d_fsdata == &mntns_operations;
}
-struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
+static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
{
return container_of(ns, struct mnt_namespace, ns);
}
--
2.20.1.97.g81188d93c3-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH RESEND] fs/namespace.c: make to_mnt_ns() static
2019-01-10 20:41 [PATCH RESEND] fs/namespace.c: make to_mnt_ns() static Eric Biggers
@ 2019-02-07 23:39 ` Eric Biggers
0 siblings, 0 replies; 3+ messages in thread
From: Eric Biggers @ 2019-02-07 23:39 UTC (permalink / raw)
To: linux-fsdevel, Alexander Viro
On Thu, Jan 10, 2019 at 12:41:47PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> to_mnt_ns() is only used in fs/namespace.c, so make it static.
>
> This addresses a gcc warning when -Wmissing-prototypes is enabled.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/namespace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index a677b59efd74e..2ba0dbd8573a2 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -1688,7 +1688,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
> dentry->d_fsdata == &mntns_operations;
> }
>
> -struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
> +static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
> {
> return container_of(ns, struct mnt_namespace, ns);
> }
> --
> 2.20.1.97.g81188d93c3-goog
>
Ping. Al, are you planning to apply this?
- Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH RESEND] fs/namespace.c: make to_mnt_ns() static
@ 2019-08-22 15:40 Eric Biggers
0 siblings, 0 replies; 3+ messages in thread
From: Eric Biggers @ 2019-08-22 15:40 UTC (permalink / raw)
To: Alexander Viro, linux-fsdevel
From: Eric Biggers <ebiggers@google.com>
Make to_mnt_ns() static to address the following 'sparse' warning:
fs/namespace.c:1736:22: warning: symbol 'to_mnt_ns' was not declared. Should it be static?
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/namespace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/namespace.c b/fs/namespace.c
index e6990f3d526d..41c6b848915c 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1734,7 +1734,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
dentry->d_fsdata == &mntns_operations;
}
-struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
+static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
{
return container_of(ns, struct mnt_namespace, ns);
}
--
2.22.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-22 15:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 20:41 [PATCH RESEND] fs/namespace.c: make to_mnt_ns() static Eric Biggers
2019-02-07 23:39 ` Eric Biggers
2019-08-22 15:40 Eric Biggers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).