From: Josef Bacik <josef@toxicpanda.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Josef Bacik <josef@toxicpanda.com>,
fsdevel <linux-fsdevel@vger.kernel.org>, Jan Kara <jack@suse.cz>,
Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH] fs: avoid softlockups in s_inodes iterators
Date: Fri, 11 Oct 2019 13:35:51 -0400 [thread overview]
Message-ID: <20191011173550.dldpghvslavhodhl@macbook-pro-91.dhcp.thefacebook.com> (raw)
In-Reply-To: <bed67fc8-641a-18c1-0547-369c75c51508@redhat.com>
On Fri, Oct 11, 2019 at 12:34:45PM -0500, Eric Sandeen wrote:
> On 10/11/19 12:29 PM, Josef Bacik wrote:
> > On Fri, Oct 11, 2019 at 11:49:38AM -0500, Eric Sandeen wrote:
> >> Anything that walks all inodes on sb->s_inodes list without rescheduling
> >> risks softlockups.
> >>
> >> Previous efforts were made in 2 functions, see:
> >>
> >> c27d82f fs/drop_caches.c: avoid softlockups in drop_pagecache_sb()
> >> ac05fbb inode: don't softlockup when evicting inodes
> >>
> >> but there hasn't been an audit of all walkers, so do that now. This
> >> also consistently moves the cond_resched() calls to the bottom of each
> >> loop.
> >>
> >> One remains: remove_dquot_ref(), because I'm not quite sure how to deal
> >> with that one w/o taking the i_lock.
> >>
> >> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> >
> > You've got iput cleanups in here and cond_resched()'s. I feel like this is a
> > missed opportunity to pad your patch count. Thanks,
>
> yeah, I was going to suggest that I could split it out into 3
> (move cond_rescheds, clean up iputs, add new rescheds) if there was a
> request. But it seemed a bit ridiculously granular. Find by me
> if desired, tho.
>
> So, was that a request?
I think just two patches, one for the iputs and one for the resched changes.
Thanks,
Josef
next prev parent reply other threads:[~2019-10-11 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 16:49 [PATCH] fs: avoid softlockups in s_inodes iterators Eric Sandeen
2019-10-11 17:29 ` Josef Bacik
2019-10-11 17:34 ` Eric Sandeen
2019-10-11 17:35 ` Josef Bacik [this message]
2019-10-11 18:32 ` Matthew Wilcox
2019-10-11 18:45 ` Eric Sandeen
2019-10-11 21:14 ` Eric Sandeen
2019-10-12 4:29 ` Dave Chinner
2019-10-14 8:46 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011173550.dldpghvslavhodhl@macbook-pro-91.dhcp.thefacebook.com \
--to=josef@toxicpanda.com \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).