From: Jan Kara <jack@suse.cz>
To: Eric Sandeen <sandeen@redhat.com>
Cc: fsdevel <linux-fsdevel@vger.kernel.org>, Jan Kara <jack@suse.cz>,
Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH] fs: avoid softlockups in s_inodes iterators
Date: Mon, 14 Oct 2019 10:46:09 +0200 [thread overview]
Message-ID: <20191014084609.GA5939@quack2.suse.cz> (raw)
In-Reply-To: <841d0e0f-f04c-9611-2eea-0bcc40e5b084@redhat.com>
On Fri 11-10-19 11:49:38, Eric Sandeen wrote:
> One remains: remove_dquot_ref(), because I'm not quite sure how to deal
> with that one w/o taking the i_lock.
Yeah, that will be somewhat tricky. But I think we can modify the standard
iget-iput dance like:
if (need_resched()) {
spin_lock(&inode->i_lock);
if (inode->i_state & (I_FREEING|I_WILL_FREE|I_NEW)) {
/*
* Cannot break on this inode, need to do one
* more.
*/
spin_unlock(&inode->i_lock);
continue;
}
__iget(inode);
spin_unlock(&inode->i_lock);
spin_unlock(&sb->s_inode_list_lock);
iput(put_inode);
put_inode = inode;
cond_resched();
spin_lock(&sb->s_inode_list_lock);
}
...
iput(put_inode);
Will you transform this into a proper patch in your series or should I do
it?
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2019-10-14 8:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 16:49 [PATCH] fs: avoid softlockups in s_inodes iterators Eric Sandeen
2019-10-11 17:29 ` Josef Bacik
2019-10-11 17:34 ` Eric Sandeen
2019-10-11 17:35 ` Josef Bacik
2019-10-11 18:32 ` Matthew Wilcox
2019-10-11 18:45 ` Eric Sandeen
2019-10-11 21:14 ` Eric Sandeen
2019-10-12 4:29 ` Dave Chinner
2019-10-14 8:46 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014084609.GA5939@quack2.suse.cz \
--to=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).