Linux-Fsdevel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] virtio_fs: Change module name to virtiofs.ko
@ 2019-10-11 18:18 Vivek Goyal
  2019-10-12  1:50 ` Masayoshi Mizuma
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Vivek Goyal @ 2019-10-11 18:18 UTC (permalink / raw)
  To: Miklos Szeredi, linux-fsdevel; +Cc: virtio-fs, msys.mizuma, stefanha

We have been calling it virtio_fs and even file name is virtio_fs.c. Module
name is virtio_fs.ko but when registering file system user is supposed to
specify filesystem type as "virtiofs".

Masayoshi Mizuma reported that he specified filesytem type as "virtio_fs" and
got this warning on console.

  ------------[ cut here ]------------
  request_module fs-virtio_fs succeeded, but still no fs?
  WARNING: CPU: 1 PID: 1234 at fs/filesystems.c:274 get_fs_type+0x12c/0x138
  Modules linked in: ... virtio_fs fuse virtio_net net_failover ...
  CPU: 1 PID: 1234 Comm: mount Not tainted 5.4.0-rc1 #1

So looks like kernel could find the module virtio_fs.ko but could not find
filesystem type after that.

It probably is better to rename module name to virtiofs.ko so that above
warning goes away in case user ends up specifying wrong fs name.

Reported-by: Masayoshi Mizuma <msys.mizuma@gmail.com>
Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
 fs/fuse/Makefile |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: rhvgoyal-linux/fs/fuse/Makefile
===================================================================
--- rhvgoyal-linux.orig/fs/fuse/Makefile	2019-10-11 13:53:43.905757435 -0400
+++ rhvgoyal-linux/fs/fuse/Makefile	2019-10-11 13:54:24.147757435 -0400
@@ -5,6 +5,7 @@
 
 obj-$(CONFIG_FUSE_FS) += fuse.o
 obj-$(CONFIG_CUSE) += cuse.o
-obj-$(CONFIG_VIRTIO_FS) += virtio_fs.o
+obj-$(CONFIG_VIRTIO_FS) += virtiofs.o
 
 fuse-objs := dev.o dir.o file.o inode.o control.o xattr.o acl.o readdir.o
+virtiofs-y += virtio_fs.o

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] virtio_fs: Change module name to virtiofs.ko
  2019-10-11 18:18 [PATCH] virtio_fs: Change module name to virtiofs.ko Vivek Goyal
@ 2019-10-12  1:50 ` Masayoshi Mizuma
  2019-10-12 10:23 ` Stefan Hajnoczi
  2019-10-14  8:25 ` Miklos Szeredi
  2 siblings, 0 replies; 4+ messages in thread
From: Masayoshi Mizuma @ 2019-10-12  1:50 UTC (permalink / raw)
  To: Vivek Goyal; +Cc: Miklos Szeredi, linux-fsdevel, virtio-fs, stefanha

Hi Vivek,

On Fri, Oct 11, 2019 at 02:18:26PM -0400, Vivek Goyal wrote:
> We have been calling it virtio_fs and even file name is virtio_fs.c. Module
> name is virtio_fs.ko but when registering file system user is supposed to
> specify filesystem type as "virtiofs".
> 
> Masayoshi Mizuma reported that he specified filesytem type as "virtio_fs" and
> got this warning on console.
> 
>   ------------[ cut here ]------------
>   request_module fs-virtio_fs succeeded, but still no fs?
>   WARNING: CPU: 1 PID: 1234 at fs/filesystems.c:274 get_fs_type+0x12c/0x138
>   Modules linked in: ... virtio_fs fuse virtio_net net_failover ...
>   CPU: 1 PID: 1234 Comm: mount Not tainted 5.4.0-rc1 #1
> 
> So looks like kernel could find the module virtio_fs.ko but could not find
> filesystem type after that.
> 
> It probably is better to rename module name to virtiofs.ko so that above
> warning goes away in case user ends up specifying wrong fs name.

The warning is gone after applied this patch, thanks!
Please feel free to add:

    Tested-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>

- Masa

> 
> Reported-by: Masayoshi Mizuma <msys.mizuma@gmail.com>
> Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> ---
>  fs/fuse/Makefile |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: rhvgoyal-linux/fs/fuse/Makefile
> ===================================================================
> --- rhvgoyal-linux.orig/fs/fuse/Makefile	2019-10-11 13:53:43.905757435 -0400
> +++ rhvgoyal-linux/fs/fuse/Makefile	2019-10-11 13:54:24.147757435 -0400
> @@ -5,6 +5,7 @@
>  
>  obj-$(CONFIG_FUSE_FS) += fuse.o
>  obj-$(CONFIG_CUSE) += cuse.o
> -obj-$(CONFIG_VIRTIO_FS) += virtio_fs.o
> +obj-$(CONFIG_VIRTIO_FS) += virtiofs.o
>  
>  fuse-objs := dev.o dir.o file.o inode.o control.o xattr.o acl.o readdir.o
> +virtiofs-y += virtio_fs.o

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] virtio_fs: Change module name to virtiofs.ko
  2019-10-11 18:18 [PATCH] virtio_fs: Change module name to virtiofs.ko Vivek Goyal
  2019-10-12  1:50 ` Masayoshi Mizuma
@ 2019-10-12 10:23 ` Stefan Hajnoczi
  2019-10-14  8:25 ` Miklos Szeredi
  2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2019-10-12 10:23 UTC (permalink / raw)
  To: Vivek Goyal; +Cc: Miklos Szeredi, linux-fsdevel, virtio-fs, msys.mizuma

[-- Attachment #1: Type: text/plain, Size: 1827 bytes --]

On Fri, Oct 11, 2019 at 02:18:26PM -0400, Vivek Goyal wrote:
> We have been calling it virtio_fs and even file name is virtio_fs.c. Module
> name is virtio_fs.ko but when registering file system user is supposed to
> specify filesystem type as "virtiofs".
> 
> Masayoshi Mizuma reported that he specified filesytem type as "virtio_fs" and
> got this warning on console.
> 
>   ------------[ cut here ]------------
>   request_module fs-virtio_fs succeeded, but still no fs?
>   WARNING: CPU: 1 PID: 1234 at fs/filesystems.c:274 get_fs_type+0x12c/0x138
>   Modules linked in: ... virtio_fs fuse virtio_net net_failover ...
>   CPU: 1 PID: 1234 Comm: mount Not tainted 5.4.0-rc1 #1
> 
> So looks like kernel could find the module virtio_fs.ko but could not find
> filesystem type after that.
> 
> It probably is better to rename module name to virtiofs.ko so that above
> warning goes away in case user ends up specifying wrong fs name.
> 
> Reported-by: Masayoshi Mizuma <msys.mizuma@gmail.com>
> Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> ---
>  fs/fuse/Makefile |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: rhvgoyal-linux/fs/fuse/Makefile
> ===================================================================
> --- rhvgoyal-linux.orig/fs/fuse/Makefile	2019-10-11 13:53:43.905757435 -0400
> +++ rhvgoyal-linux/fs/fuse/Makefile	2019-10-11 13:54:24.147757435 -0400
> @@ -5,6 +5,7 @@
>  
>  obj-$(CONFIG_FUSE_FS) += fuse.o
>  obj-$(CONFIG_CUSE) += cuse.o
> -obj-$(CONFIG_VIRTIO_FS) += virtio_fs.o
> +obj-$(CONFIG_VIRTIO_FS) += virtiofs.o
>  
>  fuse-objs := dev.o dir.o file.o inode.o control.o xattr.o acl.o readdir.o
> +virtiofs-y += virtio_fs.o

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] virtio_fs: Change module name to virtiofs.ko
  2019-10-11 18:18 [PATCH] virtio_fs: Change module name to virtiofs.ko Vivek Goyal
  2019-10-12  1:50 ` Masayoshi Mizuma
  2019-10-12 10:23 ` Stefan Hajnoczi
@ 2019-10-14  8:25 ` Miklos Szeredi
  2 siblings, 0 replies; 4+ messages in thread
From: Miklos Szeredi @ 2019-10-14  8:25 UTC (permalink / raw)
  To: Vivek Goyal; +Cc: linux-fsdevel, virtio-fs, msys.mizuma, Stefan Hajnoczi

On Fri, Oct 11, 2019 at 8:18 PM Vivek Goyal <vgoyal@redhat.com> wrote:
>
> We have been calling it virtio_fs and even file name is virtio_fs.c. Module
> name is virtio_fs.ko but when registering file system user is supposed to
> specify filesystem type as "virtiofs".
>
> Masayoshi Mizuma reported that he specified filesytem type as "virtio_fs" and
> got this warning on console.
>
>   ------------[ cut here ]------------
>   request_module fs-virtio_fs succeeded, but still no fs?
>   WARNING: CPU: 1 PID: 1234 at fs/filesystems.c:274 get_fs_type+0x12c/0x138
>   Modules linked in: ... virtio_fs fuse virtio_net net_failover ...
>   CPU: 1 PID: 1234 Comm: mount Not tainted 5.4.0-rc1 #1
>
> So looks like kernel could find the module virtio_fs.ko but could not find
> filesystem type after that.
>
> It probably is better to rename module name to virtiofs.ko so that above
> warning goes away in case user ends up specifying wrong fs name.
>
> Reported-by: Masayoshi Mizuma <msys.mizuma@gmail.com>
> Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>

Thanks, applied.

Miklos

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-11 18:18 [PATCH] virtio_fs: Change module name to virtiofs.ko Vivek Goyal
2019-10-12  1:50 ` Masayoshi Mizuma
2019-10-12 10:23 ` Stefan Hajnoczi
2019-10-14  8:25 ` Miklos Szeredi

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org
	public-inbox-index linux-fsdevel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git