From: Al Viro <viro@zeniv.linux.org.uk>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, Andrew Price <anprice@redhat.com>,
David Howells <dhowells@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 02/12] fs_parse: fix fs_param_v_optional handling
Date: Tue, 17 Dec 2019 03:27:45 +0000 [thread overview]
Message-ID: <20191217032745.GR4203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20191217011813.GQ4203@ZenIV.linux.org.uk>
On Tue, Dec 17, 2019 at 01:18:13AM +0000, Al Viro wrote:
> So how about a flag for "takes no arguments", set automatically by
> fsparam_flag()/fsparam_flag_no(), with fs_lookup_key() taking an
> extra "comes with argument" flag and filtering according to it?
> Rules:
> foo => "foo", true
> foo= => "foo", false
> foo=bar => "foo", false
> And to hell with the "optional" flag; for gfs2 we'd end up with
> fsparam_flag_no("quota", Opt_quota_flag), // quota|noquota
> fsparam_flag_enum("quota", Opt_quota, gfs2_param_quota), // quota={on|account|off}
> Postprocessing won't be any harder, really - we could bloody well do
> case Opt_quota_flag:
> result.int_32 = result.negated ? GFS2_QUOTA_OFF : GFS2_QUOTA_ON;
> /* fallthru */
> case Opt_quota:
> args->ar_quota = result.int_32;
> break;
> with gfs2_param_quota having the right values in it, instead of
> that intermediate enum.
>
> All ->has_value checks go away that way, AFAICS. With minimal
> impact on yet-to-be-merged series...
FWIW, we have the following types right now:
fs_param_is_flag no argument
fs_param_is_bool no argument or string argument (1 instance in mainline[*])
fs_param_is_u32 string argument [**]
fs_param_is_u32_octal string argument
fs_param_is_u32_hex string argument
fs_param_is_s32 string argument
fs_param_is_u64 string argument
fs_param_is_enum string argument; gfs2 has the quota/noquota/quota=... mess
fs_param_is_string string argument; ceph (and nfs) have fsc/nofsc/fsc=...
fs_param_is_fd unused at the moment; eventually - string argument.
fs_param_is_blob fsconfig-only
fs_param_is_blockdev fsconfig-only
fs_param_is_path fsconfig-only
[*] no_disconnect in gadgetfs; buggered, since it used to require a numeric
argument. Now it quietly treats no_disconnect as no_disconnect=1 and
rejects e.g. no_disconnect=2. There are two more in ext4, also buggered
as far as I can tell.
[**] ext4 has init_itable/init_itable=%u/noinit_itable
The total over all filesystems with conversions posted or already in mainline:
* no_disconnect [drivers/usb/gadget/function/f_fs.c, broken]
* init_itable/init_itable=%u/noinit_itable [ext4]
* fsc/fsc=%s/nofsc [ceph]
* fsc/fsc=%s/nofsc [nfs]
* quota/quota=on/quota=off/quota=account/noquota [gfs2]
* barrier/barrier=%u/nobarrier [ext4]
* auto_da_alloc/auto_da_alloc=%u/noauto_da_alloc [ext4]
It's rare. So much that I don't believe that fs_param_v_optional has any
reason to exist. Let's split those entries and be done with that.
Hmm... Deciding whether we have an argument-bearing or no-argument case
is somewhat inconvenient for fsconfig-generated calls - check for
NULL param->string is, strictly speaking, in nasal daemon territory
for types other than flag and string... OK, sold - let's check for
fs_value_is_flag. So I'm combining your patch with #9/12 (to avoid bisect
hazard) + correction for rbd. And putting that in the very beginning of
fs_parser reorg series, with elimination of fs_param_v_optional closer
to the end.
next prev parent reply other threads:[~2019-12-17 3:27 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 15:59 [PATCH 00/12] various vfs patches Miklos Szeredi
2019-11-28 15:59 ` [PATCH 01/12] aio: fix async fsync creds Miklos Szeredi
2019-12-13 9:32 ` Miklos Szeredi
2020-05-04 8:05 ` Avi Kivity
2019-11-28 15:59 ` [PATCH 02/12] fs_parse: fix fs_param_v_optional handling Miklos Szeredi
2019-11-29 11:31 ` Andrew Price
2019-11-29 14:43 ` Miklos Szeredi
2019-11-29 15:56 ` Andrew Price
2019-12-16 23:28 ` Al Viro
2019-12-17 1:18 ` Al Viro
2019-12-17 3:27 ` Al Viro [this message]
2019-11-28 15:59 ` [PATCH 03/12] vfs: verify param type in vfs_parse_sb_flag() Miklos Szeredi
2019-11-28 15:59 ` [PATCH 04/12] uapi: deprecate STATX_ALL Miklos Szeredi
2019-11-28 15:59 ` [PATCH 05/12] statx: don't clear STATX_ATIME on SB_RDONLY Miklos Szeredi
2019-11-28 15:59 ` [PATCH 06/12] utimensat: AT_EMPTY_PATH support Miklos Szeredi
2019-11-28 15:59 ` [PATCH 07/12] f*xattr: allow O_PATH descriptors Miklos Szeredi
2019-11-28 15:59 ` [PATCH 08/12] vfs: allow unprivileged whiteout creation Miklos Szeredi
2019-12-17 3:51 ` Al Viro
2019-12-17 4:22 ` Miklos Szeredi
2019-11-28 15:59 ` [PATCH 09/12] fs_parser: "string" with missing value is a "flag" Miklos Szeredi
2019-12-17 17:32 ` Al Viro
2019-12-17 18:31 ` Al Viro
2019-11-28 15:59 ` [PATCH 10/12] vfs: don't parse forbidden flags Miklos Szeredi
2019-11-28 15:59 ` [PATCH 11/12] vfs: don't parse "posixacl" option Miklos Szeredi
2019-12-17 3:42 ` Al Viro
2019-12-17 4:18 ` Miklos Szeredi
2019-12-17 4:28 ` Al Viro
2019-11-28 15:59 ` [PATCH 12/12] vfs: don't parse "silent" option Miklos Szeredi
2019-12-17 3:37 ` Al Viro
2019-12-17 4:12 ` Miklos Szeredi
2019-12-17 4:16 ` Miklos Szeredi
2019-12-17 4:19 ` Al Viro
2019-12-17 4:23 ` Miklos Szeredi
2019-12-17 4:28 ` Miklos Szeredi
2019-12-17 4:17 ` Al Viro
2019-12-13 9:33 ` [PATCH 00/12] various vfs patches Miklos Szeredi
2019-12-16 23:13 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217032745.GR4203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=anprice@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).