Linux-Fsdevel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/2 V6]Add dma-buf counter
@ 2021-04-20  8:22 Peter Enderborg
  2021-04-20  8:22 ` [PATCH 1/2 V6] dma-buf: Add DmaBufTotal counter in meminfo Peter Enderborg
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Peter Enderborg @ 2021-04-20  8:22 UTC (permalink / raw)
  To: linux-kernel, linux-fsdevel, Sumit Semwal, Christian König,
	Alexey Dobriyan, Andrew Morton, Muchun Song, Roman Gushchin,
	Shakeel Butt, Michal Hocko, NeilBrown, Sami Tolvanen,
	Mike Rapoport, linux-media, dri-devel, linaro-mm-sig,
	Matthew Wilcox, Jonathan Corbet, Randy Dunlap, Kees Cook,
	Mauro Carvalho Chehab, Alexey Gladkov, Feng Tang, linux-doc

The dma-buf counter is a metric for mapped memory used by it's clients.
It is a shared buffer that is typically used for interprocess communication
or process to hardware communication. In android we used to have ION,. but
it is now replaced with dma-buf. ION had some overview metrics that was similar.



V1
	initial version. Add dma-buf counter

V2
	Fix build depencendy error suggested by Matthew Wilcox
	Extent commit message sugged by Köning

V3
	Change variable and function names.

V4
	Fix function name in code doc
	Reported-by: kernel test robot <lkp@intel.com>

V5
	Removed EXPORT_SYMBOL_GPL suggested by Muchun Song

V6
	Made it a patch set, Adding a addional patch for
	printing dma-buf counter in show_mem.
	Suggested by Michal Hocko.




	


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2 V6] dma-buf: Add DmaBufTotal counter in meminfo
  2021-04-20  8:22 [PATCH 0/2 V6]Add dma-buf counter Peter Enderborg
@ 2021-04-20  8:22 ` Peter Enderborg
  2021-04-20  8:22 ` [PATCH 2/2 V6] lib/show_mem.c: Add dma-buf counter to show_mem dump Peter Enderborg
  2021-04-20  8:30 ` [PATCH 0/2 V6]Add dma-buf counter Michal Hocko
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Enderborg @ 2021-04-20  8:22 UTC (permalink / raw)
  To: linux-kernel, linux-fsdevel, Sumit Semwal, Christian König,
	Alexey Dobriyan, Andrew Morton, Muchun Song, Roman Gushchin,
	Shakeel Butt, Michal Hocko, NeilBrown, Sami Tolvanen,
	Mike Rapoport, linux-media, dri-devel, linaro-mm-sig,
	Matthew Wilcox, Jonathan Corbet, Randy Dunlap, Kees Cook,
	Mauro Carvalho Chehab, Alexey Gladkov, Feng Tang, linux-doc
  Cc: Peter Enderborg

This adds a total used dma-buf memory. Details
can be found in debugfs, however it is not for everyone
and not always available. dma-buf are indirect allocated by
userspace. So with this value we can monitor and detect
userspace applications that have problems. Typical usage
is to see that system does not do to much pre-allocations,
finding memory leaks in userspace, such as not all clients
close down the reference to the buffer.

Signed-off-by: Peter Enderborg <peter.enderborg@sony.com>
---
 Documentation/filesystems/proc.rst |  5 +++++
 drivers/dma-buf/dma-buf.c          | 12 ++++++++++++
 fs/proc/meminfo.c                  |  5 ++++-
 include/linux/dma-buf.h            |  1 +
 4 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
index 48fbfc336ebf..a85df9490810 100644
--- a/Documentation/filesystems/proc.rst
+++ b/Documentation/filesystems/proc.rst
@@ -973,6 +973,7 @@ varies by architecture and compile options.  The following is from a
     AnonHugePages:   49152 kB
     ShmemHugePages:      0 kB
     ShmemPmdMapped:      0 kB
+    DmaBufTotal          0 kB
 
 MemTotal
               Total usable RAM (i.e. physical RAM minus a few reserved
@@ -1102,6 +1103,10 @@ VmallocChunk
 Percpu
               Memory allocated to the percpu allocator used to back percpu
               allocations. This stat excludes the cost of metadata.
+DmaBufTotal
+              Memory allocated by dma-buf driver.What memory is used
+	      is  arbitrary. (It might be kernel, local or even hardware vram).
+	      Details on buffers are found in debugfs if enabled.
 
 vmallocinfo
 ~~~~~~~~~~~
diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
index f264b70c383e..4dc37cd4293b 100644
--- a/drivers/dma-buf/dma-buf.c
+++ b/drivers/dma-buf/dma-buf.c
@@ -37,6 +37,7 @@ struct dma_buf_list {
 };
 
 static struct dma_buf_list db_list;
+static atomic_long_t dma_buf_global_allocated;
 
 static char *dmabuffs_dname(struct dentry *dentry, char *buffer, int buflen)
 {
@@ -79,6 +80,7 @@ static void dma_buf_release(struct dentry *dentry)
 	if (dmabuf->resv == (struct dma_resv *)&dmabuf[1])
 		dma_resv_fini(dmabuf->resv);
 
+	atomic_long_sub(dmabuf->size, &dma_buf_global_allocated);
 	module_put(dmabuf->owner);
 	kfree(dmabuf->name);
 	kfree(dmabuf);
@@ -586,6 +588,7 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info)
 	mutex_lock(&db_list.lock);
 	list_add(&dmabuf->list_node, &db_list.head);
 	mutex_unlock(&db_list.lock);
+	atomic_long_add(dmabuf->size, &dma_buf_global_allocated);
 
 	return dmabuf;
 
@@ -1346,6 +1349,15 @@ void dma_buf_vunmap(struct dma_buf *dmabuf, struct dma_buf_map *map)
 }
 EXPORT_SYMBOL_GPL(dma_buf_vunmap);
 
+/**
+ * dma_buf_allocated_pages - Return the used nr of pages
+ * allocated for dma-buf
+ */
+long dma_buf_allocated_pages(void)
+{
+	return atomic_long_read(&dma_buf_global_allocated) >> PAGE_SHIFT;
+}
+
 #ifdef CONFIG_DEBUG_FS
 static int dma_buf_debug_show(struct seq_file *s, void *unused)
 {
diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c
index 6fa761c9cc78..ccc7c40c8db7 100644
--- a/fs/proc/meminfo.c
+++ b/fs/proc/meminfo.c
@@ -16,6 +16,7 @@
 #ifdef CONFIG_CMA
 #include <linux/cma.h>
 #endif
+#include <linux/dma-buf.h>
 #include <asm/page.h>
 #include "internal.h"
 
@@ -145,7 +146,9 @@ static int meminfo_proc_show(struct seq_file *m, void *v)
 	show_val_kb(m, "CmaFree:        ",
 		    global_zone_page_state(NR_FREE_CMA_PAGES));
 #endif
-
+#ifdef CONFIG_DMA_SHARED_BUFFER
+	show_val_kb(m, "DmaBufTotal:    ", dma_buf_allocated_pages());
+#endif
 	hugetlb_report_meminfo(m);
 
 	arch_report_meminfo(m);
diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
index efdc56b9d95f..5b05816bd2cd 100644
--- a/include/linux/dma-buf.h
+++ b/include/linux/dma-buf.h
@@ -507,4 +507,5 @@ int dma_buf_mmap(struct dma_buf *, struct vm_area_struct *,
 		 unsigned long);
 int dma_buf_vmap(struct dma_buf *dmabuf, struct dma_buf_map *map);
 void dma_buf_vunmap(struct dma_buf *dmabuf, struct dma_buf_map *map);
+long dma_buf_allocated_pages(void);
 #endif /* __DMA_BUF_H__ */
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2 V6] lib/show_mem.c:  Add dma-buf counter to show_mem dump.
  2021-04-20  8:22 [PATCH 0/2 V6]Add dma-buf counter Peter Enderborg
  2021-04-20  8:22 ` [PATCH 1/2 V6] dma-buf: Add DmaBufTotal counter in meminfo Peter Enderborg
@ 2021-04-20  8:22 ` Peter Enderborg
  2021-04-20  8:30 ` [PATCH 0/2 V6]Add dma-buf counter Michal Hocko
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Enderborg @ 2021-04-20  8:22 UTC (permalink / raw)
  To: linux-kernel, linux-fsdevel, Sumit Semwal, Christian König,
	Alexey Dobriyan, Andrew Morton, Muchun Song, Roman Gushchin,
	Shakeel Butt, Michal Hocko, NeilBrown, Sami Tolvanen,
	Mike Rapoport, linux-media, dri-devel, linaro-mm-sig,
	Matthew Wilcox, Jonathan Corbet, Randy Dunlap, Kees Cook,
	Mauro Carvalho Chehab, Alexey Gladkov, Feng Tang, linux-doc
  Cc: Peter Enderborg

On system where dma-buf is used it can be many clients that adds up
to a lot of memory. This can be relevant for OOM handling when
running out of memory or how system handle this memory. It may be to free
with a kill.

Suggested-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Peter Enderborg <peter.enderborg@sony.com>
---
 lib/show_mem.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/show_mem.c b/lib/show_mem.c
index 1c26c14ffbb9..ec4748c64353 100644
--- a/lib/show_mem.c
+++ b/lib/show_mem.c
@@ -7,6 +7,7 @@
 
 #include <linux/mm.h>
 #include <linux/cma.h>
+#include <linux/dma-buf.h>
 
 void show_mem(unsigned int filter, nodemask_t *nodemask)
 {
@@ -41,4 +42,8 @@ void show_mem(unsigned int filter, nodemask_t *nodemask)
 #ifdef CONFIG_MEMORY_FAILURE
 	printk("%lu pages hwpoisoned\n", atomic_long_read(&num_poisoned_pages));
 #endif
+#ifdef CONFIG_DMA_SHARED_BUFFER
+	printk("%lu pages dma-buf\n", dma_buf_allocated_pages());
+#endif
+
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2 V6]Add dma-buf counter
  2021-04-20  8:22 [PATCH 0/2 V6]Add dma-buf counter Peter Enderborg
  2021-04-20  8:22 ` [PATCH 1/2 V6] dma-buf: Add DmaBufTotal counter in meminfo Peter Enderborg
  2021-04-20  8:22 ` [PATCH 2/2 V6] lib/show_mem.c: Add dma-buf counter to show_mem dump Peter Enderborg
@ 2021-04-20  8:30 ` Michal Hocko
  2 siblings, 0 replies; 4+ messages in thread
From: Michal Hocko @ 2021-04-20  8:30 UTC (permalink / raw)
  To: Peter Enderborg
  Cc: linux-kernel, linux-fsdevel, Sumit Semwal, Christian König,
	Alexey Dobriyan, Andrew Morton, Muchun Song, Roman Gushchin,
	Shakeel Butt, NeilBrown, Sami Tolvanen, Mike Rapoport,
	linux-media, dri-devel, linaro-mm-sig, Matthew Wilcox,
	Jonathan Corbet, Randy Dunlap, Kees Cook, Mauro Carvalho Chehab,
	Alexey Gladkov, Feng Tang, linux-doc

On Tue 20-04-21 10:22:18, Peter Enderborg wrote:
> The dma-buf counter is a metric for mapped memory used by it's clients.
> It is a shared buffer that is typically used for interprocess communication
> or process to hardware communication. In android we used to have ION,. but
> it is now replaced with dma-buf. ION had some overview metrics that was similar.

The discussion around the previous version is still not over and as it
seems your proposed approach is not really viable. So please do not send
new versions until that is sorted out.

Thanks!
-- 
Michal Hocko
SUSE Labs

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20  8:22 [PATCH 0/2 V6]Add dma-buf counter Peter Enderborg
2021-04-20  8:22 ` [PATCH 1/2 V6] dma-buf: Add DmaBufTotal counter in meminfo Peter Enderborg
2021-04-20  8:22 ` [PATCH 2/2 V6] lib/show_mem.c: Add dma-buf counter to show_mem dump Peter Enderborg
2021-04-20  8:30 ` [PATCH 0/2 V6]Add dma-buf counter Michal Hocko

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org
	public-inbox-index linux-fsdevel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git