From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, Al Viro <viro@zeniv.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] fs: unexport __set_page_dirty
Date: Mon, 14 Jun 2021 11:42:07 +0200 [thread overview]
Message-ID: <20210614094207.GB26615@quack2.suse.cz> (raw)
In-Reply-To: <20210614061512.3966143-2-hch@lst.de>
On Mon 14-06-21 08:15:10, Christoph Hellwig wrote:
> __set_page_dirty is only used by built-in code.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/buffer.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index ea48c01fb76b..3d18831c7ad8 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -611,7 +611,6 @@ void __set_page_dirty(struct page *page, struct address_space *mapping,
> }
> xa_unlock_irqrestore(&mapping->i_pages, flags);
> }
> -EXPORT_SYMBOL_GPL(__set_page_dirty);
>
> /*
> * Add a page to the dirty page list.
> --
> 2.30.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2021-06-14 9:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 6:15 remove the implicit .set_page_dirty default Christoph Hellwig
2021-06-14 6:15 ` [PATCH 1/3] fs: unexport __set_page_dirty Christoph Hellwig
2021-06-14 6:23 ` Greg Kroah-Hartman
2021-06-14 9:42 ` Jan Kara [this message]
2021-06-14 12:32 ` Matthew Wilcox
2021-06-14 15:52 ` Christoph Hellwig
2021-06-14 6:15 ` [PATCH 2/3] fs: move ramfs_aops to libfs Christoph Hellwig
2021-06-14 6:24 ` Greg Kroah-Hartman
2021-06-14 9:45 ` Jan Kara
2021-06-14 6:15 ` [PATCH 3/3] mm: require ->set_page_dirty to be explicitly wire up Christoph Hellwig
2021-06-14 6:24 ` Greg Kroah-Hartman
2021-06-14 9:51 ` Jan Kara
2021-06-14 10:03 ` Christoph Hellwig
2021-06-18 19:23 ` Dmitry Osipenko
2021-06-21 5:26 ` Christoph Hellwig
2021-06-14 12:23 ` remove the implicit .set_page_dirty default Matthew Wilcox
2021-06-14 15:53 ` Christoph Hellwig
2021-06-14 15:55 ` Christoph Hellwig
2021-06-14 16:17 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614094207.GB26615@quack2.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).