From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, Al Viro <viro@zeniv.linux.org.uk>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] fs: move ramfs_aops to libfs
Date: Mon, 14 Jun 2021 08:24:24 +0200 [thread overview]
Message-ID: <YMb2GLLl1pfztwrT@kroah.com> (raw)
In-Reply-To: <20210614061512.3966143-3-hch@lst.de>
On Mon, Jun 14, 2021 at 08:15:11AM +0200, Christoph Hellwig wrote:
> Move the ramfs aops to libfs and reuse them for kernfs and configfs.
> Thosw two did not wire up ->set_page_dirty before and now get
> __set_page_dirty_no_writeback, which is the right one for no-writeback
> address_space usage.
>
> Drop the now unused exports of the libfs helpers only used for
> ramfs-style pagecache usage.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/configfs/inode.c | 8 +-------
> fs/kernfs/inode.c | 8 +-------
> fs/libfs.c | 17 +++++++++++++----
> fs/ramfs/inode.c | 9 +--------
> include/linux/fs.h | 5 +----
> 5 files changed, 17 insertions(+), 30 deletions(-)
>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2021-06-14 6:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 6:15 remove the implicit .set_page_dirty default Christoph Hellwig
2021-06-14 6:15 ` [PATCH 1/3] fs: unexport __set_page_dirty Christoph Hellwig
2021-06-14 6:23 ` Greg Kroah-Hartman
2021-06-14 9:42 ` Jan Kara
2021-06-14 12:32 ` Matthew Wilcox
2021-06-14 15:52 ` Christoph Hellwig
2021-06-14 6:15 ` [PATCH 2/3] fs: move ramfs_aops to libfs Christoph Hellwig
2021-06-14 6:24 ` Greg Kroah-Hartman [this message]
2021-06-14 9:45 ` Jan Kara
2021-06-14 6:15 ` [PATCH 3/3] mm: require ->set_page_dirty to be explicitly wire up Christoph Hellwig
2021-06-14 6:24 ` Greg Kroah-Hartman
2021-06-14 9:51 ` Jan Kara
2021-06-14 10:03 ` Christoph Hellwig
2021-06-18 19:23 ` Dmitry Osipenko
2021-06-21 5:26 ` Christoph Hellwig
2021-06-14 12:23 ` remove the implicit .set_page_dirty default Matthew Wilcox
2021-06-14 15:53 ` Christoph Hellwig
2021-06-14 15:55 ` Christoph Hellwig
2021-06-14 16:17 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMb2GLLl1pfztwrT@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).