From: Jens Axboe <axboe@kernel.dk>
To: hubcap@kernel.org, linux-fsdevel@vger.kernel.org
Cc: Mike Marshall <hubcap@omnibond.com>,
viro@zeniv.linux.org.uk, hch@lst.de, martin@omnibond.com
Subject: Re: [PATCH 0/2] aio: intialize kiocb private
Date: Wed, 6 Feb 2019 08:05:02 -0700 [thread overview]
Message-ID: <41f75d4e-fddd-3397-2b5b-fe47a9c694a4@kernel.dk> (raw)
In-Reply-To: <20190205191335.22056-1-hubcap@kernel.org>
On 2/5/19 12:13 PM, hubcap@kernel.org wrote:
> From: Mike Marshall <hubcap@omnibond.com>
>
> "aio: don't zero entire aio_kiocb aio_get_req" triggered these
> BUG_ONs in orangefs file.c. Obviously the BUG_ONs need to go.
>
> There might be other filesystems that use iocb->private without
> failing in a way that is as obvious as BUG_ON, though I didn't
> see any with grep.
>
> After discussion on fsdevel, Jens Axboe suggested I should send
> in a patch that continues to set iocb->private to NULL just in case.
>
> Also... phooey on fighting gmail when trying to send patches with
> git-send-email... mail.kernel.org works great!
Applied 1/2, 2/2 should probably just go in separately with other
orangefs patches, when appropriate.
--
Jens Axboe
prev parent reply other threads:[~2019-02-06 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 19:13 [PATCH 0/2] aio: intialize kiocb private hubcap
2019-02-05 19:13 ` [PATCH 1/2] orangefs: remove two un-needed BUG_ONs hubcap
2019-02-06 6:58 ` Christoph Hellwig
2019-02-06 13:22 ` Mike Marshall
2019-02-05 19:13 ` [PATCH 2/2] aio: initialize kiocb private in case any filesystems expect it hubcap
2019-02-06 6:58 ` Christoph Hellwig
2019-02-06 15:05 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41f75d4e-fddd-3397-2b5b-fe47a9c694a4@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=hubcap@kernel.org \
--cc=hubcap@omnibond.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=martin@omnibond.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).