linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kani, Toshi" <toshi.kani@hpe.com>
To: "jack@suse.cz" <jack@suse.cz>,
	"Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: open sets ext4_da_aops for DAX existing files
Date: Tue, 11 Sep 2018 16:34:03 +0000	[thread overview]
Message-ID: <6d94d09e2539991db4853042b57bcf6274460f49.camel@hpe.com> (raw)
In-Reply-To: <20180911152706.GG6104@quack2.suse.cz>

On Tue, 2018-09-11 at 17:27 +0200, Jan Kara wrote:
> On Mon 10-09-18 17:58:10, Elliott, Robert (Persistent Memory) wrote:
> > 
> > 
> > > -----Original Message-----
> > > From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf Of Kani, Toshi
> > > Sent: Monday, September 10, 2018 9:52 AM
> > > To: jack@suse.cz
> > > Cc: linux-fsdevel@vger.kernel.org; linux-nvdimm@lists.01.org
> > > Subject: Re: open sets ext4_da_aops for DAX existing files
> > 
> > ...
> > > > Good catch. Will you send a fix? I.e., call ext4_set_inode_flags() earlier
> > > > in the ext4_iget()? Did this bug have any user visible manifestations?
> > > 
> > > Yes, sync did not flush processor cache.
> > > 
> > > > Please also add:
> > > > 
> > > > Fixes: 5f0663bb4a64f588f0a2dd6d1be68d40f9af0086
> > > > 
> > > > so that stable automation picks this up. Thanks!
> > > > 
> > > 
> > > Will do.
> > > 
> > 
> > Also check if the same problem exists with ext2.
> 
> The problem also exists in ext2 so that needs fixing as well.

Right.  Once my ext4 patch 2/2 is reviewed, I will duplicate it for
ext2.

Thanks,
-Toshi

      reply	other threads:[~2018-09-11 21:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07 21:23 Kani, Toshi
2018-09-10 12:54 ` Jeff Moyer
2018-09-10 14:21   ` Kani, Toshi
2018-09-10 14:26     ` Dan Williams
2018-09-10 14:29 ` Jan Kara
2018-09-10 14:51   ` Kani, Toshi
2018-09-10 17:58     ` Elliott, Robert (Persistent Memory)
2018-09-11 15:27       ` Jan Kara
2018-09-11 16:34         ` Kani, Toshi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d94d09e2539991db4853042b57bcf6274460f49.camel@hpe.com \
    --to=toshi.kani@hpe.com \
    --cc=elliott@hpe.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --subject='Re: open sets ext4_da_aops for DAX existing files' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).