linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: "Kani, Toshi" <toshi.kani@hpe.com>
Cc: "jmoyer@redhat.com" <jmoyer@redhat.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: open sets ext4_da_aops for DAX existing files
Date: Mon, 10 Sep 2018 07:26:55 -0700	[thread overview]
Message-ID: <CAPcyv4jr9353bgUjzKaVsu4ZqFkwkwEKMpETLSqeyJQgYcg_tQ@mail.gmail.com> (raw)
In-Reply-To: <bd07c88ae9626ea1a66fb100113296d9d4033988.camel@hpe.com>

On Mon, Sep 10, 2018 at 7:21 AM, Kani, Toshi <toshi.kani@hpe.com> wrote:
> On Mon, 2018-09-10 at 08:54 -0400, Jeff Moyer wrote:
>> "Kani, Toshi" <toshi.kani@hpe.com> writes:
>>
>> > I noticed that both ext4_da_aops and ext4_dax_aops are used on DAX
>> > mounted ext4 files.  Looking at open() path:
>>
>> Eek.  How did you notice this?
>
> I tested sync path on DAX files to see if it flushes processor cache
> properly. Then I noticed that it sometimes does, but sometimes doesn't.
> Looking into function traces, I realized that ext4_dax_writepages() and
> ext4_writepages() are called depending on their file status.

Yikes, and nice find!

  reply	other threads:[~2018-09-10 19:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07 21:23 Kani, Toshi
2018-09-10 12:54 ` Jeff Moyer
2018-09-10 14:21   ` Kani, Toshi
2018-09-10 14:26     ` Dan Williams [this message]
2018-09-10 14:29 ` Jan Kara
2018-09-10 14:51   ` Kani, Toshi
2018-09-10 17:58     ` Elliott, Robert (Persistent Memory)
2018-09-11 15:27       ` Jan Kara
2018-09-11 16:34         ` Kani, Toshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPcyv4jr9353bgUjzKaVsu4ZqFkwkwEKMpETLSqeyJQgYcg_tQ@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=toshi.kani@hpe.com \
    --subject='Re: open sets ext4_da_aops for DAX existing files' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).