linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [GIT PULL] Fsnotify cleanups
Date: Thu, 7 Jun 2018 09:34:53 -0700	[thread overview]
Message-ID: <CA+55aFwTNYAfN1RZOZ0CQ39fJTH2La_6BVqmo6VuUg_vzMhzOw@mail.gmail.com> (raw)
In-Reply-To: <20180607150217.jq757ncqopuimbkd@quack2.suse.cz>

On Thu, Jun 7, 2018 at 8:02 AM Jan Kara <jack@suse.cz> wrote:
>
> several fsnotify cleanups unifying handling of different watch
> types.

Grr.

Why is this growing things like "fsnotify_obj_inode()" helpers in <linux/fs.h>?

It has nothing to do with generic fs code. The only things that can
possibly use that already have to include fsnotify-specific headers,
where things like this belong.

It also adds a "struct fsnotify_obj i_fsnotify" to the struct inode,
and marks it "packed", so now architectures that have issues with
alignment might have issues depending on random changes to 'struct
inode'.

Plus it (again) causes more disturbance to a core header file that
fsnotify shouldn't touch. We had a forward declaration and a pointer.

So no. I'm not pulling this. I don't think it's a "cleanup". Maybe it
cleans up the fsnotify code, but it uglifies code that is much more
important.

                Linus

  reply	other threads:[~2018-06-07 16:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07 15:02 [GIT PULL] Fsnotify cleanups Jan Kara
2018-06-07 16:34 ` Linus Torvalds [this message]
2018-06-08 13:27   ` Jan Kara
2018-06-08 20:34     ` Linus Torvalds
2018-06-09  6:57       ` Amir Goldstein
2018-06-09  8:00         ` Amir Goldstein
2018-06-11 16:12           ` Jan Kara
2018-06-11 16:31             ` Amir Goldstein
2018-06-09 17:30         ` Linus Torvalds
2018-06-09 18:46           ` Amir Goldstein
2018-06-10 17:49             ` Amir Goldstein
2018-06-11 13:36               ` Jan Kara
2018-06-11 13:58                 ` Amir Goldstein
2018-06-11 16:03                   ` Jan Kara
2018-06-11 16:38                     ` Amir Goldstein
2018-06-11 19:51                       ` Amir Goldstein
2018-06-13 13:21                         ` Jan Kara
2018-06-13 13:56                           ` Amir Goldstein
2018-06-13 22:17                             ` Amir Goldstein
2018-06-22 16:44                               ` Jan Kara
2018-06-23  7:42                                 ` Amir Goldstein
2018-06-11 11:08       ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+55aFwTNYAfN1RZOZ0CQ39fJTH2La_6BVqmo6VuUg_vzMhzOw@mail.gmail.com \
    --to=torvalds@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).