From: Amir Goldstein <amir73il@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [GIT PULL] Fsnotify cleanups
Date: Thu, 14 Jun 2018 01:17:38 +0300 [thread overview]
Message-ID: <CAOQ4uxjq1Acp4NYLQbq7JMkODkdee-qE-XJh92Yrd78Bdp3PMg@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxjA8+uXiCR7CxphYewcO69g=Ym1EQmU2HY3X2ZQHEwSJg@mail.gmail.com>
On Wed, Jun 13, 2018 at 4:56 PM, Amir Goldstein <amir73il@gmail.com> wrote:
> On Wed, Jun 13, 2018 at 4:21 PM, Jan Kara <jack@suse.cz> wrote:
>> Going through patches:
>>
>> Regarding "fsnotify: use abstract fsnotify_obj_t * instead of **connp
>> argument" - I agree "struct fsnotify_mark_connector __rcu *" is quite
>> verbose but given how things evolved I don't think "fsnotify_obj_t" is a
>> great name. How about "fsnotify_connp_t" and keep parameter names as
>> "connp" instead of renaming them to "obj"? Because abstraction (like
>> pretending this is some kind of object when it is actually just a pointer)
>> that does not actually abstract anything is just obfuscation... So let's be
>> direct and admit this is just a shortcut name for connector pointer.
>>
>
> I though you'd say that and I agree.
> will rework after pull request.
Two places I couldn't resist keeping 'obj':
1. connector->obj
2. fsnotify_obj_{inode,mount}
The first one because conn->connp is horrible.
The second one because most call sites pass conn->obj as argument.
Force pushed result to fsnotify-cleanup.
See if you find it acceptable.
Thanks,
Amir.
next prev parent reply other threads:[~2018-06-13 22:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 15:02 [GIT PULL] Fsnotify cleanups Jan Kara
2018-06-07 16:34 ` Linus Torvalds
2018-06-08 13:27 ` Jan Kara
2018-06-08 20:34 ` Linus Torvalds
2018-06-09 6:57 ` Amir Goldstein
2018-06-09 8:00 ` Amir Goldstein
2018-06-11 16:12 ` Jan Kara
2018-06-11 16:31 ` Amir Goldstein
2018-06-09 17:30 ` Linus Torvalds
2018-06-09 18:46 ` Amir Goldstein
2018-06-10 17:49 ` Amir Goldstein
2018-06-11 13:36 ` Jan Kara
2018-06-11 13:58 ` Amir Goldstein
2018-06-11 16:03 ` Jan Kara
2018-06-11 16:38 ` Amir Goldstein
2018-06-11 19:51 ` Amir Goldstein
2018-06-13 13:21 ` Jan Kara
2018-06-13 13:56 ` Amir Goldstein
2018-06-13 22:17 ` Amir Goldstein [this message]
2018-06-22 16:44 ` Jan Kara
2018-06-23 7:42 ` Amir Goldstein
2018-06-11 11:08 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxjq1Acp4NYLQbq7JMkODkdee-qE-XJh92Yrd78Bdp3PMg@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).