From: Rokudo Yan <wu-yan@tcl.com>
To: Alessio Balsini <balsini@android.com>,
Miklos Szeredi <miklos@szeredi.hu>
Cc: Akilesh Kailash <akailash@google.com>,
Amir Goldstein <amir73il@gmail.com>,
Antonio SJ Musumeci <trapexit@spawn.link>,
"David Anderson" <dvander@google.com>,
Giuseppe Scrivano <gscrivan@redhat.com>,
"Jann Horn" <jannh@google.com>, Jens Axboe <axboe@kernel.dk>,
Martijn Coenen <maco@android.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Lawrence <paullawrence@google.com>,
Peng Tao <bergwolf@gmail.com>,
Stefano Duo <duostefano93@gmail.com>,
Zimuzo Ezeozue <zezeozue@google.com>,
<fuse-devel@lists.sourceforge.net>, <kernel-team@android.com>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND V12 1/8] fs: Generic function to convert iocb to rw flags
Date: Wed, 24 Mar 2021 15:43:12 +0800 [thread overview]
Message-ID: <d136923d-dd50-3cb4-7771-b3c0dceabd24@tcl.com> (raw)
In-Reply-To: <YA71ydLBbKmZg5/O@google.com>
On 1/26/21 12:46 AM, Alessio Balsini wrote:
> On Mon, Jan 25, 2021 at 03:30:50PM +0000, Alessio Balsini wrote:
>> OverlayFS implements its own function to translate iocb flags into rw
>> flags, so that they can be passed into another vfs call.
>> With commit ce71bfea207b4 ("fs: align IOCB_* flags with RWF_* flags")
>> Jens created a 1:1 matching between the iocb flags and rw flags,
>> simplifying the conversion.
>>
>> Reduce the OverlayFS code by making the flag conversion function generic
>> and reusable.
>>
>> Signed-off-by: Alessio Balsini <balsini@android.com>
>> ---
>> fs/overlayfs/file.c | 23 +++++------------------
>> include/linux/fs.h | 5 +++++
>> 2 files changed, 10 insertions(+), 18 deletions(-)
>>
>> diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
>> index bd9dd38347ae..56be2ffc5a14 100644
>> --- a/fs/overlayfs/file.c
>> +++ b/fs/overlayfs/file.c
>> @@ -15,6 +15,8 @@
>> #include <linux/fs.h>
>> #include "overlayfs.h"
>>
>> +#define OVL_IOCB_MASK (IOCB_DSYNC | IOCB_HIPRI | IOCB_NOWAIT | IOCB_SYNC)
>> +
>> struct ovl_aio_req {
>> struct kiocb iocb;
>> struct kiocb *orig_iocb;
>> @@ -236,22 +238,6 @@ static void ovl_file_accessed(struct file *file)
>> touch_atime(&file->f_path);
>> }
>>
>> -static rwf_t ovl_iocb_to_rwf(int ifl)
>> -{
>> - rwf_t flags = 0;
>> -
>> - if (ifl & IOCB_NOWAIT)
>> - flags |= RWF_NOWAIT;
>> - if (ifl & IOCB_HIPRI)
>> - flags |= RWF_HIPRI;
>> - if (ifl & IOCB_DSYNC)
>> - flags |= RWF_DSYNC;
>> - if (ifl & IOCB_SYNC)
>> - flags |= RWF_SYNC;
>> -
>> - return flags;
>> -}
>> -
>> static void ovl_aio_cleanup_handler(struct ovl_aio_req *aio_req)
>> {
>> struct kiocb *iocb = &aio_req->iocb;
>> @@ -299,7 +285,8 @@ static ssize_t ovl_read_iter(struct kiocb *iocb, struct iov_iter *iter)
>> old_cred = ovl_override_creds(file_inode(file)->i_sb);
>> if (is_sync_kiocb(iocb)) {
>> ret = vfs_iter_read(real.file, iter, &iocb->ki_pos,
>> - ovl_iocb_to_rwf(iocb->ki_flags));
>> + iocb_to_rw_flags(iocb->ki_flags,
>> + OVL_IOCB_MASK));
>> } else {
>> struct ovl_aio_req *aio_req;
>>
>> @@ -356,7 +343,7 @@ static ssize_t ovl_write_iter(struct kiocb *iocb, struct iov_iter *iter)
>> if (is_sync_kiocb(iocb)) {
>> file_start_write(real.file);
>> ret = vfs_iter_write(real.file, iter, &iocb->ki_pos,
>> - ovl_iocb_to_rwf(ifl));
>> + iocb_to_rw_flags(ifl, OVL_IOCB_MASK));
>> file_end_write(real.file);
>> /* Update size */
>> ovl_copyattr(ovl_inode_real(inode), inode);
>> diff --git a/include/linux/fs.h b/include/linux/fs.h
>> index fd47deea7c17..647c35423545 100644
>> --- a/include/linux/fs.h
>> +++ b/include/linux/fs.h
>> @@ -3275,6 +3275,11 @@ static inline int kiocb_set_rw_flags(struct kiocb *ki, rwf_t flags)
>> return 0;
>> }
>>
>> +static inline rwf_t iocb_to_rw_flags(int ifl, int iocb_mask)
>> +{
>> + return ifl & iocb_mask;
>> +}
>> +
>> static inline ino_t parent_ino(struct dentry *dentry)
>> {
>> ino_t res;
>> --
>> 2.30.0.280.ga3ce27912f-goog
>>
>
> For some reason lkml.org and lore.kernel.org are not showing this change
> as part of the thread.
> Let's see if replying to the email fixes the indexing.
>
> Regards,
> Alessio
>
Hi, Alessio
This change imply IOCB_* and RWF_* flags are properly aligned, which is
not true for kernel version 5.4/4.19/4.14. As the patch ("fs: align
IOCB_* flags with RWF_* flags") is not back-ported to these stable
kernel branches. The issue was found when applying these patches
to kernel-5.4(files open with passthrough enabled can't do append
write). I think the issue exists in AOSP common kernel too.
Could you please fix this?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce71bfea207b4d7c21d36f24ec37618ffcea1da8
https://android-review.googlesource.com/c/kernel/common/+/1556243
Thanks
yanwu
next prev parent reply other threads:[~2021-03-24 7:50 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 15:30 [PATCH RESEND V12 0/8] fuse: Add support for passthrough read/write Alessio Balsini
2021-01-25 15:30 ` [PATCH RESEND V12 1/8] fs: Generic function to convert iocb to rw flags Alessio Balsini
2021-01-25 16:46 ` Alessio Balsini
2021-03-24 7:43 ` Rokudo Yan [this message]
2021-03-24 14:02 ` Alessio Balsini
2021-01-25 15:30 ` [PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device Alessio Balsini
[not found] ` <CAMAHBGzkfEd9-1u0iKXp65ReJQgUi_=4sMpmfkwEOaMp6Ux7pg@mail.gmail.com>
2021-01-27 13:40 ` Alessio Balsini
[not found] ` <CAMAHBGwpKW+30kNQ_Apt8A-FTmr94hBOzkT21cjEHHW+t7yUMQ@mail.gmail.com>
2021-01-28 14:15 ` Alessio Balsini
2021-02-05 9:54 ` Peng Tao
2021-03-16 18:57 ` Arnd Bergmann
2021-02-17 10:21 ` Miklos Szeredi
2021-03-01 12:26 ` Alessio Balsini
2021-03-16 18:53 ` Arnd Bergmann
2021-03-18 16:13 ` Alessio Balsini
2021-03-18 21:15 ` Arnd Bergmann
2021-03-19 15:21 ` Alessio Balsini
2021-01-25 15:30 ` [PATCH RESEND V12 3/8] fuse: Definitions and ioctl for passthrough Alessio Balsini
2021-02-17 13:41 ` Miklos Szeredi
2021-02-19 7:05 ` Peng Tao
2021-02-19 8:40 ` Miklos Szeredi
2021-03-01 17:05 ` Alessio Balsini
2022-09-08 15:36 ` Amir Goldstein
2022-09-09 19:07 ` Miklos Szeredi
2022-09-10 8:52 ` Amir Goldstein
2022-09-10 13:03 ` Bernd Schubert
2022-09-12 9:29 ` Miklos Szeredi
2022-09-12 12:29 ` Amir Goldstein
2022-09-12 13:03 ` Miklos Szeredi
2022-09-12 13:05 ` Miklos Szeredi
2022-09-12 13:26 ` Amir Goldstein
2022-09-12 14:22 ` Miklos Szeredi
2022-09-12 15:39 ` Amir Goldstein
2022-09-12 17:43 ` Hao Luo
2022-09-12 18:28 ` Overlayfs with writable lower layer Amir Goldstein
2022-09-13 18:26 ` Hao Luo
2022-09-13 18:54 ` Amir Goldstein
2022-09-13 20:33 ` Hao Luo
2022-09-14 3:46 ` Amir Goldstein
2022-09-14 18:00 ` Hao Luo
2022-09-14 19:23 ` Amir Goldstein
2022-09-14 19:33 ` Hao Luo
2022-09-15 10:54 ` Amir Goldstein
2023-05-12 19:37 ` [PATCH RESEND V12 3/8] fuse: Definitions and ioctl for passthrough Amir Goldstein
2023-05-15 7:29 ` Miklos Szeredi
2023-05-15 14:00 ` Amir Goldstein
2023-05-15 20:16 ` [fuse-devel] " Nikolaus Rath
2023-05-15 21:11 ` Bernd Schubert
2023-05-15 21:45 ` Paul Lawrence
2023-05-16 8:43 ` Miklos Szeredi
2023-05-16 10:16 ` Nikolaus Rath
2023-05-16 8:48 ` Amir Goldstein
2021-01-25 15:30 ` [PATCH RESEND V12 4/8] fuse: Passthrough initialization and release Alessio Balsini
2021-02-17 13:52 ` Miklos Szeredi
2021-05-05 12:21 ` Amir Goldstein
2021-05-17 11:36 ` Alessio Balsini
2021-05-17 13:21 ` Amir Goldstein
2021-01-25 15:30 ` [PATCH RESEND V12 5/8] fuse: Introduce synchronous read and write for passthrough Alessio Balsini
2021-02-17 14:00 ` Miklos Szeredi
2021-01-25 15:30 ` [PATCH RESEND V12 6/8] fuse: Handle asynchronous read and write in passthrough Alessio Balsini
2021-01-25 15:30 ` [PATCH RESEND V12 7/8] fuse: Use daemon creds in passthrough mode Alessio Balsini
2021-02-05 9:23 ` Peng Tao
2021-02-05 11:21 ` Alessio Balsini
2021-01-25 15:30 ` [PATCH RESEND V12 8/8] fuse: Introduce passthrough for mmap Alessio Balsini
2021-02-17 14:05 ` Miklos Szeredi
2021-04-01 11:24 ` Alessio Balsini
2021-11-18 18:31 ` [PATCH RESEND V12 0/8] fuse: Add support for passthrough read/write Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d136923d-dd50-3cb4-7771-b3c0dceabd24@tcl.com \
--to=wu-yan@tcl.com \
--cc=akailash@google.com \
--cc=amir73il@gmail.com \
--cc=axboe@kernel.dk \
--cc=balsini@android.com \
--cc=bergwolf@gmail.com \
--cc=duostefano93@gmail.com \
--cc=dvander@google.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=gscrivan@redhat.com \
--cc=jannh@google.com \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=miklos@szeredi.hu \
--cc=palmer@dabbelt.com \
--cc=paullawrence@google.com \
--cc=trapexit@spawn.link \
--cc=zezeozue@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).