[PATCH] pinctrl: qcom: ipq8074: route gpio interrupts to APPS

[PATCH] pinctrl: qcom: ipq8074: route gpio interrupts to APPS

[Kathiravan T]

set target proc as APPS to route the gpio interrupts to APPS

Signed-off-by: Rajkumar Ayyasamy <arajkuma@codeaurora.org>
Signed-off-by: Kathiravan T <kathirav@codeaurora.org>
---
 drivers/pinctrl/qcom/pinctrl-ipq8074.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-ipq8074.c b/drivers/pinctrl/qcom/pinctrl-ipq8074.c
index 0edd41c..aec68b1 100644
--- a/drivers/pinctrl/qcom/pinctrl-ipq8074.c
+++ b/drivers/pinctrl/qcom/pinctrl-ipq8074.c
@@ -50,6 +50,7 @@
 		.intr_enable_bit = 0,		\
 		.intr_status_bit = 0,		\
 		.intr_target_bit = 5,		\
+		.intr_target_kpss_val = 3,	\
 		.intr_raw_status_bit = 4,	\
 		.intr_polarity_bit = 1,		\
 		.intr_detection_bit = 2,	\
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

Re: [PATCH] pinctrl: qcom: ipq8074: route gpio interrupts to APPS

[Bjorn Andersson]

On Mon 06 Jul 21:58 PDT 2020, Kathiravan T wrote:

> set target proc as APPS to route the gpio interrupts to APPS
> 
> Signed-off-by: Rajkumar Ayyasamy <arajkuma@codeaurora.org>
> Signed-off-by: Kathiravan T <kathirav@codeaurora.org>

This says "first Rajkumar certified the patch's origin, then you picked
it up and certified its origin". As such I would expect that Rajkumar is
the author of the patch.

If you both came up with the patch add a Co-developed-by: tag.

Regards,
Bjorn

> ---
>  drivers/pinctrl/qcom/pinctrl-ipq8074.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq8074.c b/drivers/pinctrl/qcom/pinctrl-ipq8074.c
> index 0edd41c..aec68b1 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ipq8074.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ipq8074.c
> @@ -50,6 +50,7 @@
>  		.intr_enable_bit = 0,		\
>  		.intr_status_bit = 0,		\
>  		.intr_target_bit = 5,		\
> +		.intr_target_kpss_val = 3,	\
>  		.intr_raw_status_bit = 4,	\
>  		.intr_polarity_bit = 1,		\
>  		.intr_detection_bit = 2,	\
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
> 

Re: [PATCH] pinctrl: qcom: ipq8074: route gpio interrupts to APPS

[Kathiravan T]

Hi Bjorn,

On 7/7/2020 10:44 AM, Bjorn Andersson wrote:
> On Mon 06 Jul 21:58 PDT 2020, Kathiravan T wrote:
>
>> set target proc as APPS to route the gpio interrupts to APPS
>>
>> Signed-off-by: Rajkumar Ayyasamy <arajkuma@codeaurora.org>
>> Signed-off-by: Kathiravan T <kathirav@codeaurora.org>
> This says "first Rajkumar certified the patch's origin, then you picked
> it up and certified its origin". As such I would expect that Rajkumar is
> the author of the patch.
>
> If you both came up with the patch add a Co-developed-by: tag.
>
> Regards,
> Bjorn
Thanks, fixed in V2.
>> ---
>>   drivers/pinctrl/qcom/pinctrl-ipq8074.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq8074.c b/drivers/pinctrl/qcom/pinctrl-ipq8074.c
>> index 0edd41c..aec68b1 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-ipq8074.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-ipq8074.c
>> @@ -50,6 +50,7 @@
>>   		.intr_enable_bit = 0,		\
>>   		.intr_status_bit = 0,		\
>>   		.intr_target_bit = 5,		\
>> +		.intr_target_kpss_val = 3,	\
>>   		.intr_raw_status_bit = 4,	\
>>   		.intr_polarity_bit = 1,		\
>>   		.intr_detection_bit = 2,	\
>> -- 
>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
>>
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation