* [PATCH v2 0/2] Remove MT6779 UART3 clock support
@ 2020-07-22 3:09 Hanks Chen
2020-07-22 3:09 ` [PATCH v2 1/2] dt-bindings: clock: remove " Hanks Chen
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Hanks Chen @ 2020-07-22 3:09 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Matthias Brugger, Rob Herring
Cc: YueHaibing, mtk01761, CC Hwang, linux-gpio, linux-arm-kernel,
linux-mediatek, linux-kernel, wsd_upstream, Hanks Chen
remove the redundant clk interface of uart.
CLK_INFRA_UART3 is a dummy clk interface,
it has no effect on the operation of the read/write instruction.
Change since v2:
Commit "dt-bindings: clock: remove UART3 clock support"
-- remove Fixes tag
Commit "clk: mediatek: remove UART3 clock support"
-- remove Fixes tag
Hanks Chen (2):
dt-bindings: clock: remove UART3 clock support
clk: mediatek: remove UART3 clock support
drivers/clk/mediatek/clk-mt6779.c | 2 --
include/dt-bindings/clock/mt6779-clk.h | 1 -
2 files changed, 3 deletions(-)
--
2.18.0
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v2 1/2] dt-bindings: clock: remove UART3 clock support 2020-07-22 3:09 [PATCH v2 0/2] Remove MT6779 UART3 clock support Hanks Chen @ 2020-07-22 3:09 ` Hanks Chen 2020-07-22 15:22 ` Matthias Brugger 2020-07-22 3:09 ` [PATCH v2 2/2] clk: mediatek: " Hanks Chen 2020-07-22 8:43 ` [PATCH v2 0/2] Remove MT6779 " Matthias Brugger 2 siblings, 1 reply; 11+ messages in thread From: Hanks Chen @ 2020-07-22 3:09 UTC (permalink / raw) To: Michael Turquette, Stephen Boyd, Matthias Brugger, Rob Herring Cc: YueHaibing, mtk01761, CC Hwang, linux-gpio, linux-arm-kernel, linux-mediatek, linux-kernel, wsd_upstream, Hanks Chen remove the redundant clk interface of uart. Signed-off-by: Hanks Chen <hanks.chen@mediatek.com> --- include/dt-bindings/clock/mt6779-clk.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/dt-bindings/clock/mt6779-clk.h b/include/dt-bindings/clock/mt6779-clk.h index b083139afbd2..2b5f2354d7eb 100644 --- a/include/dt-bindings/clock/mt6779-clk.h +++ b/include/dt-bindings/clock/mt6779-clk.h @@ -229,7 +229,6 @@ #define CLK_INFRA_UART0 21 #define CLK_INFRA_UART1 22 #define CLK_INFRA_UART2 23 -#define CLK_INFRA_UART3 24 #define CLK_INFRA_GCE_26M 25 #define CLK_INFRA_CQ_DMA_FPC 26 #define CLK_INFRA_BTIF 27 -- 2.18.0 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: clock: remove UART3 clock support 2020-07-22 3:09 ` [PATCH v2 1/2] dt-bindings: clock: remove " Hanks Chen @ 2020-07-22 15:22 ` Matthias Brugger 0 siblings, 0 replies; 11+ messages in thread From: Matthias Brugger @ 2020-07-22 15:22 UTC (permalink / raw) To: Hanks Chen, Michael Turquette, Stephen Boyd, Rob Herring Cc: YueHaibing, mtk01761, CC Hwang, linux-gpio, linux-arm-kernel, linux-mediatek, linux-kernel, wsd_upstream On 22/07/2020 05:09, Hanks Chen wrote: > remove the redundant clk interface of uart. > > Signed-off-by: Hanks Chen <hanks.chen@mediatek.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > include/dt-bindings/clock/mt6779-clk.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/dt-bindings/clock/mt6779-clk.h b/include/dt-bindings/clock/mt6779-clk.h > index b083139afbd2..2b5f2354d7eb 100644 > --- a/include/dt-bindings/clock/mt6779-clk.h > +++ b/include/dt-bindings/clock/mt6779-clk.h > @@ -229,7 +229,6 @@ > #define CLK_INFRA_UART0 21 > #define CLK_INFRA_UART1 22 > #define CLK_INFRA_UART2 23 > -#define CLK_INFRA_UART3 24 > #define CLK_INFRA_GCE_26M 25 > #define CLK_INFRA_CQ_DMA_FPC 26 > #define CLK_INFRA_BTIF 27 > ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 2/2] clk: mediatek: remove UART3 clock support 2020-07-22 3:09 [PATCH v2 0/2] Remove MT6779 UART3 clock support Hanks Chen 2020-07-22 3:09 ` [PATCH v2 1/2] dt-bindings: clock: remove " Hanks Chen @ 2020-07-22 3:09 ` Hanks Chen 2020-07-22 15:22 ` Matthias Brugger 2020-07-22 8:43 ` [PATCH v2 0/2] Remove MT6779 " Matthias Brugger 2 siblings, 1 reply; 11+ messages in thread From: Hanks Chen @ 2020-07-22 3:09 UTC (permalink / raw) To: Michael Turquette, Stephen Boyd, Matthias Brugger, Rob Herring Cc: YueHaibing, mtk01761, CC Hwang, linux-gpio, linux-arm-kernel, linux-mediatek, linux-kernel, wsd_upstream, Hanks Chen CLK_INFRA_UART3 is a dummy clk interface, it has no effect on the operation of the read/write instruction. Signed-off-by: Hanks Chen <hanks.chen@mediatek.com> --- drivers/clk/mediatek/clk-mt6779.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt6779.c b/drivers/clk/mediatek/clk-mt6779.c index 9766cccf5844..75f2235486be 100644 --- a/drivers/clk/mediatek/clk-mt6779.c +++ b/drivers/clk/mediatek/clk-mt6779.c @@ -923,8 +923,6 @@ static const struct mtk_gate infra_clks[] = { "uart_sel", 23), GATE_INFRA0(CLK_INFRA_UART2, "infra_uart2", "uart_sel", 24), - GATE_INFRA0(CLK_INFRA_UART3, "infra_uart3", - "uart_sel", 25), GATE_INFRA0(CLK_INFRA_GCE_26M, "infra_gce_26m", "axi_sel", 27), GATE_INFRA0(CLK_INFRA_CQ_DMA_FPC, "infra_cqdma_fpc", -- 2.18.0 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/2] clk: mediatek: remove UART3 clock support 2020-07-22 3:09 ` [PATCH v2 2/2] clk: mediatek: " Hanks Chen @ 2020-07-22 15:22 ` Matthias Brugger 0 siblings, 0 replies; 11+ messages in thread From: Matthias Brugger @ 2020-07-22 15:22 UTC (permalink / raw) To: Hanks Chen, Michael Turquette, Stephen Boyd, Rob Herring Cc: YueHaibing, mtk01761, CC Hwang, linux-gpio, linux-arm-kernel, linux-mediatek, linux-kernel, wsd_upstream On 22/07/2020 05:09, Hanks Chen wrote: > CLK_INFRA_UART3 is a dummy clk interface, > it has no effect on the operation of the read/write instruction. > > Signed-off-by: Hanks Chen <hanks.chen@mediatek.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > drivers/clk/mediatek/clk-mt6779.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/clk/mediatek/clk-mt6779.c b/drivers/clk/mediatek/clk-mt6779.c > index 9766cccf5844..75f2235486be 100644 > --- a/drivers/clk/mediatek/clk-mt6779.c > +++ b/drivers/clk/mediatek/clk-mt6779.c > @@ -923,8 +923,6 @@ static const struct mtk_gate infra_clks[] = { > "uart_sel", 23), > GATE_INFRA0(CLK_INFRA_UART2, "infra_uart2", > "uart_sel", 24), > - GATE_INFRA0(CLK_INFRA_UART3, "infra_uart3", > - "uart_sel", 25), > GATE_INFRA0(CLK_INFRA_GCE_26M, "infra_gce_26m", > "axi_sel", 27), > GATE_INFRA0(CLK_INFRA_CQ_DMA_FPC, "infra_cqdma_fpc", > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 0/2] Remove MT6779 UART3 clock support 2020-07-22 3:09 [PATCH v2 0/2] Remove MT6779 UART3 clock support Hanks Chen 2020-07-22 3:09 ` [PATCH v2 1/2] dt-bindings: clock: remove " Hanks Chen 2020-07-22 3:09 ` [PATCH v2 2/2] clk: mediatek: " Hanks Chen @ 2020-07-22 8:43 ` Matthias Brugger 2020-07-22 11:16 ` Hanks Chen 2 siblings, 1 reply; 11+ messages in thread From: Matthias Brugger @ 2020-07-22 8:43 UTC (permalink / raw) To: Hanks Chen, Michael Turquette, Stephen Boyd, Rob Herring Cc: YueHaibing, mtk01761, CC Hwang, linux-gpio, linux-arm-kernel, linux-mediatek, linux-kernel, wsd_upstream On 22/07/2020 05:09, Hanks Chen wrote: > remove the redundant clk interface of uart. > CLK_INFRA_UART3 is a dummy clk interface, > it has no effect on the operation of the read/write instruction. > > Change since v2: > Commit "dt-bindings: clock: remove UART3 clock support" Sorry just another comment. I think we can make this one patch deleting everything. > -- remove Fixes tag > Commit "clk: mediatek: remove UART3 clock support" > -- remove Fixes tag > > Hanks Chen (2): > dt-bindings: clock: remove UART3 clock support > clk: mediatek: remove UART3 clock support > > drivers/clk/mediatek/clk-mt6779.c | 2 -- > include/dt-bindings/clock/mt6779-clk.h | 1 - > 2 files changed, 3 deletions(-) > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 0/2] Remove MT6779 UART3 clock support 2020-07-22 8:43 ` [PATCH v2 0/2] Remove MT6779 " Matthias Brugger @ 2020-07-22 11:16 ` Hanks Chen 2020-07-22 15:21 ` Matthias Brugger 0 siblings, 1 reply; 11+ messages in thread From: Hanks Chen @ 2020-07-22 11:16 UTC (permalink / raw) To: Matthias Brugger Cc: Michael Turquette, Stephen Boyd, Rob Herring, YueHaibing, mtk01761, CC Hwang, linux-gpio, linux-arm-kernel, linux-mediatek, linux-kernel, wsd_upstream On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote: > > On 22/07/2020 05:09, Hanks Chen wrote: > > remove the redundant clk interface of uart. > > CLK_INFRA_UART3 is a dummy clk interface, > > it has no effect on the operation of the read/write instruction. > > > > Change since v2: > > Commit "dt-bindings: clock: remove UART3 clock support" > > Sorry just another comment. I think we can make this one patch deleting everything. > Sorry, I don't understand the comment. Do I need to merge them into one big patch? Btw, if I use one patch, I would get check patch fail. --- [2020-07-22 19:12:49,046 ERROR] Run check patch results: WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst --- Hanks > > -- remove Fixes tag > > Commit "clk: mediatek: remove UART3 clock support" > > -- remove Fixes tag > > > > Hanks Chen (2): > > dt-bindings: clock: remove UART3 clock support > > clk: mediatek: remove UART3 clock support > > > > drivers/clk/mediatek/clk-mt6779.c | 2 -- > > include/dt-bindings/clock/mt6779-clk.h | 1 - > > 2 files changed, 3 deletions(-) > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 0/2] Remove MT6779 UART3 clock support 2020-07-22 11:16 ` Hanks Chen @ 2020-07-22 15:21 ` Matthias Brugger 2020-07-30 13:04 ` Hanks Chen 0 siblings, 1 reply; 11+ messages in thread From: Matthias Brugger @ 2020-07-22 15:21 UTC (permalink / raw) To: Hanks Chen Cc: Michael Turquette, Stephen Boyd, Rob Herring, YueHaibing, mtk01761, CC Hwang, linux-gpio, linux-arm-kernel, linux-mediatek, linux-kernel, wsd_upstream On 22/07/2020 13:16, Hanks Chen wrote: > On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote: >> >> On 22/07/2020 05:09, Hanks Chen wrote: >>> remove the redundant clk interface of uart. >>> CLK_INFRA_UART3 is a dummy clk interface, >>> it has no effect on the operation of the read/write instruction. >>> >>> Change since v2: >>> Commit "dt-bindings: clock: remove UART3 clock support" >> >> Sorry just another comment. I think we can make this one patch deleting everything. >> > Sorry, I don't understand the comment. Do I need to merge them into one > big patch? > Btw, if I use one patch, I would get check patch fail. > --- > [2020-07-22 19:12:49,046 ERROR] Run check patch results: > WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a > separate patch. See: > Documentation/devicetree/bindings/submitting-patches.rst > --- Hm, I think that's a debatable error message from checkpatch, but let's leave it as it is. Regards, Matthias > > Hanks > >>> -- remove Fixes tag >>> Commit "clk: mediatek: remove UART3 clock support" >>> -- remove Fixes tag >>> >>> Hanks Chen (2): >>> dt-bindings: clock: remove UART3 clock support >>> clk: mediatek: remove UART3 clock support >>> >>> drivers/clk/mediatek/clk-mt6779.c | 2 -- >>> include/dt-bindings/clock/mt6779-clk.h | 1 - >>> 2 files changed, 3 deletions(-) >>> > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 0/2] Remove MT6779 UART3 clock support 2020-07-22 15:21 ` Matthias Brugger @ 2020-07-30 13:04 ` Hanks Chen 2020-09-08 6:31 ` Hanks Chen 0 siblings, 1 reply; 11+ messages in thread From: Hanks Chen @ 2020-07-30 13:04 UTC (permalink / raw) To: Matthias Brugger, Michael Turquette, Stephen Boyd, Rob Herring Cc: Michael Turquette, Stephen Boyd, Rob Herring, YueHaibing, mtk01761, CC Hwang, linux-gpio, linux-arm-kernel, linux-mediatek, linux-kernel, wsd_upstream Hi all, Gentle ping on this patch. Thanks! Hanks Chen On Wed, 2020-07-22 at 17:21 +0200, Matthias Brugger wrote: > > On 22/07/2020 13:16, Hanks Chen wrote: > > On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote: > >> > >> On 22/07/2020 05:09, Hanks Chen wrote: > >>> remove the redundant clk interface of uart. > >>> CLK_INFRA_UART3 is a dummy clk interface, > >>> it has no effect on the operation of the read/write instruction. > >>> > >>> Change since v2: > >>> Commit "dt-bindings: clock: remove UART3 clock support" > >> > >> Sorry just another comment. I think we can make this one patch deleting everything. > >> > > Sorry, I don't understand the comment. Do I need to merge them into one > > big patch? > > Btw, if I use one patch, I would get check patch fail. > > --- > > [2020-07-22 19:12:49,046 ERROR] Run check patch results: > > WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a > > separate patch. See: > > Documentation/devicetree/bindings/submitting-patches.rst > > --- > > Hm, I think that's a debatable error message from checkpatch, but let's leave it > as it is. > > Regards, > Matthias > > > > > > Hanks > > > >>> -- remove Fixes tag > >>> Commit "clk: mediatek: remove UART3 clock support" > >>> -- remove Fixes tag > >>> > >>> Hanks Chen (2): > >>> dt-bindings: clock: remove UART3 clock support > >>> clk: mediatek: remove UART3 clock support > >>> > >>> drivers/clk/mediatek/clk-mt6779.c | 2 -- > >>> include/dt-bindings/clock/mt6779-clk.h | 1 - > >>> 2 files changed, 3 deletions(-) > >>> > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Re: [PATCH v2 0/2] Remove MT6779 UART3 clock support 2020-07-30 13:04 ` Hanks Chen @ 2020-09-08 6:31 ` Hanks Chen 2020-09-25 12:43 ` Hanks Chen 0 siblings, 1 reply; 11+ messages in thread From: Hanks Chen @ 2020-09-08 6:31 UTC (permalink / raw) To: Matthias Brugger, Rob Herring, Stephen Boyd, Michael Turquette Cc: CC Hwang, wsd_upstream, YueHaibing, linux-kernel, linux-gpio, linux-mediatek, mtk01761, linux-arm-kernel Hi all, Gentle ping on this patch set. Thanks! Hanks Chen On Thu, 2020-07-30 at 21:04 +0800, Hanks Chen wrote: > Hi all, > > Gentle ping on this patch. > > Thanks! > > Hanks Chen > > > On Wed, 2020-07-22 at 17:21 +0200, Matthias Brugger wrote: > > > > On 22/07/2020 13:16, Hanks Chen wrote: > > > On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote: > > >> > > >> On 22/07/2020 05:09, Hanks Chen wrote: > > >>> remove the redundant clk interface of uart. > > >>> CLK_INFRA_UART3 is a dummy clk interface, > > >>> it has no effect on the operation of the read/write instruction. > > >>> > > >>> Change since v2: > > >>> Commit "dt-bindings: clock: remove UART3 clock support" > > >> > > >> Sorry just another comment. I think we can make this one patch deleting everything. > > >> > > > Sorry, I don't understand the comment. Do I need to merge them into one > > > big patch? > > > Btw, if I use one patch, I would get check patch fail. > > > --- > > > [2020-07-22 19:12:49,046 ERROR] Run check patch results: > > > WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a > > > separate patch. See: > > > Documentation/devicetree/bindings/submitting-patches.rst > > > --- > > > > Hm, I think that's a debatable error message from checkpatch, but let's leave it > > as it is. > > > > Regards, > > Matthias > > > > > > > > > > Hanks > > > > > >>> -- remove Fixes tag > > >>> Commit "clk: mediatek: remove UART3 clock support" > > >>> -- remove Fixes tag > > >>> > > >>> Hanks Chen (2): > > >>> dt-bindings: clock: remove UART3 clock support > > >>> clk: mediatek: remove UART3 clock support > > >>> > > >>> drivers/clk/mediatek/clk-mt6779.c | 2 -- > > >>> include/dt-bindings/clock/mt6779-clk.h | 1 - > > >>> 2 files changed, 3 deletions(-) > > >>> > > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Re: [PATCH v2 0/2] Remove MT6779 UART3 clock support 2020-09-08 6:31 ` Hanks Chen @ 2020-09-25 12:43 ` Hanks Chen 0 siblings, 0 replies; 11+ messages in thread From: Hanks Chen @ 2020-09-25 12:43 UTC (permalink / raw) To: Michael Turquette, Stephen Boyd, Matthias Brugger Cc: Rob Herring, CC Hwang, wsd_upstream, YueHaibing, linux-kernel, linux-gpio, linux-mediatek, mtk01761, linux-arm-kernel Hi Michael & Stephen, Gentle ping on this clk patch. Thanks. Regards, Hanks On Tue, 2020-09-08 at 14:31 +0800, Hanks Chen wrote: > Hi all, > > Gentle ping on this patch set. > > Thanks! > > > Hanks Chen > > > On Thu, 2020-07-30 at 21:04 +0800, Hanks Chen wrote: > > Hi all, > > > > Gentle ping on this patch. > > > > Thanks! > > > > Hanks Chen > > > > > > On Wed, 2020-07-22 at 17:21 +0200, Matthias Brugger wrote: > > > > > > On 22/07/2020 13:16, Hanks Chen wrote: > > > > On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote: > > > >> > > > >> On 22/07/2020 05:09, Hanks Chen wrote: > > > >>> remove the redundant clk interface of uart. > > > >>> CLK_INFRA_UART3 is a dummy clk interface, > > > >>> it has no effect on the operation of the read/write instruction. > > > >>> > > > >>> Change since v2: > > > >>> Commit "dt-bindings: clock: remove UART3 clock support" > > > >> > > > >> Sorry just another comment. I think we can make this one patch deleting everything. > > > >> > > > > Sorry, I don't understand the comment. Do I need to merge them into one > > > > big patch? > > > > Btw, if I use one patch, I would get check patch fail. > > > > --- > > > > [2020-07-22 19:12:49,046 ERROR] Run check patch results: > > > > WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a > > > > separate patch. See: > > > > Documentation/devicetree/bindings/submitting-patches.rst > > > > --- > > > > > > Hm, I think that's a debatable error message from checkpatch, but let's leave it > > > as it is. > > > > > > Regards, > > > Matthias > > > > > > > > > > > > > > Hanks > > > > > > > >>> -- remove Fixes tag > > > >>> Commit "clk: mediatek: remove UART3 clock support" > > > >>> -- remove Fixes tag > > > >>> > > > >>> Hanks Chen (2): > > > >>> dt-bindings: clock: remove UART3 clock support > > > >>> clk: mediatek: remove UART3 clock support > > > >>> > > > >>> drivers/clk/mediatek/clk-mt6779.c | 2 -- > > > >>> include/dt-bindings/clock/mt6779-clk.h | 1 - > > > >>> 2 files changed, 3 deletions(-) > > > >>> > > > > > > > > _______________________________________________ > > Linux-mediatek mailing list > > Linux-mediatek@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-mediatek > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-09-25 12:43 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-07-22 3:09 [PATCH v2 0/2] Remove MT6779 UART3 clock support Hanks Chen 2020-07-22 3:09 ` [PATCH v2 1/2] dt-bindings: clock: remove " Hanks Chen 2020-07-22 15:22 ` Matthias Brugger 2020-07-22 3:09 ` [PATCH v2 2/2] clk: mediatek: " Hanks Chen 2020-07-22 15:22 ` Matthias Brugger 2020-07-22 8:43 ` [PATCH v2 0/2] Remove MT6779 " Matthias Brugger 2020-07-22 11:16 ` Hanks Chen 2020-07-22 15:21 ` Matthias Brugger 2020-07-30 13:04 ` Hanks Chen 2020-09-08 6:31 ` Hanks Chen 2020-09-25 12:43 ` Hanks Chen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).