From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/8] pinctrl: lynxpoint: Move GPIO driver to pin controller folder
Date: Thu, 7 Nov 2019 16:47:52 +0200 [thread overview]
Message-ID: <20191107144752.GY32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191107134842.GM2552@lahna.fi.intel.com>
On Thu, Nov 07, 2019 at 03:48:42PM +0200, Mika Westerberg wrote:
> On Wed, Nov 06, 2019 at 04:48:22PM +0200, Andy Shevchenko wrote:
> > Move Lynxpoint GPIO driver under Intel pin control umbrella
> > for further transformation to a real pin control driver.
> > +config PINCTRL_LYNXPOINT
> > + tristate "Intel Lynxpoint pinctrl and GPIO driver"
> > + depends on ACPI
> > + select GPIOLIB
> > + select GPIOLIB_IRQCHIP
> > + help
> > + Lynxpoint is the PCH of Intel Haswell. This pinctrl driver
> > + provides an interface that allows configuring of PCH pins and
> > + using them as GPIOs.
>
> In order to keep the above (non pinctrl-intel.c based drivers) sorted
> alphabetically, can you move this before PINCTRL_MERRIFIELD?
Fixed in my review branch.
> > +obj-$(CONFIG_PINCTRL_LYNXPOINT) += pinctrl-lynxpoint.o
>
> Here too.
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-11-07 14:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 14:48 [PATCH v1 0/8] pinctrl: intel: Move Lynxpoint to pin control umbrella Andy Shevchenko
2019-11-06 14:48 ` [PATCH v1 1/8] pinctrl: lynxpoint: Move GPIO driver to pin controller folder Andy Shevchenko
2019-11-07 13:48 ` Mika Westerberg
2019-11-07 14:47 ` Andy Shevchenko [this message]
2019-11-13 9:54 ` Linus Walleij
2019-11-13 13:40 ` Andy Shevchenko
2019-11-06 14:48 ` [PATCH v1 2/8] pinctrl: lynxpoint: Use raw_spinlock for locking Andy Shevchenko
2019-11-06 14:48 ` [PATCH v1 3/8] pinctrl: lynxpoint: Correct amount of pins Andy Shevchenko
2019-11-06 14:48 ` [PATCH v1 4/8] pinctrl: lynxpoint: Keep pointer to struct device instead of its container Andy Shevchenko
2019-11-06 14:48 ` [PATCH v1 5/8] pinctrl: lynxpoint: Use %pR to print IO resource Andy Shevchenko
2019-11-06 14:48 ` [PATCH v1 6/8] pinctrl: lynxpoint: Switch to memory mapped IO accessors Andy Shevchenko
2019-11-06 14:48 ` [PATCH v1 7/8] pinctrl: lynxpoint: Convert unsigned to unsigned int Andy Shevchenko
2019-11-06 14:48 ` [PATCH v1 8/8] pinctrl: lynxpoint: Move ->remove closer to ->probe() Andy Shevchenko
2019-11-13 9:54 ` [PATCH v1 0/8] pinctrl: intel: Move Lynxpoint to pin control umbrella Linus Walleij
2019-11-25 12:02 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107144752.GY32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).