Linux-GPIO Archive on lore.kernel.org
 help / color / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Peng Fan <peng.fan@nxp.com>
Cc: "rjui@broadcom.com" <rjui@broadcom.com>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"sbranden@broadcom.com" <sbranden@broadcom.com>,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"bcm-kernel-feedback-list@broadcom.com" 
	<bcm-kernel-feedback-list@broadcom.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Alice Guo <alice.guo@nxp.com>
Subject: Re: [PATCH v2 2/2] gpio: bcm-kona: use platform_irq_count
Date: Wed, 4 Dec 2019 10:17:46 +0100
Message-ID: <20191204091746.vql5yuajtzmr25lp@pengutronix.de> (raw)
In-Reply-To: <AM0PR04MB4481D76A9779C2DA7B1331C3885D0@AM0PR04MB4481.eurprd04.prod.outlook.com>

On Wed, Dec 04, 2019 at 08:41:14AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH v2 2/2] gpio: bcm-kona: use platform_irq_count
> > 
> > On Wed, Dec 04, 2019 at 04:20:45AM +0000, Peng Fan wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > platform_irq_count() is the more generic way (independent of device
> > > trees) to determine the count of available interrupts. So use this
> > > instead.
> > >
> > > As platform_irq_count() might return an error code (which of_irq_count
> > > doesn't) some additional handling is necessary.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >
> > > V2:
> > >  Update commit log, and add err handling  Not tested, just code
> > > inspection
> > >
> > >  drivers/gpio/gpio-bcm-kona.c | 12 +++++++++---
> > >  1 file changed, 9 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/gpio/gpio-bcm-kona.c
> > > b/drivers/gpio/gpio-bcm-kona.c index 4122683eb1f9..52ff56166263
> > 100644
> > > --- a/drivers/gpio/gpio-bcm-kona.c
> > > +++ b/drivers/gpio/gpio-bcm-kona.c
> > > @@ -19,7 +19,6 @@
> > >  #include <linux/io.h>
> > >  #include <linux/gpio/driver.h>
> > >  #include <linux/of_device.h>
> > > -#include <linux/of_irq.h>
> > >  #include <linux/init.h>
> > >  #include <linux/irqdomain.h>
> > >  #include <linux/irqchip/chained_irq.h> @@ -586,11 +585,18 @@ static
> > > int bcm_kona_gpio_probe(struct platform_device *pdev)
> > >
> > >  	kona_gpio->gpio_chip = template_chip;
> > >  	chip = &kona_gpio->gpio_chip;
> > > -	kona_gpio->num_bank = of_irq_count(dev->of_node);
> > > -	if (kona_gpio->num_bank == 0) {
> > > +	ret = platform_irq_count(pdev);
> > > +	if (!ret) {
> > >  		dev_err(dev, "Couldn't determine # GPIO banks\n");
> > >  		return -ENOENT;
> > > +	} else if (ret < 0) {
> > > +		if (ret != -EPROBE_DEFER)
> > > +			dev_err(dev, "Couldn't determine GPIO banks: %d\n",
> > > +				ret);
> > 
> > You can use the new %pe feature here:
> 
> Checkpatch reports warning:
> 
> WARNING: Invalid vsprintf pointer extension '%pe'
> #49: FILE: drivers/gpio/gpio-bcm-kona.c:593:
> +               if (ret != -EPROBE_DEFER)
> +                       dev_err(dev, "Couldn't determine GPIO banks: (%pe)\n",
> +                               ERR_PTR(ret));

Then you test with a tree older than
1d28122131b263f169a7f2d288178a56c69ee076. Then you also might not have
57f5677e535ba24b8926a7125be2ef8d7f09323c which you need to make %pe
work.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04  4:20 [PATCH v2 1/2] gpio: mvebu: " Peng Fan
2019-12-04  4:20 ` [PATCH v2 2/2] gpio: bcm-kona: " Peng Fan
2019-12-04  7:27   ` Uwe Kleine-König
2019-12-04  8:41     ` Peng Fan
2019-12-04  9:17       ` Uwe Kleine-König [this message]
2019-12-04  7:24 ` [PATCH v2 1/2] gpio: mvebu: " Uwe Kleine-König
2019-12-04 16:33   ` Bartosz Golaszewski
2019-12-04 18:47     ` Uwe Kleine-König
2019-12-05  9:22       ` Bartosz Golaszewski

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191204091746.vql5yuajtzmr25lp@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=alice.guo@nxp.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=f.fainelli@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=rjui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-GPIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \
		linux-gpio@vger.kernel.org
	public-inbox-index linux-gpio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git