From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Marek Vasut <marek.vasut@gmail.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
Mark Brown <broonie@kernel.org>,
kernel@pengutronix.de, linux-gpio@vger.kernel.org,
Marcel Gudert <m.gudert@eckelmann.de>
Subject: Re: [PATCH v2 1/2] gpio: pca953x: fix handling of automatic address incrementing
Date: Tue, 31 Mar 2020 13:07:59 +0300 [thread overview]
Message-ID: <20200331100759.GE1922688@smile.fi.intel.com> (raw)
In-Reply-To: <20200330195018.27494-2-u.kleine-koenig@pengutronix.de>
On Mon, Mar 30, 2020 at 09:50:17PM +0200, Uwe Kleine-König wrote:
...
> The history of this bug is a bit complicated. Commit b32cecb46bdc
> ("gpio: pca953x: Extract the register address mangling to single
> function") changed which chips and functions are affected. Commit
> 3b00691cc46a ("gpio: pca953x: hack to fix 24 bit gpio expanders") used
> some duct tape to make the driver at least appear to work. Commit
> 49427232764d ("gpio: pca953x: Perform basic regmap conversion")
> introduced the caching. Commit b4818afeacbd ("gpio: pca953x: Add
> set_multiple to allow multiple bits to be set in one write.") introduced
> the .set_multiple() callback which didn't work for chips that need the
> AI bit which was fixed later for some chips in 8958262af3fb ("gpio:
> pca953x: Repair multi-byte IO address increment on PCA9575"). So I'm
> sorry, I don't know which commit I should pick for a Fixes: line.
It's allowed to put more, but I rather utilize Depends-on for that.
So, something like
Fixes: b4818afeacbd ...
Depends-on: 8958262af3fb ...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-03-31 10:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 19:50 [PATCH v2 0/2] gpio: pca953x: fix handling of automatic address incrementing Uwe Kleine-König
2020-03-30 19:50 ` [PATCH v2 1/2] " Uwe Kleine-König
2020-03-31 10:02 ` Andy Shevchenko
2020-03-31 10:07 ` Andy Shevchenko [this message]
2020-04-14 10:15 ` Uwe Kleine-König
2020-04-14 13:16 ` Andy Shevchenko
2020-03-30 19:50 ` [PATCH v2 2/2] gpio: pca953x: drop unused parameters of pca953x_recalc_addr() Uwe Kleine-König
2020-03-31 10:04 ` [PATCH v2 0/2] gpio: pca953x: fix handling of automatic address incrementing Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331100759.GE1922688@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hns@goldelico.com \
--cc=kernel@pengutronix.de \
--cc=linux-gpio@vger.kernel.org \
--cc=m.gudert@eckelmann.de \
--cc=marek.vasut@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).