From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Marek Vasut <marek.vasut@gmail.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
Mark Brown <broonie@kernel.org>,
kernel@pengutronix.de, linux-gpio@vger.kernel.org,
Marcel Gudert <m.gudert@eckelmann.de>
Subject: Re: [PATCH v2 1/2] gpio: pca953x: fix handling of automatic address incrementing
Date: Tue, 14 Apr 2020 16:16:01 +0300 [thread overview]
Message-ID: <20200414131601.GO34613@smile.fi.intel.com> (raw)
In-Reply-To: <20200414101545.2bmzlid7c7aosbs6@pengutronix.de>
On Tue, Apr 14, 2020 at 12:15:45PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> obviously I failed to Cc: the gpio maintainers. Should I resend because
> of that?
I guess it's better to do because of
- this,
- v5.7-rc1 is out, makes sense to rebase.
...
> > So, something like
> >
> > Fixes: b4818afeacbd ...
> > Depends-on: 8958262af3fb ...
>
> I don't know what is best here. Using
>
> Fixes: b4818afeacbd ("gpio: pca953x: Add set_multiple to allow multiple bits to be set in one write.")
>
> seems sensible. Not sure which commits are sensible to list in
> Depends-on lines. I tend to just don't list any and then backport on
> request of the stable maintainers iff and when application to older
> versions failed.
Depends-on, in my opinion, is good to have to show at least one significant
dependency for the fix.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-14 13:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 19:50 [PATCH v2 0/2] gpio: pca953x: fix handling of automatic address incrementing Uwe Kleine-König
2020-03-30 19:50 ` [PATCH v2 1/2] " Uwe Kleine-König
2020-03-31 10:02 ` Andy Shevchenko
2020-03-31 10:07 ` Andy Shevchenko
2020-04-14 10:15 ` Uwe Kleine-König
2020-04-14 13:16 ` Andy Shevchenko [this message]
2020-03-30 19:50 ` [PATCH v2 2/2] gpio: pca953x: drop unused parameters of pca953x_recalc_addr() Uwe Kleine-König
2020-03-31 10:04 ` [PATCH v2 0/2] gpio: pca953x: fix handling of automatic address incrementing Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414131601.GO34613@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=hns@goldelico.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=m.gudert@eckelmann.de \
--cc=marek.vasut@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).