From: Linus Walleij <linus.walleij@linaro.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: linux-spi <linux-spi@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: Boot failure with 5.4-rc5, bisected to 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO descriptors")
Date: Thu, 28 Nov 2019 09:42:53 +0100 [thread overview]
Message-ID: <CACRpkdYPxSip9UAa-6sgXSgnCfdaXb8dxoh7ud=j7P+n_ax48A@mail.gmail.com> (raw)
In-Reply-To: <c3090d62-d049-5c9b-d48e-380b71755bfb@c-s.fr>
On Wed, Nov 27, 2019 at 3:29 PM Christophe Leroy
<christophe.leroy@c-s.fr> wrote:
> Le 27/11/2019 à 14:56, Linus Walleij a écrit :
> > I sent three patches, can you apply them on a clean tree
> > and confirm it solves the problem (fingers crossed...)
> >
> > Thanks a lot for helping me fix this!
>
> The series is OK if using 'cs-gpios'.
>
> With 'gpios' in the DTS, I get:
>
> [ 3.154747] fsl_spi ff000a80.spi: cs1 >= max 1
> [ 3.159207] spi_master spi0: spi_device register error
Ooops I looked over the gpiolib patch and found (I think) my mistake.
I sent a v3 patch set that hopefully will make everything work as
expected with just gpios = <...>;
Yours,
Linus Walleij
prev parent reply other threads:[~2019-11-28 8:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 12:33 Boot failure with 5.4-rc5, bisected to 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO descriptors") Christophe Leroy
2019-11-08 13:09 ` Linus Walleij
2019-11-08 13:34 ` Christophe Leroy
2019-11-26 15:01 ` Christophe Leroy
2019-11-26 15:35 ` Fabio Estevam
2019-11-26 16:16 ` Christophe Leroy
2019-11-26 16:23 ` Mark Brown
2019-11-26 15:48 ` Linus Walleij
2019-11-26 19:08 ` Christophe Leroy
2019-11-26 19:14 ` Christophe Leroy
2019-11-27 8:26 ` Linus Walleij
2019-11-27 8:57 ` Christophe Leroy
2019-11-27 9:07 ` Christophe Leroy
2019-11-27 9:11 ` Linus Walleij
2019-11-27 9:34 ` Christophe Leroy
2019-11-27 10:02 ` Linus Walleij
2019-11-27 10:39 ` Christophe Leroy
2019-11-27 10:55 ` Linus Walleij
2019-11-27 12:04 ` Christophe Leroy
2019-11-27 13:00 ` Linus Walleij
2019-11-27 13:44 ` Christophe Leroy
2019-11-27 13:52 ` Linus Walleij
2019-11-27 13:54 ` Christophe Leroy
2019-11-27 13:56 ` Linus Walleij
2019-11-27 14:29 ` Christophe Leroy
2019-11-28 8:42 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYPxSip9UAa-6sgXSgnCfdaXb8dxoh7ud=j7P+n_ax48A@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=broonie@kernel.org \
--cc=christophe.leroy@c-s.fr \
--cc=festevam@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).