From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Sungbo Eo <mans0n@gorani.run>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-gpio <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570
Date: Wed, 1 Jul 2020 00:23:48 +0300 [thread overview]
Message-ID: <CAHp75VcA-kmJHyuZOMs-BDqhQ7FszZti=uHmSs-NCH2F6e_c4A@mail.gmail.com> (raw)
In-Reply-To: <c7fd2365-0f47-b2c8-4085-020928c79254@gorani.run>
On Tue, Jun 30, 2020 at 7:11 PM Sungbo Eo <mans0n@gorani.run> wrote:
>
> Thanks for all the reviews! I've updated the patch, please have a look.
>
> And I have something to ask.
>
> # echo 1 > gpio408/value
> # cat gpio408/value
> cat: read error: I/O error
> # cat gpio408/direction
> out
> # echo out > gpio408/direction
> # echo in > gpio408/direction
> [ 91.006691] gpio-408 (sysfs): gpiod_direction_input: missing get()
> but have direction_input()
> ash: write error: I/O error
>
> I've never dealt with GPO expander before, so this seems a bit odd to me.
> Is it perfectly okay to leave get() and direction_input() unimplemented?
Actually it would be better to return the value you set for output in ->get().
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-06-30 21:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 7:58 [PATCH v2 1/2] gpio: add GPO driver for PCA9570 Sungbo Eo
2020-06-25 8:59 ` Andy Shevchenko
2020-06-25 14:43 ` kernel test robot
2020-06-25 16:38 ` kernel test robot
2020-06-30 9:18 ` Bartosz Golaszewski
2020-06-30 9:53 ` Andy Shevchenko
2020-06-30 16:11 ` Sungbo Eo
2020-06-30 21:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcA-kmJHyuZOMs-BDqhQ7FszZti=uHmSs-NCH2F6e_c4A@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans0n@gorani.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).