* [PATCH 0/5] Add pinctrl support for dwapb gpio driver
@ 2019-12-04 10:10 Clement Leger
2019-12-04 12:24 ` Andy Shevchenko
2019-12-13 8:59 ` Linus Walleij
0 siblings, 2 replies; 6+ messages in thread
From: Clement Leger @ 2019-12-04 10:10 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Hoan Tran, linux-gpio
Cc: Clement Leger, devicetree, linux-kernel
Synopsys DWAPB IP includes support for pin control. This control is basic
and allows to switch between a hardware and a software function.
Software function is when driving GPIOs from IP and hardware is controlled
by external signals.
This serie export necessary interface to be able to move the driver to
pinctrl folder and then implement the pinctrl support which is based on the
digicolor driver. The idea is to avoid hardcoding pins in driver since
this IP is a generic one available on multiple SoC.
Clement Leger (5):
gpio: export acpi_gpiochip_request_interrupts in gpio/driver.h
pinctrl: dw: move gpio-dwapb.c to pinctrl folder
pinctrl: dw: use devm_gpiochip_add_data
pinctrl: dw: add pinctrl support for dwapb gpio driver
dt-bindings: pinctrl: dw: move sps,dwapb-gpio.txt to pinctrl
.../bindings/{gpio => pinctrl}/snps-dwapb-gpio.txt | 21 +-
MAINTAINERS | 6 +-
drivers/gpio/Kconfig | 8 -
drivers/gpio/Makefile | 1 -
drivers/gpio/gpiolib-acpi.h | 4 -
drivers/pinctrl/Kconfig | 1 +
drivers/pinctrl/Makefile | 1 +
drivers/pinctrl/dw/Kconfig | 11 +
drivers/pinctrl/dw/Makefile | 4 +
.../gpio-dwapb.c => pinctrl/dw/pinctrl-dwapb.c} | 277 +++++++++++++++++++--
include/linux/gpio/driver.h | 12 +
include/linux/platform_data/gpio-dwapb.h | 1 +
12 files changed, 310 insertions(+), 37 deletions(-)
rename Documentation/devicetree/bindings/{gpio => pinctrl}/snps-dwapb-gpio.txt (76%)
create mode 100644 drivers/pinctrl/dw/Kconfig
create mode 100644 drivers/pinctrl/dw/Makefile
rename drivers/{gpio/gpio-dwapb.c => pinctrl/dw/pinctrl-dwapb.c} (77%)
--
2.15.0.276.g89ea799
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 0/5] Add pinctrl support for dwapb gpio driver
2019-12-04 10:10 [PATCH 0/5] Add pinctrl support for dwapb gpio driver Clement Leger
@ 2019-12-04 12:24 ` Andy Shevchenko
2019-12-04 13:30 ` Clément Leger
2019-12-13 8:59 ` Linus Walleij
1 sibling, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2019-12-04 12:24 UTC (permalink / raw)
To: Clement Leger
Cc: Linus Walleij, Bartosz Golaszewski, Hoan Tran,
open list:GPIO SUBSYSTEM, devicetree, Linux Kernel Mailing List
On Wed, Dec 4, 2019 at 12:13 PM Clement Leger <cleger@kalray.eu> wrote:
>
> Synopsys DWAPB IP includes support for pin control. This control is basic
> and allows to switch between a hardware and a software function.
> Software function is when driving GPIOs from IP and hardware is controlled
> by external signals.
> This serie export necessary interface to be able to move the driver to
> pinctrl folder and then implement the pinctrl support which is based on the
> digicolor driver. The idea is to avoid hardcoding pins in driver since
> this IP is a generic one available on multiple SoC.
>
This series misses at least GPIO ACPI maintainers to be Cc'ed to for
the certain changes.
Moreover, I would like to see entire series in the future in my mailbox.
I will look at v1 closer anyway.
> Clement Leger (5):
> gpio: export acpi_gpiochip_request_interrupts in gpio/driver.h
> pinctrl: dw: move gpio-dwapb.c to pinctrl folder
> pinctrl: dw: use devm_gpiochip_add_data
> pinctrl: dw: add pinctrl support for dwapb gpio driver
> dt-bindings: pinctrl: dw: move sps,dwapb-gpio.txt to pinctrl
>
> .../bindings/{gpio => pinctrl}/snps-dwapb-gpio.txt | 21 +-
> MAINTAINERS | 6 +-
> drivers/gpio/Kconfig | 8 -
> drivers/gpio/Makefile | 1 -
> drivers/gpio/gpiolib-acpi.h | 4 -
> drivers/pinctrl/Kconfig | 1 +
> drivers/pinctrl/Makefile | 1 +
> drivers/pinctrl/dw/Kconfig | 11 +
> drivers/pinctrl/dw/Makefile | 4 +
> .../gpio-dwapb.c => pinctrl/dw/pinctrl-dwapb.c} | 277 +++++++++++++++++++--
> include/linux/gpio/driver.h | 12 +
> include/linux/platform_data/gpio-dwapb.h | 1 +
> 12 files changed, 310 insertions(+), 37 deletions(-)
> rename Documentation/devicetree/bindings/{gpio => pinctrl}/snps-dwapb-gpio.txt (76%)
> create mode 100644 drivers/pinctrl/dw/Kconfig
> create mode 100644 drivers/pinctrl/dw/Makefile
> rename drivers/{gpio/gpio-dwapb.c => pinctrl/dw/pinctrl-dwapb.c} (77%)
>
> --
> 2.15.0.276.g89ea799
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 0/5] Add pinctrl support for dwapb gpio driver
2019-12-04 12:24 ` Andy Shevchenko
@ 2019-12-04 13:30 ` Clément Leger
2019-12-04 17:46 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Clément Leger @ 2019-12-04 13:30 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linus Walleij, Bartosz Golaszewski, Hoan Tran,
open list:GPIO SUBSYSTEM, devicetree, linux-kernel
----- On 4 Dec, 2019, at 13:24, Andy Shevchenko andy.shevchenko@gmail.com wrote:
> On Wed, Dec 4, 2019 at 12:13 PM Clement Leger <cleger@kalray.eu> wrote:
>>
>> Synopsys DWAPB IP includes support for pin control. This control is basic
>> and allows to switch between a hardware and a software function.
>> Software function is when driving GPIOs from IP and hardware is controlled
>> by external signals.
>> This serie export necessary interface to be able to move the driver to
>> pinctrl folder and then implement the pinctrl support which is based on the
>> digicolor driver. The idea is to avoid hardcoding pins in driver since
>> this IP is a generic one available on multiple SoC.
>>
>
> This series misses at least GPIO ACPI maintainers to be Cc'ed to for
> the certain changes.
> Moreover, I would like to see entire series in the future in my mailbox.
Sorry, I messed up with get_maintainer.pl while sending the serie.
I can resend it properly if needed.
>
> I will look at v1 closer anyway.
>
>> Clement Leger (5):
>> gpio: export acpi_gpiochip_request_interrupts in gpio/driver.h
>> pinctrl: dw: move gpio-dwapb.c to pinctrl folder
>> pinctrl: dw: use devm_gpiochip_add_data
>> pinctrl: dw: add pinctrl support for dwapb gpio driver
>> dt-bindings: pinctrl: dw: move sps,dwapb-gpio.txt to pinctrl
>>
>> .../bindings/{gpio => pinctrl}/snps-dwapb-gpio.txt | 21 +-
>> MAINTAINERS | 6 +-
>> drivers/gpio/Kconfig | 8 -
>> drivers/gpio/Makefile | 1 -
>> drivers/gpio/gpiolib-acpi.h | 4 -
>> drivers/pinctrl/Kconfig | 1 +
>> drivers/pinctrl/Makefile | 1 +
>> drivers/pinctrl/dw/Kconfig | 11 +
>> drivers/pinctrl/dw/Makefile | 4 +
>> .../gpio-dwapb.c => pinctrl/dw/pinctrl-dwapb.c} | 277 +++++++++++++++++++--
>> include/linux/gpio/driver.h | 12 +
>> include/linux/platform_data/gpio-dwapb.h | 1 +
>> 12 files changed, 310 insertions(+), 37 deletions(-)
>> rename Documentation/devicetree/bindings/{gpio => pinctrl}/snps-dwapb-gpio.txt
>> (76%)
>> create mode 100644 drivers/pinctrl/dw/Kconfig
>> create mode 100644 drivers/pinctrl/dw/Makefile
>> rename drivers/{gpio/gpio-dwapb.c => pinctrl/dw/pinctrl-dwapb.c} (77%)
>>
>> --
>> 2.15.0.276.g89ea799
>>
>
>
> --
> With Best Regards,
> Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 0/5] Add pinctrl support for dwapb gpio driver
2019-12-04 13:30 ` Clément Leger
@ 2019-12-04 17:46 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2019-12-04 17:46 UTC (permalink / raw)
To: Clément Leger
Cc: Linus Walleij, Bartosz Golaszewski, Hoan Tran,
open list:GPIO SUBSYSTEM, devicetree, linux-kernel
On Wed, Dec 4, 2019 at 3:30 PM Clément Leger <cleger@kalray.eu> wrote:
> ----- On 4 Dec, 2019, at 13:24, Andy Shevchenko andy.shevchenko@gmail.com wrote:
> > On Wed, Dec 4, 2019 at 12:13 PM Clement Leger <cleger@kalray.eu> wrote:
> > This series misses at least GPIO ACPI maintainers to be Cc'ed to for
> > the certain changes.
> > Moreover, I would like to see entire series in the future in my mailbox.
>
> Sorry, I messed up with get_maintainer.pl while sending the serie.
It's not your fault. I sent a patch to update MAINTAINERS to include
header file under GPIO ACPI record.
> I can resend it properly if needed.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/5] Add pinctrl support for dwapb gpio driver
2019-12-04 10:10 [PATCH 0/5] Add pinctrl support for dwapb gpio driver Clement Leger
2019-12-04 12:24 ` Andy Shevchenko
@ 2019-12-13 8:59 ` Linus Walleij
2019-12-13 9:04 ` Clément Leger
1 sibling, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2019-12-13 8:59 UTC (permalink / raw)
To: Clement Leger
Cc: Bartosz Golaszewski, Hoan Tran, open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
On Wed, Dec 4, 2019 at 11:10 AM Clement Leger <cleger@kalray.eu> wrote:
> Synopsys DWAPB IP includes support for pin control. This control is basic
> and allows to switch between a hardware and a software function.
> Software function is when driving GPIOs from IP and hardware is controlled
> by external signals.
> This serie export necessary interface to be able to move the driver to
> pinctrl folder and then implement the pinctrl support which is based on the
> digicolor driver. The idea is to avoid hardcoding pins in driver since
> this IP is a generic one available on multiple SoC.
The overall approach is correct, just tidy up the patch series the
way indicated by Andy and we can probably proceed efficiently with
this. I will review the patch adding the pinctrl interfaces separately.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/5] Add pinctrl support for dwapb gpio driver
2019-12-13 8:59 ` Linus Walleij
@ 2019-12-13 9:04 ` Clément Leger
0 siblings, 0 replies; 6+ messages in thread
From: Clément Leger @ 2019-12-13 9:04 UTC (permalink / raw)
To: Linus Walleij
Cc: Bartosz Golaszewski, Hoan Tran, open list, GPIO SUBSYSTEM,
devicetree, linux-kernel
Ok thanks for your review, I will do that.
Regards,
Clément Léger
----- On 13 Dec, 2019, at 09:59, Linus Walleij linus.walleij@linaro.org wrote:
> On Wed, Dec 4, 2019 at 11:10 AM Clement Leger <cleger@kalray.eu> wrote:
>
>> Synopsys DWAPB IP includes support for pin control. This control is basic
>> and allows to switch between a hardware and a software function.
>> Software function is when driving GPIOs from IP and hardware is controlled
>> by external signals.
>> This serie export necessary interface to be able to move the driver to
>> pinctrl folder and then implement the pinctrl support which is based on the
>> digicolor driver. The idea is to avoid hardcoding pins in driver since
>> this IP is a generic one available on multiple SoC.
>
> The overall approach is correct, just tidy up the patch series the
> way indicated by Andy and we can probably proceed efficiently with
> this. I will review the patch adding the pinctrl interfaces separately.
>
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-13 9:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04 10:10 [PATCH 0/5] Add pinctrl support for dwapb gpio driver Clement Leger
2019-12-04 12:24 ` Andy Shevchenko
2019-12-04 13:30 ` Clément Leger
2019-12-04 17:46 ` Andy Shevchenko
2019-12-13 8:59 ` Linus Walleij
2019-12-13 9:04 ` Clément Leger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).