* [PATCH -next] gpiolib: acpi: Use METHOD_NAME__AEI macro for acpi_walk_resources
@ 2022-10-20 1:44 Xiang Yang
2022-10-20 13:23 ` Bartosz Golaszewski
0 siblings, 1 reply; 5+ messages in thread
From: Xiang Yang @ 2022-10-20 1:44 UTC (permalink / raw)
To: mika.westerberg, andriy.shevchenko, linus.walleij, brgl
Cc: linux-gpio, linux-acpi, linux-kernel
Using the METHOD_NAME__AEI macro instead of using "_AEI" directly.
Signed-off-by: Xiang Yang <xiangyang3@huawei.com>
---
drivers/gpio/gpiolib-acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index a7d2358736fe..064ba5150fd4 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -512,7 +512,7 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip)
if (ACPI_FAILURE(status))
return;
- acpi_walk_resources(handle, "_AEI",
+ acpi_walk_resources(handle, METHOD_NAME__AEI,
acpi_gpiochip_alloc_event, acpi_gpio);
mutex_lock(&acpi_gpio_deferred_req_irqs_lock);
--
2.22.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] gpiolib: acpi: Use METHOD_NAME__AEI macro for acpi_walk_resources
2022-10-20 1:44 [PATCH -next] gpiolib: acpi: Use METHOD_NAME__AEI macro for acpi_walk_resources Xiang Yang
@ 2022-10-20 13:23 ` Bartosz Golaszewski
2022-10-20 13:51 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Bartosz Golaszewski @ 2022-10-20 13:23 UTC (permalink / raw)
To: Xiang Yang
Cc: mika.westerberg, andriy.shevchenko, linus.walleij, linux-gpio,
linux-acpi, linux-kernel
On Thu, Oct 20, 2022 at 3:48 AM Xiang Yang <xiangyang3@huawei.com> wrote:
>
> Using the METHOD_NAME__AEI macro instead of using "_AEI" directly.
>
> Signed-off-by: Xiang Yang <xiangyang3@huawei.com>
> ---
> drivers/gpio/gpiolib-acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> index a7d2358736fe..064ba5150fd4 100644
> --- a/drivers/gpio/gpiolib-acpi.c
> +++ b/drivers/gpio/gpiolib-acpi.c
> @@ -512,7 +512,7 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip)
> if (ACPI_FAILURE(status))
> return;
>
> - acpi_walk_resources(handle, "_AEI",
> + acpi_walk_resources(handle, METHOD_NAME__AEI,
> acpi_gpiochip_alloc_event, acpi_gpio);
This line dates back to 2018 so why -next in your PATCH tag?
That being said - patch applied (unless Andy wants to take it directly).
Bart
>
> mutex_lock(&acpi_gpio_deferred_req_irqs_lock);
> --
> 2.22.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] gpiolib: acpi: Use METHOD_NAME__AEI macro for acpi_walk_resources
2022-10-20 13:23 ` Bartosz Golaszewski
@ 2022-10-20 13:51 ` Andy Shevchenko
2022-10-20 14:30 ` Bartosz Golaszewski
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2022-10-20 13:51 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Xiang Yang, mika.westerberg, linus.walleij, linux-gpio,
linux-acpi, linux-kernel
On Thu, Oct 20, 2022 at 03:23:27PM +0200, Bartosz Golaszewski wrote:
> On Thu, Oct 20, 2022 at 3:48 AM Xiang Yang <xiangyang3@huawei.com> wrote:
> >
> > Using the METHOD_NAME__AEI macro instead of using "_AEI" directly.
> >
> > Signed-off-by: Xiang Yang <xiangyang3@huawei.com>
> > ---
> > drivers/gpio/gpiolib-acpi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> > index a7d2358736fe..064ba5150fd4 100644
> > --- a/drivers/gpio/gpiolib-acpi.c
> > +++ b/drivers/gpio/gpiolib-acpi.c
> > @@ -512,7 +512,7 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip)
> > if (ACPI_FAILURE(status))
> > return;
> >
> > - acpi_walk_resources(handle, "_AEI",
> > + acpi_walk_resources(handle, METHOD_NAME__AEI,
> > acpi_gpiochip_alloc_event, acpi_gpio);
>
> This line dates back to 2018 so why -next in your PATCH tag?
This means "for Linux next cycle". It has roots in the net subsystem where
it's a requirement to mark each patch either net or net-next, because they
have a huge traffic of patches.
> That being said - patch applied (unless Andy wants to take it directly).
I think I will take it. Care to provide your tag?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] gpiolib: acpi: Use METHOD_NAME__AEI macro for acpi_walk_resources
2022-10-20 13:51 ` Andy Shevchenko
@ 2022-10-20 14:30 ` Bartosz Golaszewski
2022-10-25 16:47 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Bartosz Golaszewski @ 2022-10-20 14:30 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Xiang Yang, mika.westerberg, linus.walleij, linux-gpio,
linux-acpi, linux-kernel
On Thu, Oct 20, 2022 at 3:51 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Thu, Oct 20, 2022 at 03:23:27PM +0200, Bartosz Golaszewski wrote:
> > On Thu, Oct 20, 2022 at 3:48 AM Xiang Yang <xiangyang3@huawei.com> wrote:
> > >
> > > Using the METHOD_NAME__AEI macro instead of using "_AEI" directly.
> > >
> > > Signed-off-by: Xiang Yang <xiangyang3@huawei.com>
> > > ---
> > > drivers/gpio/gpiolib-acpi.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> > > index a7d2358736fe..064ba5150fd4 100644
> > > --- a/drivers/gpio/gpiolib-acpi.c
> > > +++ b/drivers/gpio/gpiolib-acpi.c
> > > @@ -512,7 +512,7 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip)
> > > if (ACPI_FAILURE(status))
> > > return;
> > >
> > > - acpi_walk_resources(handle, "_AEI",
> > > + acpi_walk_resources(handle, METHOD_NAME__AEI,
> > > acpi_gpiochip_alloc_event, acpi_gpio);
> >
> > This line dates back to 2018 so why -next in your PATCH tag?
>
> This means "for Linux next cycle". It has roots in the net subsystem where
> it's a requirement to mark each patch either net or net-next, because they
> have a huge traffic of patches.
>
> > That being said - patch applied (unless Andy wants to take it directly).
>
> I think I will take it. Care to provide your tag?
>
Just take it, I will back it out.
Bartosz
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] gpiolib: acpi: Use METHOD_NAME__AEI macro for acpi_walk_resources
2022-10-20 14:30 ` Bartosz Golaszewski
@ 2022-10-25 16:47 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2022-10-25 16:47 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Xiang Yang, mika.westerberg, linus.walleij, linux-gpio,
linux-acpi, linux-kernel
On Thu, Oct 20, 2022 at 04:30:27PM +0200, Bartosz Golaszewski wrote:
> On Thu, Oct 20, 2022 at 3:51 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Thu, Oct 20, 2022 at 03:23:27PM +0200, Bartosz Golaszewski wrote:
...
> > I think I will take it. Care to provide your tag?
>
> Just take it, I will back it out.
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-10-25 16:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-20 1:44 [PATCH -next] gpiolib: acpi: Use METHOD_NAME__AEI macro for acpi_walk_resources Xiang Yang
2022-10-20 13:23 ` Bartosz Golaszewski
2022-10-20 13:51 ` Andy Shevchenko
2022-10-20 14:30 ` Bartosz Golaszewski
2022-10-25 16:47 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).