From: Krzysztof Kozlowski <krzk@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Paul Burton <paulburton@kernel.org>,
Quentin Schulz <quentin.schulz@bootlin.com>,
Antoine Tenart <atenart@kernel.org>,
Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
"David S . Miller" <davem@davemloft.net>,
UNGLinuxDriver@microchip.com, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH v3 6/6] dt-bindings: pinctrl: convert ocelot-pinctrl to YAML format
Date: Sun, 20 Mar 2022 12:17:07 +0100 [thread overview]
Message-ID: <e2565939-5b0e-1282-b76f-6402399fcfc0@kernel.org> (raw)
In-Reply-To: <3949a4c3271473b73851b0970bdb58b8@walle.cc>
On 20/03/2022 12:08, Michael Walle wrote:
> Am 2022-03-20 11:54, schrieb Krzysztof Kozlowski:
>> On 19/03/2022 21:46, Michael Walle wrote:
>>> Convert the ocelot-pinctrl device tree binding to the new YAML format.
>>>
>>> Additionally to the original binding documentation, add interrupt
>>> properties which are optional and already used on several SoCs like
>>> SparX-5, Luton, Ocelot and LAN966x but were not documented before.
>>>
>>> Also, on the sparx5 and the lan966x SoCs there are two items for the
>>> reg property.
>>>
>>> Signed-off-by: Michael Walle <michael@walle.cc>
>>> ---
>>> .../bindings/pinctrl/mscc,ocelot-pinctrl.txt | 42 -------
>>> .../bindings/pinctrl/mscc,ocelot-pinctrl.yaml | 108
>>> ++++++++++++++++++
>>> 2 files changed, 108 insertions(+), 42 deletions(-)
>>> delete mode 100644
>>> Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.txt
>>> create mode 100644
>>> Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.yaml
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.txt
>>> b/Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.txt
>>> deleted file mode 100644
>>> index 5d84fd299ccf..000000000000
>>> ---
>>> a/Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.txt
>>> +++ /dev/null
>>> @@ -1,42 +0,0 @@
>>> -Microsemi Ocelot pin controller Device Tree Bindings
>>> -----------------------------------------------------
>>> -
>>> -Required properties:
>>> - - compatible : Should be "mscc,ocelot-pinctrl",
>>> - "mscc,jaguar2-pinctrl", "microchip,sparx5-pinctrl",
>>> - "mscc,luton-pinctrl", "mscc,serval-pinctrl",
>>> - "microchip,lan966x-pinctrl" or "mscc,servalt-pinctrl"
>>> - - reg : Address and length of the register set for the device
>>> - - gpio-controller : Indicates this device is a GPIO controller
>>> - - #gpio-cells : Must be 2.
>>> - The first cell is the pin number and the
>>> - second cell specifies GPIO flags, as defined in
>>> - <dt-bindings/gpio/gpio.h>.
>>> - - gpio-ranges : Range of pins managed by the GPIO controller.
>>> -
>>> -
>>> -The ocelot-pinctrl driver uses the generic pin multiplexing and
>>> generic pin
>>> -configuration documented in pinctrl-bindings.txt.
>>> -
>>> -The following generic properties are supported:
>>> - - function
>>> - - pins
>>> -
>>> -Example:
>>> - gpio: pinctrl@71070034 {
>>> - compatible = "mscc,ocelot-pinctrl";
>>> - reg = <0x71070034 0x28>;
>>> - gpio-controller;
>>> - #gpio-cells = <2>;
>>> - gpio-ranges = <&gpio 0 0 22>;
>>> -
>>> - uart_pins: uart-pins {
>>> - pins = "GPIO_6", "GPIO_7";
>>> - function = "uart";
>>> - };
>>> -
>>> - uart2_pins: uart2-pins {
>>> - pins = "GPIO_12", "GPIO_13";
>>> - function = "uart2";
>>> - };
>>> - };
>>> diff --git
>>> a/Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.yaml
>>> b/Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.yaml
>>> new file mode 100644
>>> index 000000000000..7149a6655623
>>> --- /dev/null
>>> +++
>>> b/Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.yaml
>>> @@ -0,0 +1,108 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/pinctrl/mscc,ocelot-pinctrl.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Microsemi Ocelot pin controller
>>> +
>>> +maintainers:
>>> + - Alexandre Belloni <alexandre.belloni@bootlin.com>
>>> + - Lars Povlsen <lars.povlsen@microchip.com>
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - microchip,lan966x-pinctrl
>>> + - microchip,sparx5-pinctrl
>>> + - mscc,jaguar2-pinctrl
>>> + - mscc,luton-pinctrl
>>> + - mscc,ocelot-pinctrl
>>> + - mscc,serval-pinctrl
>>> + - mscc,servalt-pinctrl
>>> +
>>> + reg:
>>> + items:
>>> + - description: Base address
>>> + - description: Extended pin configuration registers
>>> + minItems: 1
>>> +
>>> + gpio-controller: true
>>> +
>>> + '#gpio-cells':
>>> + const: 2
>>> +
>>> + gpio-ranges: true
>>> +
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>> + interrupt-controller: true
>>> +
>>> + "#interrupt-cells":
>>> + const: 2
>>
>> Thanks for the changes in other files, but I think you did not respond
>> to my comments here. Can you address them?
>
> Sorry, I might missunderstood you. They are currently used on all except
> on serval and servalt SoCs like described in the updated commit message.
> I thought it was clear from the commit message, so I didn't answer your
> questions in v2. Or is there something else?
>
No, it's okay.
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-20 11:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 20:46 [PATCH v3 0/6] pinctrl: ocelot: convert to YAML format Michael Walle
2022-03-19 20:46 ` [PATCH v3 1/6] MIPS: mscc: jaguar2: rename pinctrl nodes Michael Walle
2022-03-19 20:46 ` [PATCH v3 2/6] MIPS: mscc: ocelot: " Michael Walle
2022-03-19 20:46 ` [PATCH v3 3/6] MIPS: mscc: serval: " Michael Walle
2022-03-19 20:46 ` [PATCH v3 4/6] arm64: dts: sparx5: " Michael Walle
2023-05-17 12:23 ` (subset) " Krzysztof Kozlowski
2022-03-19 20:46 ` [PATCH v3 5/6] ARM: dts: lan966x: " Michael Walle
2022-05-17 14:36 ` Nicolas Ferre
2022-03-19 20:46 ` [PATCH v3 6/6] dt-bindings: pinctrl: convert ocelot-pinctrl to YAML format Michael Walle
2022-03-20 10:54 ` Krzysztof Kozlowski
2022-03-20 11:08 ` Michael Walle
2022-03-20 11:17 ` Krzysztof Kozlowski [this message]
2022-04-17 23:41 ` Linus Walleij
2022-04-18 8:16 ` Michael Walle
2022-04-18 8:19 ` Michael Walle
2022-04-18 11:13 ` Krzysztof Kozlowski
2022-04-18 12:04 ` Michael Walle
2022-04-19 22:33 ` Linus Walleij
2022-04-04 11:45 ` [PATCH v3 0/6] pinctrl: ocelot: convert " Michael Walle
2022-04-19 22:28 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2565939-5b0e-1282-b76f-6402399fcfc0@kernel.org \
--to=krzk@kernel.org \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=kavyasree.kotagiri@microchip.com \
--cc=lars.povlsen@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=michael@walle.cc \
--cc=nicolas.ferre@microchip.com \
--cc=paulburton@kernel.org \
--cc=quentin.schulz@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).