Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
From: Michele Sorcinelli <michelesr@autistici.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
	"Jean Delvare" <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] dell-smm-hwmon.c: Add XPS 9570 to supported devices list
Date: Fri, 30 Nov 2018 18:17:43 +0000
Message-ID: <026d224f-7f8d-b50f-f269-e6b2408a8822@autistici.org> (raw)
In-Reply-To: <20181130154935.GA19060@roeck-us.net>

Hi Guenter, thanks for your feedback.

On 11/30/18 3:49 PM, Guenter Roeck wrote:

> This is not where to put a Reviewed-by: tag, and the patch is
> not signed and thus can not be applied.

You're right. I'll make sure the patch is properly tagged and signed.

> If you have actual evidence that the problem lies within the driver,
> not with SMM, please share that information.

As you said the problem belongs to the SMM layer, the driver can't do anything
about it. I'll remove that part as it's unnecessary and confusing.

> This is a different problem, not part of this patch, and the information
> does not belong here.

I'll remove that part as well.

Cheers,
Michele.

On 11/30/18 3:49 PM, Guenter Roeck wrote:
> On Fri, Nov 30, 2018 at 03:44:08PM +0000, Michele Sorcinelli wrote:
>> Reviewed by: Pali Rohár <pali.rohar@gmail.com>
>>
> 
> This is not where to put a Reviewed-by: tag, and the patch is
> not signed and thus can not be applied.
> 
>> Allow the module to be loaded on Dell XPS 9570, without having to use
>> the "force=1" option. The module loads without problems, and reports
>> correct values:
>>
>>      $ time cat /proc/i8k
>>      1.0 1.5 -1 35 0 0 0 0 -1 -22
>>      cat /proc/i8k  0.00s user 0.00s system 7% cpu 0.033 total
>>
>> However, the call may freeze the kernel for a very small time due to
>> code running in the SSM layer. This is a known issue with the driver, and
>> can be reproduced with other supported models. Average execution
>> time is 33 ms.
> 
> Is it ? My understanding is that it is an issue with the SMM layer.
> If you have actual evidence that the problem lies within the driver,
> not with SMM, please share that information.
> 
>>
>> The command line tools from i8kutils can properly set the fan speed,
>> although the firmware will override it, unless automatic fan
>> control is disabled with the proper SSM call.
>>
>> Average fans speed (when firwmare automatic control is off):
>>
>> STATE -> RPM
>> 0 0 -> 0 0
>> 1 1 -> 2500 2500
>> 2 2 -> 5100 5100
>> 3 3 -> same as 2 2
>>
>> The SSM procedures I8K_SMM_GET_FAN_TYPE and I8K_SMM_GET_TEMP_TYPE are
>> failing to return valid values to the module, that can't label the fans
>> and initialize the temperature sensors in the hwmon interface.
>>
>> This is a problem in the firmware code, and may be eventually addressed
>> by a new firmware version.
>>
>>      $ sensors dell_smm-virtual-0
>>      dell_smm-virtual-0
>>      Adapter: Virtual device
>>      fan1:        2531 RPM
>>      fan2:        2496 RPM
>>
>> However, the procedures I8K_SMM_GET_FAN and I8K_SMM_GET_TEMP are working
>> properly, as they return correct values. This means that the module
>> could be modified to initialize the sensors without labels and report
>> correct temperatures.
> 
> This is a different problem, not part of this patch, and the information
> does not belong here.
> 
> Guenter
> 
>> ---
>>   drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
>> index 9d3ef879d..367a8a617 100644
>> --- a/drivers/hwmon/dell-smm-hwmon.c
>> +++ b/drivers/hwmon/dell-smm-hwmon.c
>> @@ -1017,6 +1017,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
>>   			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9560"),
>>   		},
>>   	},
>> +	{
>> +		.ident = "Dell XPS 15 9570",
>> +		.matches = {
>> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> +			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9570"),
>> +		},
>> +	},
>>   	{ }
>>   };
>>   
>> -- 
>> 2.19.2
>>

  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30 15:44 Michele Sorcinelli
2018-11-30 15:49 ` Guenter Roeck
2018-11-30 18:17   ` Michele Sorcinelli [this message]
2018-11-30 18:42     ` Michele Sorcinelli
2018-12-01 18:31       ` Guenter Roeck
  -- strict thread matches above, loose matches on Subject: below --
2018-11-27 23:06 Michele Sorcinelli
2018-11-28  8:14 ` Pali Rohár
2018-11-28 12:30 ` Michele Sorcinelli
2018-11-28 12:56   ` Pali Rohár
2018-11-28 13:01     ` Michele Sorcinelli
2018-11-28 23:23       ` Michele Sorcinelli
2018-11-29  9:48         ` Pali Rohár
2018-11-29 21:42           ` Michele Sorcinelli
2018-12-05  9:15             ` Pali Rohár

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=026d224f-7f8d-b50f-f269-e6b2408a8822@autistici.org \
    --to=michelesr@autistici.org \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=pali.rohar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org
	public-inbox-index linux-hwmon

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git