From: Michele Sorcinelli <michelesr@autistici.org> To: "Pali Rohár" <pali.rohar@gmail.com> Cc: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>, linux-hwmon@vger.kernel.org, Michele Sorcinelli <michelesr@autistici.org> Subject: [PATCH] dell-smm-hwmon.c: Add XPS 9570 to supported devices list Date: Tue, 27 Nov 2018 23:06:37 +0000 Message-ID: <20181127230637.8673-1-michelesr@autistici.org> (raw) Allow the module to be loaded on Dell XPS 9570, without having to use the "force=1" option. The module loads without problems, and reports correct fan values: $ time cat /proc/i8k 1.0 1.5 -1 35 0 0 0 0 -1 -22 cat /proc/i8k 0.00s user 0.00s system 7% cpu 0.033 total However, the call may freeze the kernel for a very small time due to code running in the SSM layer. This is a known issue with the driver, and can be reproduced with other supported models. Average execution time is 33 ms. The command line tools from i8kutils can properly set the fan speed, although the firmware will override it, unless automatic fan control is disabled with the proper SSM call. Average fans speed (when firwmare automatic control is off): STATE -> RPM 0 0 -> 0 0 1 1 -> 2500 2500 2 2 -> 5100 5100 3 3 -> same as 2 2 --- drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index 9d3ef879d..367a8a617 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1017,6 +1017,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = { DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9560"), }, }, + { + .ident = "Dell XPS 15 9570", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9570"), + }, + }, { } }; -- 2.19.2
next reply index Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-27 23:06 Michele Sorcinelli [this message] 2018-11-28 8:14 ` Pali Rohár 2018-11-28 12:30 ` Michele Sorcinelli 2018-11-28 12:56 ` Pali Rohár 2018-11-28 13:01 ` Michele Sorcinelli 2018-11-28 23:23 ` Michele Sorcinelli 2018-11-29 9:48 ` Pali Rohár 2018-11-29 21:42 ` Michele Sorcinelli 2018-12-05 9:15 ` Pali Rohár 2018-12-07 20:29 ` [PATCH] dell-smm-hwmon.c: Add support for additional temperature sensors Michele Sorcinelli 2018-12-08 0:52 ` Michele Sorcinelli 2018-12-08 0:56 ` [PATCH] dell-smm-hwmon.c: Additional " Michele Sorcinelli 2018-12-08 4:24 ` Guenter Roeck 2018-12-08 15:34 ` Michele Sorcinelli 2018-12-08 15:43 ` Michele Sorcinelli 2018-12-08 16:52 ` Guenter Roeck 2018-12-10 10:58 ` Pali Rohár 2018-12-10 11:53 ` Michele Sorcinelli 2018-12-10 12:03 ` Pali Rohár 2019-02-07 12:16 ` Michele Sorcinelli 2019-02-07 12:40 ` Pali Rohár 2019-04-21 17:00 ` Michele Sorcinelli 2019-06-14 21:38 ` Michele Sorcinelli 2018-12-08 17:02 ` [PATCH v2] " Michele Sorcinelli 2018-12-14 23:57 ` [PATCH v3] " Michele Sorcinelli 2018-12-21 23:40 ` Guenter Roeck 2018-12-22 12:50 ` Pali Rohár 2018-12-22 14:18 ` [PATCH v3.1] " Michele Sorcinelli 2018-12-23 22:59 ` Michele Sorcinelli 2018-12-24 1:16 ` Guenter Roeck 2018-11-30 15:44 [PATCH] dell-smm-hwmon.c: Add XPS 9570 to supported devices list Michele Sorcinelli 2018-11-30 15:49 ` Guenter Roeck 2018-11-30 18:17 ` Michele Sorcinelli 2018-11-30 18:42 ` Michele Sorcinelli 2018-12-01 18:31 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181127230637.8673-1-michelesr@autistici.org \ --to=michelesr@autistici.org \ --cc=jdelvare@suse.com \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=pali.rohar@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Hwmon Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \ linux-hwmon@vger.kernel.org public-inbox-index linux-hwmon Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon AGPL code for this site: git clone https://public-inbox.org/public-inbox.git