* [PATCH] hwmon: (nct6775) Fix register address and added missing tolerance
@ 2019-07-10 19:08 Björn Gerhart
2019-07-10 21:00 ` Guenter Roeck
2019-07-15 16:33 ` [PATCH] hwmon: (nct6775) Fix register address and added missed tolerance for nct6106 Björn Gerhart
0 siblings, 2 replies; 5+ messages in thread
From: Björn Gerhart @ 2019-07-10 19:08 UTC (permalink / raw)
To: Hardware Monitoring; +Cc: Guenter Roeck
In the process of adding the new model nct6116, two tiny details of the nct6106 attracted my attention. Please find the patch therefore below:
Index: nct6775.c
===================================================================
--- nct6775.c (revision 16326)
+++ nct6775.c (working copy)
@@ -866,7 +866,7 @@
static const u16 NCT6106_REG_WEIGHT_TEMP_SEL[] = { 0x168, 0x178, 0x188 };
static const u16 NCT6106_REG_WEIGHT_TEMP_STEP[] = { 0x169, 0x179, 0x189 };
static const u16 NCT6106_REG_WEIGHT_TEMP_STEP_TOL[] = { 0x16a, 0x17a, 0x18a };
-static const u16 NCT6106_REG_WEIGHT_DUTY_STEP[] = { 0x16b, 0x17b, 0x17c };
+static const u16 NCT6106_REG_WEIGHT_DUTY_STEP[] = { 0x16b, 0x17b, 0x18b };
static const u16 NCT6106_REG_WEIGHT_TEMP_BASE[] = { 0x16c, 0x17c, 0x18c };
static const u16 NCT6106_REG_WEIGHT_DUTY_BASE[] = { 0x16d, 0x17d, 0x18d };
@@ -3778,6 +3778,7 @@
data->REG_FAN_TIME[0] = NCT6106_REG_FAN_STOP_TIME;
data->REG_FAN_TIME[1] = NCT6106_REG_FAN_STEP_UP_TIME;
data->REG_FAN_TIME[2] = NCT6106_REG_FAN_STEP_DOWN_TIME;
+ data->REG_TOLERANCE_H = NCT6106_REG_TOLERANCE_H;
data->REG_PWM[0] = NCT6106_REG_PWM;
data->REG_PWM[1] = NCT6106_REG_FAN_START_OUTPUT;
data->REG_PWM[2] = NCT6106_REG_FAN_STOP_OUTPUT;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: (nct6775) Fix register address and added missing tolerance
2019-07-10 19:08 [PATCH] hwmon: (nct6775) Fix register address and added missing tolerance Björn Gerhart
@ 2019-07-10 21:00 ` Guenter Roeck
2019-07-15 16:33 ` [PATCH] hwmon: (nct6775) Fix register address and added missed tolerance for nct6106 Björn Gerhart
1 sibling, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2019-07-10 21:00 UTC (permalink / raw)
To: Björn Gerhart; +Cc: Hardware Monitoring
Hi Bjoern,
On Wed, Jul 10, 2019 at 09:08:56PM +0200, Björn Gerhart wrote:
> In the process of adding the new model nct6116, two tiny details of the nct6106 attracted my attention. Please find the patch therefore below:
>
Please sign your patches. Also, what is your baseline kernel version ?
The patch doesn't apply to the current mainline kernel.
Thanks,
Guenter
> Index: nct6775.c
> ===================================================================
> --- nct6775.c (revision 16326)
> +++ nct6775.c (working copy)
> @@ -866,7 +866,7 @@
> static const u16 NCT6106_REG_WEIGHT_TEMP_SEL[] = { 0x168, 0x178, 0x188 };
> static const u16 NCT6106_REG_WEIGHT_TEMP_STEP[] = { 0x169, 0x179, 0x189 };
> static const u16 NCT6106_REG_WEIGHT_TEMP_STEP_TOL[] = { 0x16a, 0x17a, 0x18a };
> -static const u16 NCT6106_REG_WEIGHT_DUTY_STEP[] = { 0x16b, 0x17b, 0x17c };
> +static const u16 NCT6106_REG_WEIGHT_DUTY_STEP[] = { 0x16b, 0x17b, 0x18b };
> static const u16 NCT6106_REG_WEIGHT_TEMP_BASE[] = { 0x16c, 0x17c, 0x18c };
> static const u16 NCT6106_REG_WEIGHT_DUTY_BASE[] = { 0x16d, 0x17d, 0x18d };
>
> @@ -3778,6 +3778,7 @@
> data->REG_FAN_TIME[0] = NCT6106_REG_FAN_STOP_TIME;
> data->REG_FAN_TIME[1] = NCT6106_REG_FAN_STEP_UP_TIME;
> data->REG_FAN_TIME[2] = NCT6106_REG_FAN_STEP_DOWN_TIME;
> + data->REG_TOLERANCE_H = NCT6106_REG_TOLERANCE_H;
> data->REG_PWM[0] = NCT6106_REG_PWM;
> data->REG_PWM[1] = NCT6106_REG_FAN_START_OUTPUT;
> data->REG_PWM[2] = NCT6106_REG_FAN_STOP_OUTPUT;
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] hwmon: (nct6775) Fix register address and added missed tolerance for nct6106
2019-07-10 19:08 [PATCH] hwmon: (nct6775) Fix register address and added missing tolerance Björn Gerhart
2019-07-10 21:00 ` Guenter Roeck
@ 2019-07-15 16:33 ` Björn Gerhart
2019-07-15 17:46 ` Guenter Roeck
1 sibling, 1 reply; 5+ messages in thread
From: Björn Gerhart @ 2019-07-15 16:33 UTC (permalink / raw)
To: Hardware Monitoring; +Cc: Guenter Roeck
Hi Guenter,
the patch was created against kernel 5.1.15. Is the corresponding „baseline“ 5.1 then?
- Fixed address of third NCT6106_REG_WEIGHT_DUTY_STEP
- added missed NCT6106_REG_TOLERANCE_H
Signed-off-by: Bjoern Gerhart <gerhart@posteo.de>
—
Index: nct6775.c
===================================================================
--- nct6775.c (revision 16326)
+++ nct6775.c (working copy)
@@ -866,7 +866,7 @@
static const u16 NCT6106_REG_WEIGHT_TEMP_SEL[] = { 0x168, 0x178, 0x188 };
static const u16 NCT6106_REG_WEIGHT_TEMP_STEP[] = { 0x169, 0x179, 0x189 };
static const u16 NCT6106_REG_WEIGHT_TEMP_STEP_TOL[] = { 0x16a, 0x17a, 0x18a };
-static const u16 NCT6106_REG_WEIGHT_DUTY_STEP[] = { 0x16b, 0x17b, 0x17c };
+static const u16 NCT6106_REG_WEIGHT_DUTY_STEP[] = { 0x16b, 0x17b, 0x18b };
static const u16 NCT6106_REG_WEIGHT_TEMP_BASE[] = { 0x16c, 0x17c, 0x18c };
static const u16 NCT6106_REG_WEIGHT_DUTY_BASE[] = { 0x16d, 0x17d, 0x18d };
@@ -3778,6 +3778,7 @@
data->REG_FAN_TIME[0] = NCT6106_REG_FAN_STOP_TIME;
data->REG_FAN_TIME[1] = NCT6106_REG_FAN_STEP_UP_TIME;
data->REG_FAN_TIME[2] = NCT6106_REG_FAN_STEP_DOWN_TIME;
+ data->REG_TOLERANCE_H = NCT6106_REG_TOLERANCE_H;
data->REG_PWM[0] = NCT6106_REG_PWM;
data->REG_PWM[1] = NCT6106_REG_FAN_START_OUTPUT;
data->REG_PWM[2] = NCT6106_REG_FAN_STOP_OUTPUT;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: (nct6775) Fix register address and added missed tolerance for nct6106
2019-07-15 16:33 ` [PATCH] hwmon: (nct6775) Fix register address and added missed tolerance for nct6106 Björn Gerhart
@ 2019-07-15 17:46 ` Guenter Roeck
2019-07-15 17:48 ` Guenter Roeck
0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2019-07-15 17:46 UTC (permalink / raw)
To: Björn Gerhart; +Cc: Hardware Monitoring
On Mon, Jul 15, 2019 at 06:33:55PM +0200, Björn Gerhart wrote:
> Hi Guenter,
>
> the patch was created against kernel 5.1.15. Is the corresponding „baseline“ 5.1 then?
>
The patch doesn't apply against v5.1.15 either. Do you have other
local changes to the same file in your branch ?
Thanks,
Guenter
> - Fixed address of third NCT6106_REG_WEIGHT_DUTY_STEP
> - added missed NCT6106_REG_TOLERANCE_H
>
> Signed-off-by: Bjoern Gerhart <gerhart@posteo.de>
> —
> Index: nct6775.c
> ===================================================================
> --- nct6775.c (revision 16326)
> +++ nct6775.c (working copy)
> @@ -866,7 +866,7 @@
> static const u16 NCT6106_REG_WEIGHT_TEMP_SEL[] = { 0x168, 0x178, 0x188 };
> static const u16 NCT6106_REG_WEIGHT_TEMP_STEP[] = { 0x169, 0x179, 0x189 };
> static const u16 NCT6106_REG_WEIGHT_TEMP_STEP_TOL[] = { 0x16a, 0x17a, 0x18a };
> -static const u16 NCT6106_REG_WEIGHT_DUTY_STEP[] = { 0x16b, 0x17b, 0x17c };
> +static const u16 NCT6106_REG_WEIGHT_DUTY_STEP[] = { 0x16b, 0x17b, 0x18b };
> static const u16 NCT6106_REG_WEIGHT_TEMP_BASE[] = { 0x16c, 0x17c, 0x18c };
> static const u16 NCT6106_REG_WEIGHT_DUTY_BASE[] = { 0x16d, 0x17d, 0x18d };
>
> @@ -3778,6 +3778,7 @@
> data->REG_FAN_TIME[0] = NCT6106_REG_FAN_STOP_TIME;
> data->REG_FAN_TIME[1] = NCT6106_REG_FAN_STEP_UP_TIME;
> data->REG_FAN_TIME[2] = NCT6106_REG_FAN_STEP_DOWN_TIME;
> + data->REG_TOLERANCE_H = NCT6106_REG_TOLERANCE_H;
> data->REG_PWM[0] = NCT6106_REG_PWM;
> data->REG_PWM[1] = NCT6106_REG_FAN_START_OUTPUT;
> data->REG_PWM[2] = NCT6106_REG_FAN_STOP_OUTPUT;
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: (nct6775) Fix register address and added missed tolerance for nct6106
2019-07-15 17:46 ` Guenter Roeck
@ 2019-07-15 17:48 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2019-07-15 17:48 UTC (permalink / raw)
To: Björn Gerhart; +Cc: Hardware Monitoring
On Mon, Jul 15, 2019 at 10:46:22AM -0700, Guenter Roeck wrote:
> On Mon, Jul 15, 2019 at 06:33:55PM +0200, Björn Gerhart wrote:
> > Hi Guenter,
> >
> > the patch was created against kernel 5.1.15. Is the corresponding „baseline“ 5.1 then?
> >
> The patch doesn't apply against v5.1.15 either. Do you have other
> local changes to the same file in your branch ?
>
Never mind - I had to adjust path names, then it worked.
Guenter
> Thanks,
> Guenter
>
> > - Fixed address of third NCT6106_REG_WEIGHT_DUTY_STEP
> > - added missed NCT6106_REG_TOLERANCE_H
> >
> > Signed-off-by: Bjoern Gerhart <gerhart@posteo.de>
> > —
> > Index: nct6775.c
> > ===================================================================
> > --- nct6775.c (revision 16326)
> > +++ nct6775.c (working copy)
> > @@ -866,7 +866,7 @@
> > static const u16 NCT6106_REG_WEIGHT_TEMP_SEL[] = { 0x168, 0x178, 0x188 };
> > static const u16 NCT6106_REG_WEIGHT_TEMP_STEP[] = { 0x169, 0x179, 0x189 };
> > static const u16 NCT6106_REG_WEIGHT_TEMP_STEP_TOL[] = { 0x16a, 0x17a, 0x18a };
> > -static const u16 NCT6106_REG_WEIGHT_DUTY_STEP[] = { 0x16b, 0x17b, 0x17c };
> > +static const u16 NCT6106_REG_WEIGHT_DUTY_STEP[] = { 0x16b, 0x17b, 0x18b };
> > static const u16 NCT6106_REG_WEIGHT_TEMP_BASE[] = { 0x16c, 0x17c, 0x18c };
> > static const u16 NCT6106_REG_WEIGHT_DUTY_BASE[] = { 0x16d, 0x17d, 0x18d };
> >
> > @@ -3778,6 +3778,7 @@
> > data->REG_FAN_TIME[0] = NCT6106_REG_FAN_STOP_TIME;
> > data->REG_FAN_TIME[1] = NCT6106_REG_FAN_STEP_UP_TIME;
> > data->REG_FAN_TIME[2] = NCT6106_REG_FAN_STEP_DOWN_TIME;
> > + data->REG_TOLERANCE_H = NCT6106_REG_TOLERANCE_H;
> > data->REG_PWM[0] = NCT6106_REG_PWM;
> > data->REG_PWM[1] = NCT6106_REG_FAN_START_OUTPUT;
> > data->REG_PWM[2] = NCT6106_REG_FAN_STOP_OUTPUT;
> >
> >
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-15 17:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-10 19:08 [PATCH] hwmon: (nct6775) Fix register address and added missing tolerance Björn Gerhart
2019-07-10 21:00 ` Guenter Roeck
2019-07-15 16:33 ` [PATCH] hwmon: (nct6775) Fix register address and added missed tolerance for nct6106 Björn Gerhart
2019-07-15 17:46 ` Guenter Roeck
2019-07-15 17:48 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).