From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Cormier, Jonathan" <jcormier@criticallink.com>,
linux-hwmon@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bob Duke <bduke@criticallink.com>,
John Pruitt <jpruitt@criticallink.com>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: adi,ltc2945: Add binding
Date: Thu, 15 Dec 2022 10:42:42 +0100 [thread overview]
Message-ID: <29f4e14f-a81a-d440-b564-5360f44c65c1@linaro.org> (raw)
In-Reply-To: <20221214220727.1350784-2-jcormier@criticallink.com>
On 14/12/2022 23:07, Cormier, Jonathan wrote:
Missing commit msg. Describe hardware.
> Signed-off-by: "Cormier, Jonathan" <jcormier@criticallink.com>
> ---
> .../bindings/hwmon/adi,ltc2945.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml
> new file mode 100644
> index 000000000000..9ca7a886dec8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/adi,ltc2945.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices LTC2945 wide range i2c power monitor
> +
> +maintainers:
> + - Guenter Roeck <linux@roeck-us.net>
> +
> +description: |
> + Analog Devices LTC2945 wide range i2c power monitor over I2C.
> +
> + https://www.analog.com/media/en/technical-documentation/data-sheets/LTC2945.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - ltc2945
That's not a correct compatible. Missing vendor prefix.
> +
> + reg:
> + maxItems: 1
> +
> + shunt-resistor-micro-ohms:
> + description:
> + Shunt resistor value in micro-Ohms
> + default: 1000
> +
> +required:
> + - compatible
> + - reg
> +
> +
Just one blank line.
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
Use 4 spaces for example indentation.
> +
> + ltc2945_i2c: ltc2945@6e {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "ltc2945";
> + reg = <0x6e>;
> + /* 10 milli-Ohm shunt resistor */
> + shunt-resistor-micro-ohms = <10000>;
> + };
> + };
> +...
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-15 9:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 22:07 [PATCH 0/2] hwmon: ltc2945: Add binding and shunt resistor support Cormier, Jonathan
2022-12-14 22:07 ` [PATCH 1/2] dt-bindings: hwmon: adi,ltc2945: Add binding Cormier, Jonathan
2022-12-15 9:42 ` Krzysztof Kozlowski [this message]
[not found] ` <CADL8D3ZUE5WbV0oS6hEVUNh9asrhTKQeGR4McR6Kh6qykSFw=Q@mail.gmail.com>
2022-12-15 14:37 ` Jon Cormier
2022-12-14 22:07 ` [PATCH 2/2] hwmon: ltc2945: Allow setting shunt resistor Cormier, Jonathan
2022-12-15 15:11 ` Guenter Roeck
2022-12-15 19:42 ` Jon Cormier
2023-01-09 23:35 ` [PATCH v3 0/2] hwmon: ltc2945: Add binding and shunt resistor support Jonathan Cormier
2023-01-09 23:35 ` [PATCH v3 1/5] dt-bindings: hwmon: adi,ltc2945: Add binding Jonathan Cormier
2023-01-10 9:07 ` Krzysztof Kozlowski
2023-01-09 23:35 ` [PATCH v3 2/5] hwmon: ltc2945: Add devicetree match table Jonathan Cormier
2023-01-09 23:35 ` [PATCH v3 3/5] hwmon: ltc2945: Handle error case in ltc2945_value_store Jonathan Cormier
2023-01-10 0:04 ` Guenter Roeck
2023-01-10 18:19 ` Jon Cormier
2023-01-10 18:22 ` Guenter Roeck
2023-01-10 19:25 ` Jon Cormier
2023-01-12 0:44 ` Guenter Roeck
2023-01-18 18:32 ` Jon Cormier
2023-01-09 23:35 ` [PATCH v3 4/5] hwmon: ltc2945: Allow setting shunt resistor Jonathan Cormier
2023-01-09 23:35 ` [PATCH v3 5/5] hwmon: ltc2945: Convert division to DIV_ROUND_CLOSEST_ULL Jonathan Cormier
2022-12-20 0:04 ` [PATCH v2 0/2] hwmon: ltc2945: Add binding and shunt resistor support Cormier, Jonathan
2022-12-20 0:04 ` [PATCH v2 1/4] dt-bindings: hwmon: adi,ltc2945: Add binding Cormier, Jonathan
2022-12-20 10:15 ` Krzysztof Kozlowski
2022-12-20 14:35 ` Jon Cormier
2022-12-20 14:46 ` Guenter Roeck
2022-12-20 21:47 ` Jon Cormier
2022-12-20 0:04 ` [PATCH v2 2/4] hwmon: ltc2945: Add devicetree match table Cormier, Jonathan
2022-12-28 16:43 ` Guenter Roeck
2022-12-20 0:04 ` [PATCH v2 3/4] hwmon: ltc2945: Allow setting shunt resistor Cormier, Jonathan
2022-12-28 16:49 ` Guenter Roeck
2022-12-20 0:04 ` [PATCH v2 4/4] hwmon: ltc2945: Fix possible overflows Cormier, Jonathan
2022-12-28 17:01 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29f4e14f-a81a-d440-b564-5360f44c65c1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bduke@criticallink.com \
--cc=devicetree@vger.kernel.org \
--cc=jcormier@criticallink.com \
--cc=jdelvare@suse.com \
--cc=jpruitt@criticallink.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).