* [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties
@ 2019-03-19 14:54 Robin Murphy
2019-03-19 15:00 ` Guenter Roeck
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Robin Murphy @ 2019-03-19 14:54 UTC (permalink / raw)
To: linux, jdelvare
Cc: kgene, krzk, shawnguo, s.hauer, thierry.reding, jonathanh, heiko,
linux-hwmon, devicetree, linux-arm-kernel, linux-pm
The old "cooling-{min,max}-state" properties for thermal bindings were
ratified to "cooling-{min,max}-level" by commit eb168b70dea5 ("of:
thermal: Fix inconsitency between cooling-*-state and cooling-*-level"),
which were later removed entirely by commit e04907dbc259 ("dt-bindings:
thermal: Remove "cooling-{min|max}-level" properties").
The pwm-fan binding, however, was apparently in-flight in parallel with
that ratification, and so managed to introduce an example of the old
properties which escaped the scope of the later cleanup and has thus
continued to be dutifully copied for new boards despite being useless.
Clean up these remaining undocumented anachronisms to minimise any
further confusion.
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
Presented as one big hwmon patch for simplicity, but the DT changes
can quite easily be broken out by platform if maintainers prefer.
Robin.
Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 2 --
arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 --
arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 --
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 --
arch/arm/boot/dts/imx6qdl-emcon.dtsi | 2 --
arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 2 --
arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi | 2 --
arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 2 --
8 files changed, 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
index 49ca5d83ed13..716e84f3bbb2 100644
--- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
+++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
@@ -12,8 +12,6 @@ Optional properties:
Example:
fan0: pwm-fan {
compatible = "pwm-fan";
- cooling-min-state = <0>;
- cooling-max-state = <3>;
#cooling-cells = <2>;
pwms = <&pwm 0 10000 0>;
cooling-levels = <0 102 170 230>;
diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index 2bdf899df436..6d400b01d9c9 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -34,8 +34,6 @@
fan0: pwm-fan {
compatible = "pwm-fan";
pwms = <&pwm 0 10000 0>;
- cooling-min-state = <0>;
- cooling-max-state = <3>;
#cooling-cells = <2>;
cooling-levels = <0 102 170 230>;
};
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index 434a7591ff63..8f9e08f940ab 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -38,8 +38,6 @@
fan0: pwm-fan {
compatible = "pwm-fan";
pwms = <&pwm 0 20972 0>;
- cooling-min-state = <0>;
- cooling-max-state = <3>;
#cooling-cells = <2>;
cooling-levels = <0 130 170 230>;
};
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index 5f195ad7e467..93a48f2dda49 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -44,8 +44,6 @@
fan0: pwm-fan {
compatible = "pwm-fan";
pwms = <&pwm 0 20972 0>;
- cooling-min-state = <0>;
- cooling-max-state = <3>;
#cooling-cells = <2>;
cooling-levels = <0 130 170 230>;
};
diff --git a/arch/arm/boot/dts/imx6qdl-emcon.dtsi b/arch/arm/boot/dts/imx6qdl-emcon.dtsi
index 397e205551c4..70d26616d771 100644
--- a/arch/arm/boot/dts/imx6qdl-emcon.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-emcon.dtsi
@@ -77,8 +77,6 @@
pwm_fan: pwm-fan {
compatible = "pwm-fan";
- cooling-min-state = <0>;
- cooling-max-state = <4>;
#cooling-cells = <2>;
pwms = <&pwm4 0 50000>;
cooling-levels = <0 64 127 191 255>;
diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
index b62e96945846..73801b48d1d8 100644
--- a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
@@ -57,8 +57,6 @@
pwms = <&pwm4 0 45334>;
cooling-levels = <0 64 128 255>;
- cooling-min-state = <0>;
- cooling-max-state = <3>;
#cooling-cells = <2>;
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
index 1b35d612b660..cc35c88dafd9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
@@ -56,8 +56,6 @@
fan: fan@18 {
compatible = "ti,amc6821";
reg = <0x18>;
- cooling-min-state = <0>;
- cooling-max-state = <9>;
#cooling-cells = <2>;
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
index 0130b9f98c9d..490be7a6a851 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
@@ -369,8 +369,6 @@
fan: fan@18 {
compatible = "ti,amc6821";
reg = <0x18>;
- cooling-min-state = <0>;
- cooling-max-state = <9>;
#cooling-cells = <2>;
};
--
2.20.1.dirty
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties
2019-03-19 14:54 [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties Robin Murphy
@ 2019-03-19 15:00 ` Guenter Roeck
2019-03-19 15:06 ` Krzysztof Kozlowski
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2019-03-19 15:00 UTC (permalink / raw)
To: Robin Murphy
Cc: jdelvare, kgene, krzk, shawnguo, s.hauer, thierry.reding,
jonathanh, heiko, linux-hwmon, devicetree, linux-arm-kernel,
linux-pm
On Tue, Mar 19, 2019 at 02:54:04PM +0000, Robin Murphy wrote:
> The old "cooling-{min,max}-state" properties for thermal bindings were
> ratified to "cooling-{min,max}-level" by commit eb168b70dea5 ("of:
> thermal: Fix inconsitency between cooling-*-state and cooling-*-level"),
> which were later removed entirely by commit e04907dbc259 ("dt-bindings:
> thermal: Remove "cooling-{min|max}-level" properties").
>
> The pwm-fan binding, however, was apparently in-flight in parallel with
> that ratification, and so managed to introduce an example of the old
> properties which escaped the scope of the later cleanup and has thus
> continued to be dutifully copied for new boards despite being useless.
> Clean up these remaining undocumented anachronisms to minimise any
> further confusion.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
For hwmon: Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> Presented as one big hwmon patch for simplicity, but the DT changes
> can quite easily be broken out by platform if maintainers prefer.
>
> Robin.
>
> Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 2 --
> arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 --
> arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 --
> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 --
> arch/arm/boot/dts/imx6qdl-emcon.dtsi | 2 --
> arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 2 --
> arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi | 2 --
> arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 2 --
> 8 files changed, 16 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> index 49ca5d83ed13..716e84f3bbb2 100644
> --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> @@ -12,8 +12,6 @@ Optional properties:
> Example:
> fan0: pwm-fan {
> compatible = "pwm-fan";
> - cooling-min-state = <0>;
> - cooling-max-state = <3>;
> #cooling-cells = <2>;
> pwms = <&pwm 0 10000 0>;
> cooling-levels = <0 102 170 230>;
> diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
> index 2bdf899df436..6d400b01d9c9 100644
> --- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
> +++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
> @@ -34,8 +34,6 @@
> fan0: pwm-fan {
> compatible = "pwm-fan";
> pwms = <&pwm 0 10000 0>;
> - cooling-min-state = <0>;
> - cooling-max-state = <3>;
> #cooling-cells = <2>;
> cooling-levels = <0 102 170 230>;
> };
> diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> index 434a7591ff63..8f9e08f940ab 100644
> --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
> +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> @@ -38,8 +38,6 @@
> fan0: pwm-fan {
> compatible = "pwm-fan";
> pwms = <&pwm 0 20972 0>;
> - cooling-min-state = <0>;
> - cooling-max-state = <3>;
> #cooling-cells = <2>;
> cooling-levels = <0 130 170 230>;
> };
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> index 5f195ad7e467..93a48f2dda49 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> @@ -44,8 +44,6 @@
> fan0: pwm-fan {
> compatible = "pwm-fan";
> pwms = <&pwm 0 20972 0>;
> - cooling-min-state = <0>;
> - cooling-max-state = <3>;
> #cooling-cells = <2>;
> cooling-levels = <0 130 170 230>;
> };
> diff --git a/arch/arm/boot/dts/imx6qdl-emcon.dtsi b/arch/arm/boot/dts/imx6qdl-emcon.dtsi
> index 397e205551c4..70d26616d771 100644
> --- a/arch/arm/boot/dts/imx6qdl-emcon.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-emcon.dtsi
> @@ -77,8 +77,6 @@
>
> pwm_fan: pwm-fan {
> compatible = "pwm-fan";
> - cooling-min-state = <0>;
> - cooling-max-state = <4>;
> #cooling-cells = <2>;
> pwms = <&pwm4 0 50000>;
> cooling-levels = <0 64 127 191 255>;
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
> index b62e96945846..73801b48d1d8 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
> @@ -57,8 +57,6 @@
> pwms = <&pwm4 0 45334>;
>
> cooling-levels = <0 64 128 255>;
> - cooling-min-state = <0>;
> - cooling-max-state = <3>;
> #cooling-cells = <2>;
> };
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
> index 1b35d612b660..cc35c88dafd9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
> @@ -56,8 +56,6 @@
> fan: fan@18 {
> compatible = "ti,amc6821";
> reg = <0x18>;
> - cooling-min-state = <0>;
> - cooling-max-state = <9>;
> #cooling-cells = <2>;
> };
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
> index 0130b9f98c9d..490be7a6a851 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
> @@ -369,8 +369,6 @@
> fan: fan@18 {
> compatible = "ti,amc6821";
> reg = <0x18>;
> - cooling-min-state = <0>;
> - cooling-max-state = <9>;
> #cooling-cells = <2>;
> };
>
> --
> 2.20.1.dirty
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties
2019-03-19 14:54 [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties Robin Murphy
2019-03-19 15:00 ` Guenter Roeck
@ 2019-03-19 15:06 ` Krzysztof Kozlowski
2019-03-27 16:17 ` Robin Murphy
2019-03-19 15:14 ` Thierry Reding
` (3 subsequent siblings)
5 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2019-03-19 15:06 UTC (permalink / raw)
To: Robin Murphy
Cc: linux, jdelvare, kgene, shawnguo, s.hauer, thierry.reding,
jonathanh, heiko, linux-hwmon, devicetree, linux-arm-kernel,
linux-pm
On Tue, 19 Mar 2019 at 15:54, Robin Murphy <robin.murphy@arm.com> wrote:
>
> The old "cooling-{min,max}-state" properties for thermal bindings were
> ratified to "cooling-{min,max}-level" by commit eb168b70dea5 ("of:
> thermal: Fix inconsitency between cooling-*-state and cooling-*-level"),
> which were later removed entirely by commit e04907dbc259 ("dt-bindings:
> thermal: Remove "cooling-{min|max}-level" properties").
>
> The pwm-fan binding, however, was apparently in-flight in parallel with
> that ratification, and so managed to introduce an example of the old
> properties which escaped the scope of the later cleanup and has thus
> continued to be dutifully copied for new boards despite being useless.
> Clean up these remaining undocumented anachronisms to minimise any
> further confusion.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>
> Presented as one big hwmon patch for simplicity, but the DT changes
> can quite easily be broken out by platform if maintainers prefer.
>
> Robin.
>
> Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 2 --
> arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 --
> arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 --
> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 --
Probably you should send it directly to arm-soc maintainers so it
would go with other DT changes. In such case:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
> arch/arm/boot/dts/imx6qdl-emcon.dtsi | 2 --
> arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 2 --
> arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi | 2 --
> arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 2 --
> 8 files changed, 16 deletions(-)
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties
2019-03-19 14:54 [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties Robin Murphy
2019-03-19 15:00 ` Guenter Roeck
2019-03-19 15:06 ` Krzysztof Kozlowski
@ 2019-03-19 15:14 ` Thierry Reding
2019-03-19 15:27 ` Heiko Stübner
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2019-03-19 15:14 UTC (permalink / raw)
To: Robin Murphy
Cc: linux, jdelvare, kgene, krzk, shawnguo, s.hauer, jonathanh,
heiko, linux-hwmon, devicetree, linux-arm-kernel, linux-pm
[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]
On Tue, Mar 19, 2019 at 02:54:04PM +0000, Robin Murphy wrote:
> The old "cooling-{min,max}-state" properties for thermal bindings were
> ratified to "cooling-{min,max}-level" by commit eb168b70dea5 ("of:
> thermal: Fix inconsitency between cooling-*-state and cooling-*-level"),
> which were later removed entirely by commit e04907dbc259 ("dt-bindings:
> thermal: Remove "cooling-{min|max}-level" properties").
>
> The pwm-fan binding, however, was apparently in-flight in parallel with
> that ratification, and so managed to introduce an example of the old
> properties which escaped the scope of the later cleanup and has thus
> continued to be dutifully copied for new boards despite being useless.
> Clean up these remaining undocumented anachronisms to minimise any
> further confusion.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>
> Presented as one big hwmon patch for simplicity, but the DT changes
> can quite easily be broken out by platform if maintainers prefer.
>
> Robin.
>
> Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 2 --
> arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 --
> arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 --
> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 --
> arch/arm/boot/dts/imx6qdl-emcon.dtsi | 2 --
> arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 2 --
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties
2019-03-19 14:54 [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties Robin Murphy
` (2 preceding siblings ...)
2019-03-19 15:14 ` Thierry Reding
@ 2019-03-19 15:27 ` Heiko Stübner
2019-03-22 0:46 ` Shawn Guo
2019-03-31 6:40 ` Rob Herring
5 siblings, 0 replies; 8+ messages in thread
From: Heiko Stübner @ 2019-03-19 15:27 UTC (permalink / raw)
To: Robin Murphy
Cc: linux, jdelvare, kgene, krzk, shawnguo, s.hauer, thierry.reding,
jonathanh, linux-hwmon, devicetree, linux-arm-kernel, linux-pm
Am Dienstag, 19. März 2019, 15:54:04 CET schrieb Robin Murphy:
> The old "cooling-{min,max}-state" properties for thermal bindings were
> ratified to "cooling-{min,max}-level" by commit eb168b70dea5 ("of:
> thermal: Fix inconsitency between cooling-*-state and cooling-*-level"),
> which were later removed entirely by commit e04907dbc259 ("dt-bindings:
> thermal: Remove "cooling-{min|max}-level" properties").
>
> The pwm-fan binding, however, was apparently in-flight in parallel with
> that ratification, and so managed to introduce an example of the old
> properties which escaped the scope of the later cleanup and has thus
> continued to be dutifully copied for new boards despite being useless.
> Clean up these remaining undocumented anachronisms to minimise any
> further confusion.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>
> Presented as one big hwmon patch for simplicity, but the DT changes
> can quite easily be broken out by platform if maintainers prefer.
For the Rockchip-parts
Acked-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties
2019-03-19 14:54 [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties Robin Murphy
` (3 preceding siblings ...)
2019-03-19 15:27 ` Heiko Stübner
@ 2019-03-22 0:46 ` Shawn Guo
2019-03-31 6:40 ` Rob Herring
5 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2019-03-22 0:46 UTC (permalink / raw)
To: Robin Murphy
Cc: linux, jdelvare, kgene, krzk, s.hauer, thierry.reding, jonathanh,
heiko, linux-hwmon, devicetree, linux-arm-kernel, linux-pm
On Tue, Mar 19, 2019 at 02:54:04PM +0000, Robin Murphy wrote:
> The old "cooling-{min,max}-state" properties for thermal bindings were
> ratified to "cooling-{min,max}-level" by commit eb168b70dea5 ("of:
> thermal: Fix inconsitency between cooling-*-state and cooling-*-level"),
> which were later removed entirely by commit e04907dbc259 ("dt-bindings:
> thermal: Remove "cooling-{min|max}-level" properties").
>
> The pwm-fan binding, however, was apparently in-flight in parallel with
> that ratification, and so managed to introduce an example of the old
> properties which escaped the scope of the later cleanup and has thus
> continued to be dutifully copied for new boards despite being useless.
> Clean up these remaining undocumented anachronisms to minimise any
> further confusion.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>
> Presented as one big hwmon patch for simplicity, but the DT changes
> can quite easily be broken out by platform if maintainers prefer.
>
> Robin.
>
> Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 2 --
> arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 --
> arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 --
> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 --
> arch/arm/boot/dts/imx6qdl-emcon.dtsi | 2 --
Acked-by: Shawn Guo <shawnguo@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties
2019-03-19 15:06 ` Krzysztof Kozlowski
@ 2019-03-27 16:17 ` Robin Murphy
0 siblings, 0 replies; 8+ messages in thread
From: Robin Murphy @ 2019-03-27 16:17 UTC (permalink / raw)
To: arnd, olof
Cc: Krzysztof Kozlowski, linux, jdelvare, kgene, shawnguo, s.hauer,
thierry.reding, jonathanh, heiko, linux-hwmon, devicetree,
linux-arm-kernel, linux-pm
[ +Arnd, Olof ]
On 19/03/2019 15:06, Krzysztof Kozlowski wrote:
> On Tue, 19 Mar 2019 at 15:54, Robin Murphy <robin.murphy@arm.com> wrote:
>>
>> The old "cooling-{min,max}-state" properties for thermal bindings were
>> ratified to "cooling-{min,max}-level" by commit eb168b70dea5 ("of:
>> thermal: Fix inconsitency between cooling-*-state and cooling-*-level"),
>> which were later removed entirely by commit e04907dbc259 ("dt-bindings:
>> thermal: Remove "cooling-{min|max}-level" properties").
>>
>> The pwm-fan binding, however, was apparently in-flight in parallel with
>> that ratification, and so managed to introduce an example of the old
>> properties which escaped the scope of the later cleanup and has thus
>> continued to be dutifully copied for new boards despite being useless.
>> Clean up these remaining undocumented anachronisms to minimise any
>> further confusion.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>> ---
>>
>> Presented as one big hwmon patch for simplicity, but the DT changes
>> can quite easily be broken out by platform if maintainers prefer.
>>
>> Robin.
>>
>> Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 2 --
>> arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 --
>> arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 --
>> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 --
>
> Probably you should send it directly to arm-soc maintainers so it
> would go with other DT changes. In such case:
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Indeed, it had crossed my mind that routing this through arm-soc might
make sense - Arnd, Olof, would you agree? And if so, should I resend to
the arm-soc alias or might you be able to pick it directly?
Thanks to everyone for the acks!
Robin.
>
> Best regards,
> Krzysztof
>
>> arch/arm/boot/dts/imx6qdl-emcon.dtsi | 2 --
>> arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 2 --
>> arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi | 2 --
>> arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 2 --
>> 8 files changed, 16 deletions(-)
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties
2019-03-19 14:54 [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties Robin Murphy
` (4 preceding siblings ...)
2019-03-22 0:46 ` Shawn Guo
@ 2019-03-31 6:40 ` Rob Herring
5 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2019-03-31 6:40 UTC (permalink / raw)
To: Robin Murphy
Cc: linux, jdelvare, linux-hwmon, devicetree, heiko, linux-pm,
s.hauer, krzk, jonathanh, thierry.reding, kgene, shawnguo,
linux-arm-kernel
On Tue, 19 Mar 2019 14:54:04 +0000, Robin Murphy wrote:
> The old "cooling-{min,max}-state" properties for thermal bindings were
> ratified to "cooling-{min,max}-level" by commit eb168b70dea5 ("of:
> thermal: Fix inconsitency between cooling-*-state and cooling-*-level"),
> which were later removed entirely by commit e04907dbc259 ("dt-bindings:
> thermal: Remove "cooling-{min|max}-level" properties").
>
> The pwm-fan binding, however, was apparently in-flight in parallel with
> that ratification, and so managed to introduce an example of the old
> properties which escaped the scope of the later cleanup and has thus
> continued to be dutifully copied for new boards despite being useless.
> Clean up these remaining undocumented anachronisms to minimise any
> further confusion.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>
> Presented as one big hwmon patch for simplicity, but the DT changes
> can quite easily be broken out by platform if maintainers prefer.
>
> Robin.
>
> Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 2 --
> arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 --
> arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 --
> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 --
> arch/arm/boot/dts/imx6qdl-emcon.dtsi | 2 --
> arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 2 --
> arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi | 2 --
> arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 2 --
> 8 files changed, 16 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-03-31 6:41 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 14:54 [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties Robin Murphy
2019-03-19 15:00 ` Guenter Roeck
2019-03-19 15:06 ` Krzysztof Kozlowski
2019-03-27 16:17 ` Robin Murphy
2019-03-19 15:14 ` Thierry Reding
2019-03-19 15:27 ` Heiko Stübner
2019-03-22 0:46 ` Shawn Guo
2019-03-31 6:40 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).