Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
From: Marcel Bocu <marcel.p.bocu@gmail.com>
To: Vicki Pfau <vi@endrift.com>
Cc: "Woods, Brian" <Brian.Woods@amd.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	Clemens Ladisch <clemens@ladisch.de>,
	Jean Delvare <jdelvare@suse.com>,
	"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 71h
Date: Tue, 23 Jul 2019 00:09:16 +0300
Message-ID: <5da85f6d-e886-6af8-527c-e5edd9420825@gmail.com> (raw)
In-Reply-To: <9E38F05F-8906-42F8-AB63-EEF2F2DBAD57@endrift.com>

On 22/07/2019 21:11, Vicki Pfau wrote:
> I'm getting similar variance. Compiling Linux seems to spike the temperature above 70, even with a new CPU cooler, so I'm wondering if there might be an offset I'm missing. It may just be the fan being too slow (going to be reconfiguring the BIOS settings today).

Thanks for the information! Compiling the kernel gets me to 83°C with
the stock fan (Ryzen 3700X), and I think I get thermally throttled at
this point.

> 
> The reason I haven't replied sooner is because I've been busy with a new job, and I wasn't sure if my phone would send a properly (un)formatted email. 

I see! No worries, and good luck with your new job!

> I'm fine with whosever patch gets in, so long as temperature reading works on my machine.

Given that our patches were looking exactly the same, it's safe to
assume it will be fine.

> 
> Also, for what it's worth, I'm not a "he". Vicki is generally a female name.

I did not know this. Sorry for assuming your gender, and thanks for
correcting me!

Marcel

> 
> Vicki
> 
>>> On Jul 22, 2019, at 11:04 AM, Marcel Bocu <marcel.p.bocu@gmail.com> wrote:
>>>
>>>> On 22/07/2019 20:39, Woods, Brian wrote:
>>>> On Mon, Jul 22, 2019 at 09:51:05AM -0700, Guenter Roeck wrote:
>>>>
>>>> With 3900X, and the series applied, I get:
>>>>
>>>> k10temp-pci-00c3
>>>> Adapter: PCI adapter
>>>> Tdie:         +45.1°C  (high = +70.0°C)
>>>> Tctl:         +45.1°C  
>>>>
>>>> which looks about right.
>>>>
>>>> Interesting, though. I thought there are two CPU dies on this chip.
>>>> I guess the temperature sensor is on the IO block ? If so, are there
>>>> additional sensors on the CPU dies ?
>>>>
>>>> Guenter
>>>
>>> That's good to know.  Thanks for testing it.
>>>
>>> What happens is the IOD takes the max temperature of the chiplets in the
>>> package and presents that as the temperature of the package.  It works
>>> the same way as it does in Rome (server parts).  For better or worse,
>>> you just get the max temperature of the chiplets rather than the
>>> temperatures of the individual chiplets.
>>
>> Out of curiosity, is it the maximum temperature of all chiplets, or just
>> the non-powergated ones? Because this might explain why I get so much
>> variance in the idle temperature (40 <-> 50°C in a matter of a second
>> with a mostly-idle processor). This variance is visible on linux, but
>> not at all on the firmware's configuration interface.
>>
>> One other option would be the stock fan not being tight-enough... but
>> apparently quite a few people have the issue. I'll try tightening it!
>>
>> Marcel
> 


  reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18 18:26 Marcel Bocu
2019-07-18 18:26 ` [PATCH 2/2] hwmon/k10temp: Add support for AMD family 17h, model 71h CPUs Marcel Bocu
2019-07-22 17:46   ` [PATCH v2 2/2] hwmon/k10temp: Add support for AMD family 17h, model 70h CPUs Marcel Bocu
2019-07-22 18:23     ` Guenter Roeck
2019-07-22 21:12       ` Marcel Bocu
     [not found] ` <20190718193330.GA23809@roeck-us.net>
2019-07-19  7:40   ` [PATCH 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 71h Marcel Bocu
2019-07-19 13:27     ` Guenter Roeck
2019-07-19 15:30       ` Marcel Bocu
2019-07-19 16:08         ` Guenter Roeck
2019-07-22  8:59           ` Thomas Gleixner
2019-07-22  9:12             ` Borislav Petkov
2019-07-22 16:04               ` Woods, Brian
2019-07-22 16:51                 ` Guenter Roeck
2019-07-22 17:39                   ` Woods, Brian
2019-07-22 18:04                     ` Marcel Bocu
2019-07-22 18:11                       ` Vicki Pfau
2019-07-22 21:09                         ` Marcel Bocu [this message]
2019-07-22 22:01                           ` Guenter Roeck
2019-07-22 17:45 ` [PATCH v2 1/2] x86/amd_nb: Add PCI device IDs for family 17h, model 70h Marcel Bocu

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5da85f6d-e886-6af8-527c-e5edd9420825@gmail.com \
    --to=marcel.p.bocu@gmail.com \
    --cc=Brian.Woods@amd.com \
    --cc=bp@alien8.de \
    --cc=clemens@ladisch.de \
    --cc=hpa@zytor.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vi@endrift.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org
	public-inbox-index linux-hwmon

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git