* [PATCH] i2c: sprd:: depend on COMMON_CLK to fix compile tests
@ 2021-01-17 11:43 Krzysztof Kozlowski
2021-01-20 6:19 ` Baolin Wang
2021-01-22 9:05 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-01-17 11:43 UTC (permalink / raw)
To: Orson Zhai, Baolin Wang, Chunyan Zhang, Wolfram Sang, linux-i2c,
linux-kernel
Cc: Krzysztof Kozlowski, kernel test robot
The I2C_SPRD uses Common Clock Framework thus it cannot be built on
platforms without it (e.g. compile test on MIPS with LANTIQ):
/usr/bin/mips-linux-gnu-ld: drivers/i2c/busses/i2c-sprd.o: in function `sprd_i2c_probe':
i2c-sprd.c:(.text.sprd_i2c_probe+0x254): undefined reference to `clk_set_parent'
Fixes: 4a2d5f663dab ("i2c: Enable compile testing for more drivers")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index d4d60ad0eda0..ab1f39ac39f4 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -1013,6 +1013,7 @@ config I2C_SIRF
config I2C_SPRD
tristate "Spreadtrum I2C interface"
depends on I2C=y && (ARCH_SPRD || COMPILE_TEST)
+ depends on COMMON_CLK
help
If you say yes to this option, support will be included for the
Spreadtrum I2C interface.
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: sprd:: depend on COMMON_CLK to fix compile tests
2021-01-17 11:43 [PATCH] i2c: sprd:: depend on COMMON_CLK to fix compile tests Krzysztof Kozlowski
@ 2021-01-20 6:19 ` Baolin Wang
2021-01-22 9:05 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Baolin Wang @ 2021-01-20 6:19 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Orson Zhai, Chunyan Zhang, Wolfram Sang, linux-i2c, LKML,
kernel test robot
Hi,
On Sun, Jan 17, 2021 at 7:43 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The I2C_SPRD uses Common Clock Framework thus it cannot be built on
> platforms without it (e.g. compile test on MIPS with LANTIQ):
>
> /usr/bin/mips-linux-gnu-ld: drivers/i2c/busses/i2c-sprd.o: in function `sprd_i2c_probe':
> i2c-sprd.c:(.text.sprd_i2c_probe+0x254): undefined reference to `clk_set_parent'
>
> Fixes: 4a2d5f663dab ("i2c: Enable compile testing for more drivers")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
> ---
> drivers/i2c/busses/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index d4d60ad0eda0..ab1f39ac39f4 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -1013,6 +1013,7 @@ config I2C_SIRF
> config I2C_SPRD
> tristate "Spreadtrum I2C interface"
> depends on I2C=y && (ARCH_SPRD || COMPILE_TEST)
> + depends on COMMON_CLK
> help
> If you say yes to this option, support will be included for the
> Spreadtrum I2C interface.
> --
> 2.25.1
>
--
Baolin Wang
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: sprd:: depend on COMMON_CLK to fix compile tests
2021-01-17 11:43 [PATCH] i2c: sprd:: depend on COMMON_CLK to fix compile tests Krzysztof Kozlowski
2021-01-20 6:19 ` Baolin Wang
@ 2021-01-22 9:05 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2021-01-22 9:05 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Orson Zhai, Baolin Wang, Chunyan Zhang, linux-i2c, linux-kernel,
kernel test robot
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
On Sun, Jan 17, 2021 at 12:43:13PM +0100, Krzysztof Kozlowski wrote:
> The I2C_SPRD uses Common Clock Framework thus it cannot be built on
> platforms without it (e.g. compile test on MIPS with LANTIQ):
>
> /usr/bin/mips-linux-gnu-ld: drivers/i2c/busses/i2c-sprd.o: in function `sprd_i2c_probe':
> i2c-sprd.c:(.text.sprd_i2c_probe+0x254): undefined reference to `clk_set_parent'
>
> Fixes: 4a2d5f663dab ("i2c: Enable compile testing for more drivers")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Fixed the "::" in $subject ad applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-22 12:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-17 11:43 [PATCH] i2c: sprd:: depend on COMMON_CLK to fix compile tests Krzysztof Kozlowski
2021-01-20 6:19 ` Baolin Wang
2021-01-22 9:05 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).