* [PATCH] i2c: i801: Add support for Intel Alder Lake PCH-P
@ 2021-01-14 14:38 Jarkko Nikula
2021-01-28 8:59 ` Wolfram Sang
0 siblings, 1 reply; 5+ messages in thread
From: Jarkko Nikula @ 2021-01-14 14:38 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Jean Delvare, Jarkko Nikula
Add PCI ID of SMBus controller on Intel Alder Lake PCH-P.
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
drivers/i2c/busses/i2c-i801.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index 4435e5fdc75e..b931b629b457 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -73,6 +73,7 @@
* Jasper Lake (SOC) 0x4da3 32 hard yes yes yes
* Comet Lake-V (PCH) 0xa3a3 32 hard yes yes yes
* Alder Lake-S (PCH) 0x7aa3 32 hard yes yes yes
+ * Alder Lake-P (PCH) 0x51a3 32 hard yes yes yes
*
* Features supported by this driver:
* Software PEC no
@@ -230,6 +231,7 @@
#define PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS 0x43a3
#define PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS 0x4b23
#define PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS 0x4da3
+#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS 0x51a3
#define PCI_DEVICE_ID_INTEL_BROXTON_SMBUS 0x5ad4
#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS 0x7aa3
#define PCI_DEVICE_ID_INTEL_LYNXPOINT_SMBUS 0x8c22
@@ -1087,6 +1089,7 @@ static const struct pci_device_id i801_ids[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS) },
+ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS) },
{ 0, }
};
@@ -1776,6 +1779,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
case PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS:
case PCI_DEVICE_ID_INTEL_EBG_SMBUS:
case PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS:
+ case PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS:
priv->features |= FEATURE_BLOCK_PROC;
priv->features |= FEATURE_I2C_BLOCK_READ;
priv->features |= FEATURE_IRQ;
--
2.29.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] i2c: i801: Add support for Intel Alder Lake PCH-P
2021-01-14 14:38 [PATCH] i2c: i801: Add support for Intel Alder Lake PCH-P Jarkko Nikula
@ 2021-01-28 8:59 ` Wolfram Sang
2021-02-01 14:02 ` Jarkko Nikula
0 siblings, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2021-01-28 8:59 UTC (permalink / raw)
To: Jarkko Nikula, Jean Delvare; +Cc: linux-i2c
[-- Attachment #1: Type: text/plain, Size: 2248 bytes --]
On Thu, Jan 14, 2021 at 04:38:11PM +0200, Jarkko Nikula wrote:
> Add PCI ID of SMBus controller on Intel Alder Lake PCH-P.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Do we still update Documentation/i2c/busses/i2c-i801.rst?
And maybe we should add Jarkko as i801 maintainer because Jean is usually
fine with such changes?
> ---
> drivers/i2c/busses/i2c-i801.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index 4435e5fdc75e..b931b629b457 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -73,6 +73,7 @@
> * Jasper Lake (SOC) 0x4da3 32 hard yes yes yes
> * Comet Lake-V (PCH) 0xa3a3 32 hard yes yes yes
> * Alder Lake-S (PCH) 0x7aa3 32 hard yes yes yes
> + * Alder Lake-P (PCH) 0x51a3 32 hard yes yes yes
> *
> * Features supported by this driver:
> * Software PEC no
> @@ -230,6 +231,7 @@
> #define PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS 0x43a3
> #define PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS 0x4b23
> #define PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS 0x4da3
> +#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS 0x51a3
> #define PCI_DEVICE_ID_INTEL_BROXTON_SMBUS 0x5ad4
> #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS 0x7aa3
> #define PCI_DEVICE_ID_INTEL_LYNXPOINT_SMBUS 0x8c22
> @@ -1087,6 +1089,7 @@ static const struct pci_device_id i801_ids[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS) },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS) },
> { 0, }
> };
>
> @@ -1776,6 +1779,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
> case PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS:
> case PCI_DEVICE_ID_INTEL_EBG_SMBUS:
> case PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS:
> + case PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS:
> priv->features |= FEATURE_BLOCK_PROC;
> priv->features |= FEATURE_I2C_BLOCK_READ;
> priv->features |= FEATURE_IRQ;
> --
> 2.29.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] i2c: i801: Add support for Intel Alder Lake PCH-P
2021-01-28 8:59 ` Wolfram Sang
@ 2021-02-01 14:02 ` Jarkko Nikula
2021-02-09 10:45 ` Wolfram Sang
0 siblings, 1 reply; 5+ messages in thread
From: Jarkko Nikula @ 2021-02-01 14:02 UTC (permalink / raw)
To: Wolfram Sang, Jean Delvare; +Cc: linux-i2c
On 1/28/21 10:59 AM, Wolfram Sang wrote:
> On Thu, Jan 14, 2021 at 04:38:11PM +0200, Jarkko Nikula wrote:
>> Add PCI ID of SMBus controller on Intel Alder Lake PCH-P.
>>
>> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
>
> Do we still update Documentation/i2c/busses/i2c-i801.rst?
>
Actually need to avoid patching it and Kconfig for each new chipset
variant and make them shorter was my motivation behind commit
80d943ab19e9 ("i2c: i801: Consolidate chipset names in documentation and
Kconfig").
Here Alder Lake name was added by the commit 332fdaebb64e ("i2c: i801:
Add support for Intel Alder Lake PCH-S").
> And maybe we should add Jarkko as i801 maintainer because Jean is usually
> fine with such changes?
>
I'm not sure am I up to the task? Meaning I don't feel I know it so
well. I've been mostly adding new PCI IDs to new platforms.
Jarkko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] i2c: i801: Add support for Intel Alder Lake PCH-P
2021-02-01 14:02 ` Jarkko Nikula
@ 2021-02-09 10:45 ` Wolfram Sang
2021-02-26 16:35 ` Jean Delvare
0 siblings, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2021-02-09 10:45 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: Jean Delvare, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
> Actually need to avoid patching it and Kconfig for each new chipset variant
> and make them shorter was my motivation behind commit 80d943ab19e9 ("i2c:
> i801: Consolidate chipset names in documentation and Kconfig").
OK, I'll try to remember next time ;)
> > And maybe we should add Jarkko as i801 maintainer because Jean is usually
> > fine with such changes?
> >
> I'm not sure am I up to the task? Meaning I don't feel I know it so well.
> I've been mostly adding new PCI IDs to new platforms.
OK, I was just asking. Jean seems to be MIA, so:
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] i2c: i801: Add support for Intel Alder Lake PCH-P
2021-02-09 10:45 ` Wolfram Sang
@ 2021-02-26 16:35 ` Jean Delvare
0 siblings, 0 replies; 5+ messages in thread
From: Jean Delvare @ 2021-02-26 16:35 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Jarkko Nikula, linux-i2c
On Tue, 9 Feb 2021 11:45:17 +0100, Wolfram Sang wrote:
> > Actually need to avoid patching it and Kconfig for each new chipset variant
> > and make them shorter was my motivation behind commit 80d943ab19e9 ("i2c:
> > i801: Consolidate chipset names in documentation and Kconfig").
>
> OK, I'll try to remember next time ;)
>
> > > And maybe we should add Jarkko as i801 maintainer because Jean is usually
> > > fine with such changes?
> > >
> > I'm not sure am I up to the task? Meaning I don't feel I know it so well.
> > I've been mostly adding new PCI IDs to new platforms.
>
> OK, I was just asking. Jean seems to be MIA, so:
>
> Applied to for-next, thanks!
Sorry, I somehow missed this thread. Looks all good to me, thanks
Jarkko and Wolfram.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-26 16:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-14 14:38 [PATCH] i2c: i801: Add support for Intel Alder Lake PCH-P Jarkko Nikula
2021-01-28 8:59 ` Wolfram Sang
2021-02-01 14:02 ` Jarkko Nikula
2021-02-09 10:45 ` Wolfram Sang
2021-02-26 16:35 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).