From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Vitor Soares <vitor.soares@synopsys.com>,
Boris Brezillon <bbrezillon@kernel.org>
Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] i3c: master: dw-i3c-master: mark expected switch fall-through
Date: Tue, 26 Feb 2019 21:53:16 -0600 [thread overview]
Message-ID: <87e0a8c9-82f6-3f41-bdb6-162a4c264132@embeddedor.com> (raw)
In-Reply-To: <20190211221413.GA21822@embeddedor>
Hi all,
Friendly ping:
Who can ack or review this, please?
Thanks
--
Gustavo
On 2/11/19 4:14 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/i3c/master/dw-i3c-master.c: In function ‘dw_i3c_master_bus_init’:
> drivers/i3c/master/dw-i3c-master.c:603:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (ret)
> ^
> drivers/i3c/master/dw-i3c-master.c:605:2: note: here
> case I3C_BUS_MODE_PURE:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/i3c/master/dw-i3c-master.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index bb03079fbade..59279224e07f 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -602,6 +602,7 @@ static int dw_i3c_master_bus_init(struct i3c_master_controller *m)
> ret = dw_i2c_clk_cfg(master);
> if (ret)
> return ret;
> + /* fall through */
> case I3C_BUS_MODE_PURE:
> ret = dw_i3c_clk_cfg(master);
> if (ret)
>
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2019-02-27 3:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 22:14 [PATCH] i3c: master: dw-i3c-master: mark expected switch fall-through Gustavo A. R. Silva
2019-02-27 3:53 ` Gustavo A. R. Silva [this message]
2019-02-27 8:13 ` Boris Brezillon
2019-02-27 20:13 ` Gustavo A. R. Silva
2019-02-27 10:33 ` vitor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87e0a8c9-82f6-3f41-bdb6-162a4c264132@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=bbrezillon@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vitor.soares@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).