linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Damien Le Moal <damien.lemoal@wdc.com>
To: Jens Axboe <axboe@kernel.dk>, linux-ide@vger.kernel.org
Cc: linux-block@vger.kernel.org
Subject: [PATCH v6 0/9] libata cleanups and improvements
Date: Thu, 12 Aug 2021 11:43:54 +0900	[thread overview]
Message-ID: <20210812024403.765819-1-damien.lemoal@wdc.com> (raw)

The first three patches of this series fix sparse and kernel bot
warnings (potential NULL pointer dereference and locking imbalance).

The following three patches cleanup libata-core code in the area of
device configuration (ata_dev_configure() function).

Patch 7 improves ata_read_log_page() to avoid unnecessary warning
messages and patch 8 adds an informational message on device scan to
advertize the features supported by a device.

Path 9 adds the new sysfs ahci device attribute ncq_prio_supported to
indicate that a disk supports NCQ priority.

Changes from v5:
* Updated patch 9 to include adding the new ncq_prio_supported sysfs
  attribute for SATA adapters other than AHCI. Changed the patch title
  and commit message accordingly.

Changes from v4:
* Fixed patch 1 to avoid an out-of-bounds array access
* Changed title of patch 3 to describe the change (as opposed to only
  mentioning the tool that found the problem)
* Removed patch 10 from this series as Martin took it through the scsi
  tree
* Added reviewed-by tags

Changes from v3:
* Reworked patch 1
* Added patch 3 to fix a sparse warning discovered while checking
  patch 1 & 2
* Added reviewed-by tags

Changes from v2:
* Reworked patch 4 to avoid the need for an additional on-stack string
  for device information messages
* Added reviewed-by tags

Changes from v1:
* Added patch 1 and 2 to fix problems reported by the kernel test robot
* Use strscpy() instead of strcpy in patch 4
* Use sysfs_emit in patch 8 and 9 as suggested by Bart
* Fix typos in comments of the new sas_ncq_prio_supported attribute in
  patch 9

Damien Le Moal (9):
  libata: fix ata_host_alloc_pinfo()
  libata: fix ata_host_start()
  libata: simplify ata_scsi_rbuf_fill()
  libata: cleanup device sleep capability detection
  libata: cleanup ata_dev_configure()
  libata: cleanup NCQ priority handling
  libata: fix ata_read_log_page() warning
  libata: print feature list on device scan
  libata: Introduce ncq_prio_supported sysfs sttribute

 drivers/ata/libahci.c     |   1 +
 drivers/ata/libata-core.c | 290 +++++++++++++++++++++-----------------
 drivers/ata/libata-sata.c |  62 ++++----
 drivers/ata/libata-scsi.c |  60 ++------
 include/linux/libata.h    |   5 +
 5 files changed, 212 insertions(+), 206 deletions(-)

-- 
2.31.1


             reply	other threads:[~2021-08-12  2:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12  2:43 Damien Le Moal [this message]
2021-08-12  2:43 ` [PATCH v6 1/9] libata: fix ata_host_alloc_pinfo() Damien Le Moal
2021-08-12  2:43 ` [PATCH v6 2/9] libata: fix ata_host_start() Damien Le Moal
2021-08-12  2:43 ` [PATCH v6 3/9] libata: simplify ata_scsi_rbuf_fill() Damien Le Moal
2021-08-12  2:43 ` [PATCH v6 4/9] libata: cleanup device sleep capability detection Damien Le Moal
2021-08-12  2:43 ` [PATCH v6 5/9] libata: cleanup ata_dev_configure() Damien Le Moal
2021-08-12  2:44 ` [PATCH v6 6/9] libata: cleanup NCQ priority handling Damien Le Moal
2021-08-12  2:44 ` [PATCH v6 7/9] libata: fix ata_read_log_page() warning Damien Le Moal
2021-08-12  2:44 ` [PATCH v6 8/9] libata: print feature list on device scan Damien Le Moal
2021-08-12  2:44 ` [PATCH v6 9/9] libata: Introduce ncq_prio_supported sysfs sttribute Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210812024403.765819-1-damien.lemoal@wdc.com \
    --to=damien.lemoal@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).