From: Damien Le Moal <damien.lemoal@wdc.com>
To: Jens Axboe <axboe@kernel.dk>, linux-ide@vger.kernel.org
Cc: linux-block@vger.kernel.org
Subject: [PATCH v6 2/9] libata: fix ata_host_start()
Date: Thu, 12 Aug 2021 11:43:56 +0900 [thread overview]
Message-ID: <20210812024403.765819-3-damien.lemoal@wdc.com> (raw)
In-Reply-To: <20210812024403.765819-1-damien.lemoal@wdc.com>
The loop on entry of ata_host_start() may not initialize host->ops to a
non NULL value. The test on the host_stop field of host->ops must then
be preceded by a check that host->ops is not NULL.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
---
drivers/ata/libata-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b237a718ea0f..d3f7830bda2e 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -5583,7 +5583,7 @@ int ata_host_start(struct ata_host *host)
have_stop = 1;
}
- if (host->ops->host_stop)
+ if (host->ops && host->ops->host_stop)
have_stop = 1;
if (have_stop) {
--
2.31.1
next prev parent reply other threads:[~2021-08-12 2:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 2:43 [PATCH v6 0/9] libata cleanups and improvements Damien Le Moal
2021-08-12 2:43 ` [PATCH v6 1/9] libata: fix ata_host_alloc_pinfo() Damien Le Moal
2021-08-12 2:43 ` Damien Le Moal [this message]
2021-08-12 2:43 ` [PATCH v6 3/9] libata: simplify ata_scsi_rbuf_fill() Damien Le Moal
2021-08-12 2:43 ` [PATCH v6 4/9] libata: cleanup device sleep capability detection Damien Le Moal
2021-08-12 2:43 ` [PATCH v6 5/9] libata: cleanup ata_dev_configure() Damien Le Moal
2021-08-12 2:44 ` [PATCH v6 6/9] libata: cleanup NCQ priority handling Damien Le Moal
2021-08-12 2:44 ` [PATCH v6 7/9] libata: fix ata_read_log_page() warning Damien Le Moal
2021-08-12 2:44 ` [PATCH v6 8/9] libata: print feature list on device scan Damien Le Moal
2021-08-12 2:44 ` [PATCH v6 9/9] libata: Introduce ncq_prio_supported sysfs sttribute Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812024403.765819-3-damien.lemoal@wdc.com \
--to=damien.lemoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).