* [PATCH 0/2] Fixes for pata parport bpck6 protocol driver
@ 2023-03-23 3:38 Damien Le Moal
2023-03-23 3:38 ` [PATCH 1/2] ata: pata_parport-bpck6: Remove dependency on 64BIT Damien Le Moal
2023-03-23 3:38 ` [PATCH 2/2] ata: pata_parport-bpck6: Declare mode_map as static Damien Le Moal
0 siblings, 2 replies; 7+ messages in thread
From: Damien Le Moal @ 2023-03-23 3:38 UTC (permalink / raw)
To: linux-ide, Ondrej Zary; +Cc: Sergey Shtylyov
A couple of improvements, no functional changes.
Damien Le Moal (2):
ata: pata_parport-bpck6: Remove dependency on 64BIT
ata: pata_parport-bpck6: Declare mode_map as static
drivers/ata/pata_parport/Kconfig | 2 +-
drivers/ata/pata_parport/bpck6.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
--
2.39.2
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] ata: pata_parport-bpck6: Remove dependency on 64BIT
2023-03-23 3:38 [PATCH 0/2] Fixes for pata parport bpck6 protocol driver Damien Le Moal
@ 2023-03-23 3:38 ` Damien Le Moal
2023-03-23 21:01 ` Ondrej Zary
2023-03-26 20:14 ` Ondrej Zary
2023-03-23 3:38 ` [PATCH 2/2] ata: pata_parport-bpck6: Declare mode_map as static Damien Le Moal
1 sibling, 2 replies; 7+ messages in thread
From: Damien Le Moal @ 2023-03-23 3:38 UTC (permalink / raw)
To: linux-ide, Ondrej Zary; +Cc: Sergey Shtylyov
There is no reason to have compilation of the bpck6 protocol module
being dependent on 64BIT. Remove this dependency.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/pata_parport/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_parport/Kconfig b/drivers/ata/pata_parport/Kconfig
index 0893a13e7979..2c953f5d1396 100644
--- a/drivers/ata/pata_parport/Kconfig
+++ b/drivers/ata/pata_parport/Kconfig
@@ -25,7 +25,7 @@ config PATA_PARPORT_BPCK
config PATA_PARPORT_BPCK6
tristate "MicroSolutions backpack (Series 6) protocol"
- depends on (PATA_PARPORT) && !64BIT
+ depends on PATA_PARPORT
help
This option enables support for the Micro Solutions BACKPACK
parallel port Series 6 IDE protocol. (Most BACKPACK drives made
--
2.39.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] ata: pata_parport-bpck6: Remove dependency on 64BIT
2023-03-23 3:38 ` [PATCH 1/2] ata: pata_parport-bpck6: Remove dependency on 64BIT Damien Le Moal
@ 2023-03-23 21:01 ` Ondrej Zary
2023-03-23 22:37 ` Damien Le Moal
2023-03-26 20:14 ` Ondrej Zary
1 sibling, 1 reply; 7+ messages in thread
From: Ondrej Zary @ 2023-03-23 21:01 UTC (permalink / raw)
To: Damien Le Moal; +Cc: linux-ide, Sergey Shtylyov
On Thursday 23 March 2023 04:38:35 Damien Le Moal wrote:
> There is no reason to have compilation of the bpck6 protocol module
> being dependent on 64BIT. Remove this dependency.
Great, I planned to do this but forgot. Thanks.
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/pata_parport/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_parport/Kconfig b/drivers/ata/pata_parport/Kconfig
> index 0893a13e7979..2c953f5d1396 100644
> --- a/drivers/ata/pata_parport/Kconfig
> +++ b/drivers/ata/pata_parport/Kconfig
> @@ -25,7 +25,7 @@ config PATA_PARPORT_BPCK
>
> config PATA_PARPORT_BPCK6
> tristate "MicroSolutions backpack (Series 6) protocol"
> - depends on (PATA_PARPORT) && !64BIT
> + depends on PATA_PARPORT
> help
> This option enables support for the Micro Solutions BACKPACK
> parallel port Series 6 IDE protocol. (Most BACKPACK drives made
--
Ondrej Zary
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] ata: pata_parport-bpck6: Remove dependency on 64BIT
2023-03-23 21:01 ` Ondrej Zary
@ 2023-03-23 22:37 ` Damien Le Moal
0 siblings, 0 replies; 7+ messages in thread
From: Damien Le Moal @ 2023-03-23 22:37 UTC (permalink / raw)
To: Ondrej Zary; +Cc: linux-ide, Sergey Shtylyov
On 3/24/23 06:01, Ondrej Zary wrote:
> On Thursday 23 March 2023 04:38:35 Damien Le Moal wrote:
>> There is no reason to have compilation of the bpck6 protocol module
>> being dependent on 64BIT. Remove this dependency.
>
> Great, I planned to do this but forgot. Thanks.
Can you send a reviewed-by ?
>
>> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>> ---
>> drivers/ata/pata_parport/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/pata_parport/Kconfig b/drivers/ata/pata_parport/Kconfig
>> index 0893a13e7979..2c953f5d1396 100644
>> --- a/drivers/ata/pata_parport/Kconfig
>> +++ b/drivers/ata/pata_parport/Kconfig
>> @@ -25,7 +25,7 @@ config PATA_PARPORT_BPCK
>>
>> config PATA_PARPORT_BPCK6
>> tristate "MicroSolutions backpack (Series 6) protocol"
>> - depends on (PATA_PARPORT) && !64BIT
>> + depends on PATA_PARPORT
>> help
>> This option enables support for the Micro Solutions BACKPACK
>> parallel port Series 6 IDE protocol. (Most BACKPACK drives made
>
>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] ata: pata_parport-bpck6: Remove dependency on 64BIT
2023-03-23 3:38 ` [PATCH 1/2] ata: pata_parport-bpck6: Remove dependency on 64BIT Damien Le Moal
2023-03-23 21:01 ` Ondrej Zary
@ 2023-03-26 20:14 ` Ondrej Zary
1 sibling, 0 replies; 7+ messages in thread
From: Ondrej Zary @ 2023-03-26 20:14 UTC (permalink / raw)
To: Damien Le Moal; +Cc: linux-ide, Sergey Shtylyov
On Thursday 23 March 2023 04:38:35 Damien Le Moal wrote:
> There is no reason to have compilation of the bpck6 protocol module
> being dependent on 64BIT. Remove this dependency.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Ondrej Zary <linux@zary.sk>
> ---
> drivers/ata/pata_parport/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_parport/Kconfig b/drivers/ata/pata_parport/Kconfig
> index 0893a13e7979..2c953f5d1396 100644
> --- a/drivers/ata/pata_parport/Kconfig
> +++ b/drivers/ata/pata_parport/Kconfig
> @@ -25,7 +25,7 @@ config PATA_PARPORT_BPCK
>
> config PATA_PARPORT_BPCK6
> tristate "MicroSolutions backpack (Series 6) protocol"
> - depends on (PATA_PARPORT) && !64BIT
> + depends on PATA_PARPORT
> help
> This option enables support for the Micro Solutions BACKPACK
> parallel port Series 6 IDE protocol. (Most BACKPACK drives made
--
Ondrej Zary
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] ata: pata_parport-bpck6: Declare mode_map as static
2023-03-23 3:38 [PATCH 0/2] Fixes for pata parport bpck6 protocol driver Damien Le Moal
2023-03-23 3:38 ` [PATCH 1/2] ata: pata_parport-bpck6: Remove dependency on 64BIT Damien Le Moal
@ 2023-03-23 3:38 ` Damien Le Moal
2023-03-26 20:14 ` Ondrej Zary
1 sibling, 1 reply; 7+ messages in thread
From: Damien Le Moal @ 2023-03-23 3:38 UTC (permalink / raw)
To: linux-ide, Ondrej Zary; +Cc: Sergey Shtylyov
Compilation C=1 of the bpck6 protocol module generates the following
message:
drivers/ata/pata_parport/bpck6.c:62:5: warning: symbol 'mode_map' was
not declared. Should it be static?
Fix this by declaring mode_map as static.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/pata_parport/bpck6.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_parport/bpck6.c b/drivers/ata/pata_parport/bpck6.c
index 295dbe5cdaa4..76febd07a9bb 100644
--- a/drivers/ata/pata_parport/bpck6.c
+++ b/drivers/ata/pata_parport/bpck6.c
@@ -59,8 +59,8 @@
#define PPCMODE_EPP_WORD 5
#define PPCMODE_EPP_DWORD 6
-int mode_map[] = { PPCMODE_UNI_FW, PPCMODE_BI_FW, PPCMODE_EPP_BYTE,
- PPCMODE_EPP_WORD, PPCMODE_EPP_DWORD };
+static int mode_map[] = { PPCMODE_UNI_FW, PPCMODE_BI_FW, PPCMODE_EPP_BYTE,
+ PPCMODE_EPP_WORD, PPCMODE_EPP_DWORD };
static void bpck6_send_cmd(struct pi_adapter *pi, u8 cmd)
{
--
2.39.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] ata: pata_parport-bpck6: Declare mode_map as static
2023-03-23 3:38 ` [PATCH 2/2] ata: pata_parport-bpck6: Declare mode_map as static Damien Le Moal
@ 2023-03-26 20:14 ` Ondrej Zary
0 siblings, 0 replies; 7+ messages in thread
From: Ondrej Zary @ 2023-03-26 20:14 UTC (permalink / raw)
To: Damien Le Moal; +Cc: linux-ide, Sergey Shtylyov
On Thursday 23 March 2023 04:38:36 Damien Le Moal wrote:
> Compilation C=1 of the bpck6 protocol module generates the following
> message:
>
> drivers/ata/pata_parport/bpck6.c:62:5: warning: symbol 'mode_map' was
> not declared. Should it be static?
>
> Fix this by declaring mode_map as static.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Ondrej Zary <linux@zary.sk>
> ---
> drivers/ata/pata_parport/bpck6.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/pata_parport/bpck6.c b/drivers/ata/pata_parport/bpck6.c
> index 295dbe5cdaa4..76febd07a9bb 100644
> --- a/drivers/ata/pata_parport/bpck6.c
> +++ b/drivers/ata/pata_parport/bpck6.c
> @@ -59,8 +59,8 @@
> #define PPCMODE_EPP_WORD 5
> #define PPCMODE_EPP_DWORD 6
>
> -int mode_map[] = { PPCMODE_UNI_FW, PPCMODE_BI_FW, PPCMODE_EPP_BYTE,
> - PPCMODE_EPP_WORD, PPCMODE_EPP_DWORD };
> +static int mode_map[] = { PPCMODE_UNI_FW, PPCMODE_BI_FW, PPCMODE_EPP_BYTE,
> + PPCMODE_EPP_WORD, PPCMODE_EPP_DWORD };
>
> static void bpck6_send_cmd(struct pi_adapter *pi, u8 cmd)
> {
--
Ondrej Zary
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-03-26 20:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23 3:38 [PATCH 0/2] Fixes for pata parport bpck6 protocol driver Damien Le Moal
2023-03-23 3:38 ` [PATCH 1/2] ata: pata_parport-bpck6: Remove dependency on 64BIT Damien Le Moal
2023-03-23 21:01 ` Ondrej Zary
2023-03-23 22:37 ` Damien Le Moal
2023-03-26 20:14 ` Ondrej Zary
2023-03-23 3:38 ` [PATCH 2/2] ata: pata_parport-bpck6: Declare mode_map as static Damien Le Moal
2023-03-26 20:14 ` Ondrej Zary
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).