* [PATCH -next] iio: st_sensors: Fix build error
@ 2019-08-23 12:18 YueHaibing
2019-08-25 17:59 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2019-08-23 12:18 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw, gregkh, yuehaibing, tglx,
denis.ciocca, Jonathan.Cameron
Cc: linux-iio, linux-kernel
IIO_ST_SENSORS_CORE select IIO_ST_SENSORS_I2C
unconditionally, if REGMAP_I2C is not set, build fails
drivers/iio/common/st_sensors/st_sensors_i2c.o: In function `st_sensors_i2c_configure':
st_sensors_i2c.c:(.text+0x58): undefined reference to `__devm_regmap_init_i2c'
This patch selects REGMAP_I2C to fix it.
IIO_ST_SENSORS_SPI is similar to SPI issue.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 062809ef7733 ("iio: make st_sensors drivers use regmap")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/iio/common/st_sensors/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/iio/common/st_sensors/Kconfig b/drivers/iio/common/st_sensors/Kconfig
index 91b98e1..16d973f 100644
--- a/drivers/iio/common/st_sensors/Kconfig
+++ b/drivers/iio/common/st_sensors/Kconfig
@@ -5,8 +5,10 @@
config IIO_ST_SENSORS_I2C
tristate
+ select REGMAP_I2C
config IIO_ST_SENSORS_SPI
+ select REGMAP_SPI
tristate
config IIO_ST_SENSORS_CORE
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] iio: st_sensors: Fix build error
2019-08-23 12:18 [PATCH -next] iio: st_sensors: Fix build error YueHaibing
@ 2019-08-25 17:59 ` Jonathan Cameron
2019-08-26 2:48 ` Yuehaibing
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2019-08-25 17:59 UTC (permalink / raw)
To: YueHaibing
Cc: knaack.h, lars, pmeerw, gregkh, tglx, denis.ciocca,
Jonathan.Cameron, linux-iio, linux-kernel
On Fri, 23 Aug 2019 20:18:52 +0800
YueHaibing <yuehaibing@huawei.com> wrote:
> IIO_ST_SENSORS_CORE select IIO_ST_SENSORS_I2C
> unconditionally, if REGMAP_I2C is not set, build fails
>
> drivers/iio/common/st_sensors/st_sensors_i2c.o: In function `st_sensors_i2c_configure':
> st_sensors_i2c.c:(.text+0x58): undefined reference to `__devm_regmap_init_i2c'
>
> This patch selects REGMAP_I2C to fix it.
> IIO_ST_SENSORS_SPI is similar to SPI issue.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 062809ef7733 ("iio: make st_sensors drivers use regmap")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Hi,
Thanks, I've fixed up the inconsistent ordering below.
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/common/st_sensors/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/common/st_sensors/Kconfig b/drivers/iio/common/st_sensors/Kconfig
> index 91b98e1..16d973f 100644
> --- a/drivers/iio/common/st_sensors/Kconfig
> +++ b/drivers/iio/common/st_sensors/Kconfig
> @@ -5,8 +5,10 @@
>
> config IIO_ST_SENSORS_I2C
> tristate
> + select REGMAP_I2C
>
> config IIO_ST_SENSORS_SPI
> + select REGMAP_SPI
Inconsistent with the previous.
> tristate
>
> config IIO_ST_SENSORS_CORE
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] iio: st_sensors: Fix build error
2019-08-25 17:59 ` Jonathan Cameron
@ 2019-08-26 2:48 ` Yuehaibing
0 siblings, 0 replies; 3+ messages in thread
From: Yuehaibing @ 2019-08-26 2:48 UTC (permalink / raw)
To: Jonathan Cameron
Cc: knaack.h, lars, pmeerw, gregkh, tglx, denis.ciocca,
Jonathan.Cameron, linux-iio, linux-kernel
On 2019/8/26 1:59, Jonathan Cameron wrote:
> On Fri, 23 Aug 2019 20:18:52 +0800
> YueHaibing <yuehaibing@huawei.com> wrote:
>
>> IIO_ST_SENSORS_CORE select IIO_ST_SENSORS_I2C
>> unconditionally, if REGMAP_I2C is not set, build fails
>>
>> drivers/iio/common/st_sensors/st_sensors_i2c.o: In function `st_sensors_i2c_configure':
>> st_sensors_i2c.c:(.text+0x58): undefined reference to `__devm_regmap_init_i2c'
>>
>> This patch selects REGMAP_I2C to fix it.
>> IIO_ST_SENSORS_SPI is similar to SPI issue.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: 062809ef7733 ("iio: make st_sensors drivers use regmap")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Hi,
>
> Thanks, I've fixed up the inconsistent ordering below.
Oh, thanks!
>
> Applied to the togreg branch of iio.git and pushed out as
> testing for the autobuilders to play with it.
>
> Thanks,
>
> Jonathan
>
>> ---
>> drivers/iio/common/st_sensors/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/iio/common/st_sensors/Kconfig b/drivers/iio/common/st_sensors/Kconfig
>> index 91b98e1..16d973f 100644
>> --- a/drivers/iio/common/st_sensors/Kconfig
>> +++ b/drivers/iio/common/st_sensors/Kconfig
>> @@ -5,8 +5,10 @@
>>
>> config IIO_ST_SENSORS_I2C
>> tristate
>> + select REGMAP_I2C
>>
>> config IIO_ST_SENSORS_SPI
>> + select REGMAP_SPI
>
> Inconsistent with the previous.
>
>> tristate
>>
>> config IIO_ST_SENSORS_CORE
>
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-26 2:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-23 12:18 [PATCH -next] iio: st_sensors: Fix build error YueHaibing
2019-08-25 17:59 ` Jonathan Cameron
2019-08-26 2:48 ` Yuehaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).