* [PATCH] dt-bindings: iio: adc: Add imx6ul & imx6sx compatibles
@ 2022-06-13 12:35 Alexander Stein
2022-06-13 17:34 ` Rob Herring
0 siblings, 1 reply; 8+ messages in thread
From: Alexander Stein @ 2022-06-13 12:35 UTC (permalink / raw)
To: Haibo Chen, Jonathan Cameron, Lars-Peter Clausen, Rob Herring,
Krzysztof Kozlowski
Cc: Alexander Stein, devicetree, linux-iio, linux-imx
Both are already using the vf610 compatible.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
.../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml
index 925f355cc21f..c770ff4998f5 100644
--- a/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml
@@ -14,7 +14,14 @@ description:
properties:
compatible:
- const: fsl,vf610-adc
+ oneOf:
+ - items:
+ - enum:
+ - fsl,imx6sx-adc
+ - fsl,imx6ul-adc
+ - const: fsl,vf610-adc
+ - items:
+ - const: fsl,vf610-adc
reg:
maxItems: 1
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: Add imx6ul & imx6sx compatibles
2022-06-13 12:35 [PATCH] dt-bindings: iio: adc: Add imx6ul & imx6sx compatibles Alexander Stein
@ 2022-06-13 17:34 ` Rob Herring
2022-06-17 22:44 ` Rob Herring
0 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2022-06-13 17:34 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, linux-imx, Jonathan Cameron,
linux-iio, Lars-Peter Clausen, Haibo Chen, devicetree
On Mon, 13 Jun 2022 14:35:29 +0200, Alexander Stein wrote:
> Both are already using the vf610 compatible.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/
adc@2198000: 'num-channels' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/imx6ul-14x14-evk.dtb
arch/arm/boot/dts/imx6ul-ccimx6ulsbcexpress.dtb
arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dtb
arch/arm/boot/dts/imx6ul-geam.dtb
arch/arm/boot/dts/imx6ul-isiot-emmc.dtb
arch/arm/boot/dts/imx6ul-isiot-nand.dtb
arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dtb
arch/arm/boot/dts/imx6ul-kontron-n6310-s.dtb
arch/arm/boot/dts/imx6ull-14x14-evk.dtb
arch/arm/boot/dts/imx6ull-colibri-aster.dtb
arch/arm/boot/dts/imx6ull-colibri-emmc-aster.dtb
arch/arm/boot/dts/imx6ull-colibri-emmc-eval-v3.dtb
arch/arm/boot/dts/imx6ull-colibri-emmc-iris.dtb
arch/arm/boot/dts/imx6ull-colibri-emmc-iris-v2.dtb
arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtb
arch/arm/boot/dts/imx6ull-colibri-iris.dtb
arch/arm/boot/dts/imx6ull-colibri-iris-v2.dtb
arch/arm/boot/dts/imx6ull-colibri-wifi-aster.dtb
arch/arm/boot/dts/imx6ull-colibri-wifi-eval-v3.dtb
arch/arm/boot/dts/imx6ull-colibri-wifi-iris.dtb
arch/arm/boot/dts/imx6ull-colibri-wifi-iris-v2.dtb
arch/arm/boot/dts/imx6ul-liteboard.dtb
arch/arm/boot/dts/imx6ull-jozacp.dtb
arch/arm/boot/dts/imx6ull-myir-mys-6ulx-eval.dtb
arch/arm/boot/dts/imx6ull-opos6uldev.dtb
arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-emmc.dtb
arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-nand.dtb
arch/arm/boot/dts/imx6ull-phytec-segin-lc-rdk-nand.dtb
arch/arm/boot/dts/imx6ull-phytec-tauri-emmc.dtb
arch/arm/boot/dts/imx6ull-phytec-tauri-nand.dtb
arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dtb
arch/arm/boot/dts/imx6ull-tqma6ull2-mba6ulx.dtb
arch/arm/boot/dts/imx6ul-opos6uldev.dtb
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dtb
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dtb
arch/arm/boot/dts/imx6ul-pico-dwarf.dtb
arch/arm/boot/dts/imx6ul-pico-hobbit.dtb
arch/arm/boot/dts/imx6ul-pico-pi.dtb
arch/arm/boot/dts/imx6ul-prti6g.dtb
arch/arm/boot/dts/imx6ul-tqma6ul1-mba6ulx.dtb
arch/arm/boot/dts/imx6ul-tqma6ul2l-mba6ulx.dtb
arch/arm/boot/dts/imx6ul-tqma6ul2-mba6ulx.dtb
arch/arm/boot/dts/imx6ul-tx6ul-0010.dtb
arch/arm/boot/dts/imx6ul-tx6ul-0011.dtb
arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dtb
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: Add imx6ul & imx6sx compatibles
2022-06-13 17:34 ` Rob Herring
@ 2022-06-17 22:44 ` Rob Herring
2022-06-18 17:01 ` Jonathan Cameron
0 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2022-06-17 22:44 UTC (permalink / raw)
To: Alexander Stein
Cc: Krzysztof Kozlowski, linux-imx, Jonathan Cameron, linux-iio,
Lars-Peter Clausen, Haibo Chen, devicetree
On Mon, Jun 13, 2022 at 11:34:46AM -0600, Rob Herring wrote:
> On Mon, 13 Jun 2022 14:35:29 +0200, Alexander Stein wrote:
> > Both are already using the vf610 compatible.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/
>
>
> adc@2198000: 'num-channels' does not match any of the regexes: 'pinctrl-[0-9]+'
Looks like you need to add 'num-channels'?
> arch/arm/boot/dts/imx6ul-14x14-evk.dtb
> arch/arm/boot/dts/imx6ul-ccimx6ulsbcexpress.dtb
> arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dtb
> arch/arm/boot/dts/imx6ul-geam.dtb
> arch/arm/boot/dts/imx6ul-isiot-emmc.dtb
> arch/arm/boot/dts/imx6ul-isiot-nand.dtb
> arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dtb
> arch/arm/boot/dts/imx6ul-kontron-n6310-s.dtb
> arch/arm/boot/dts/imx6ull-14x14-evk.dtb
> arch/arm/boot/dts/imx6ull-colibri-aster.dtb
> arch/arm/boot/dts/imx6ull-colibri-emmc-aster.dtb
> arch/arm/boot/dts/imx6ull-colibri-emmc-eval-v3.dtb
> arch/arm/boot/dts/imx6ull-colibri-emmc-iris.dtb
> arch/arm/boot/dts/imx6ull-colibri-emmc-iris-v2.dtb
> arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtb
> arch/arm/boot/dts/imx6ull-colibri-iris.dtb
> arch/arm/boot/dts/imx6ull-colibri-iris-v2.dtb
> arch/arm/boot/dts/imx6ull-colibri-wifi-aster.dtb
> arch/arm/boot/dts/imx6ull-colibri-wifi-eval-v3.dtb
> arch/arm/boot/dts/imx6ull-colibri-wifi-iris.dtb
> arch/arm/boot/dts/imx6ull-colibri-wifi-iris-v2.dtb
> arch/arm/boot/dts/imx6ul-liteboard.dtb
> arch/arm/boot/dts/imx6ull-jozacp.dtb
> arch/arm/boot/dts/imx6ull-myir-mys-6ulx-eval.dtb
> arch/arm/boot/dts/imx6ull-opos6uldev.dtb
> arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-emmc.dtb
> arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-nand.dtb
> arch/arm/boot/dts/imx6ull-phytec-segin-lc-rdk-nand.dtb
> arch/arm/boot/dts/imx6ull-phytec-tauri-emmc.dtb
> arch/arm/boot/dts/imx6ull-phytec-tauri-nand.dtb
> arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dtb
> arch/arm/boot/dts/imx6ull-tqma6ull2-mba6ulx.dtb
> arch/arm/boot/dts/imx6ul-opos6uldev.dtb
> arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dtb
> arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dtb
> arch/arm/boot/dts/imx6ul-pico-dwarf.dtb
> arch/arm/boot/dts/imx6ul-pico-hobbit.dtb
> arch/arm/boot/dts/imx6ul-pico-pi.dtb
> arch/arm/boot/dts/imx6ul-prti6g.dtb
> arch/arm/boot/dts/imx6ul-tqma6ul1-mba6ulx.dtb
> arch/arm/boot/dts/imx6ul-tqma6ul2l-mba6ulx.dtb
> arch/arm/boot/dts/imx6ul-tqma6ul2-mba6ulx.dtb
> arch/arm/boot/dts/imx6ul-tx6ul-0010.dtb
> arch/arm/boot/dts/imx6ul-tx6ul-0011.dtb
> arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dtb
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: Add imx6ul & imx6sx compatibles
2022-06-17 22:44 ` Rob Herring
@ 2022-06-18 17:01 ` Jonathan Cameron
2022-06-20 8:12 ` (EXT) " Alexander Stein
0 siblings, 1 reply; 8+ messages in thread
From: Jonathan Cameron @ 2022-06-18 17:01 UTC (permalink / raw)
To: Rob Herring
Cc: Alexander Stein, Krzysztof Kozlowski, linux-imx, linux-iio,
Lars-Peter Clausen, Haibo Chen, devicetree
On Fri, 17 Jun 2022 16:44:48 -0600
Rob Herring <robh@kernel.org> wrote:
> On Mon, Jun 13, 2022 at 11:34:46AM -0600, Rob Herring wrote:
> > On Mon, 13 Jun 2022 14:35:29 +0200, Alexander Stein wrote:
> > > Both are already using the vf610 compatible.
> > >
> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > ---
> > > .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml | 9 ++++++++-
> > > 1 file changed, 8 insertions(+), 1 deletion(-)
> > >
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> >
> > Full log is available here: https://patchwork.ozlabs.org/patch/
> >
> >
> > adc@2198000: 'num-channels' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Looks like you need to add 'num-channels'?
or a lot of wrong dtbs :)
By which I mean ones providing a property that may or may not be actually
used by any drivers...
Jonathan
>
> > arch/arm/boot/dts/imx6ul-14x14-evk.dtb
> > arch/arm/boot/dts/imx6ul-ccimx6ulsbcexpress.dtb
> > arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dtb
> > arch/arm/boot/dts/imx6ul-geam.dtb
> > arch/arm/boot/dts/imx6ul-isiot-emmc.dtb
> > arch/arm/boot/dts/imx6ul-isiot-nand.dtb
> > arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dtb
> > arch/arm/boot/dts/imx6ul-kontron-n6310-s.dtb
> > arch/arm/boot/dts/imx6ull-14x14-evk.dtb
> > arch/arm/boot/dts/imx6ull-colibri-aster.dtb
> > arch/arm/boot/dts/imx6ull-colibri-emmc-aster.dtb
> > arch/arm/boot/dts/imx6ull-colibri-emmc-eval-v3.dtb
> > arch/arm/boot/dts/imx6ull-colibri-emmc-iris.dtb
> > arch/arm/boot/dts/imx6ull-colibri-emmc-iris-v2.dtb
> > arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtb
> > arch/arm/boot/dts/imx6ull-colibri-iris.dtb
> > arch/arm/boot/dts/imx6ull-colibri-iris-v2.dtb
> > arch/arm/boot/dts/imx6ull-colibri-wifi-aster.dtb
> > arch/arm/boot/dts/imx6ull-colibri-wifi-eval-v3.dtb
> > arch/arm/boot/dts/imx6ull-colibri-wifi-iris.dtb
> > arch/arm/boot/dts/imx6ull-colibri-wifi-iris-v2.dtb
> > arch/arm/boot/dts/imx6ul-liteboard.dtb
> > arch/arm/boot/dts/imx6ull-jozacp.dtb
> > arch/arm/boot/dts/imx6ull-myir-mys-6ulx-eval.dtb
> > arch/arm/boot/dts/imx6ull-opos6uldev.dtb
> > arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-emmc.dtb
> > arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-nand.dtb
> > arch/arm/boot/dts/imx6ull-phytec-segin-lc-rdk-nand.dtb
> > arch/arm/boot/dts/imx6ull-phytec-tauri-emmc.dtb
> > arch/arm/boot/dts/imx6ull-phytec-tauri-nand.dtb
> > arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dtb
> > arch/arm/boot/dts/imx6ull-tqma6ull2-mba6ulx.dtb
> > arch/arm/boot/dts/imx6ul-opos6uldev.dtb
> > arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dtb
> > arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dtb
> > arch/arm/boot/dts/imx6ul-pico-dwarf.dtb
> > arch/arm/boot/dts/imx6ul-pico-hobbit.dtb
> > arch/arm/boot/dts/imx6ul-pico-pi.dtb
> > arch/arm/boot/dts/imx6ul-prti6g.dtb
> > arch/arm/boot/dts/imx6ul-tqma6ul1-mba6ulx.dtb
> > arch/arm/boot/dts/imx6ul-tqma6ul2l-mba6ulx.dtb
> > arch/arm/boot/dts/imx6ul-tqma6ul2-mba6ulx.dtb
> > arch/arm/boot/dts/imx6ul-tx6ul-0010.dtb
> > arch/arm/boot/dts/imx6ul-tx6ul-0011.dtb
> > arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dtb
> >
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: (EXT) Re: [PATCH] dt-bindings: iio: adc: Add imx6ul & imx6sx compatibles
2022-06-18 17:01 ` Jonathan Cameron
@ 2022-06-20 8:12 ` Alexander Stein
2022-06-28 21:09 ` Rob Herring
0 siblings, 1 reply; 8+ messages in thread
From: Alexander Stein @ 2022-06-20 8:12 UTC (permalink / raw)
To: Rob Herring, Jonathan Cameron
Cc: Krzysztof Kozlowski, linux-imx, linux-iio, Lars-Peter Clausen,
Haibo Chen, devicetree
Hello,
Am Samstag, 18. Juni 2022, 19:01:29 CEST schrieb Jonathan Cameron:
> On Fri, 17 Jun 2022 16:44:48 -0600
>
> Rob Herring <robh@kernel.org> wrote:
> > On Mon, Jun 13, 2022 at 11:34:46AM -0600, Rob Herring wrote:
> > > On Mon, 13 Jun 2022 14:35:29 +0200, Alexander Stein wrote:
> > > > Both are already using the vf610 compatible.
> > > >
> > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > ---
> > > >
> > > > .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml | 9
> > > > ++++++++-
> > > > 1 file changed, 8 insertions(+), 1 deletion(-)
> > >
> > > Running 'make dtbs_check' with the schema in this patch gives the
> > > following warnings. Consider if they are expected or the schema is
> > > incorrect. These may not be new warnings.
> > >
> > > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > > This will change in the future.
> > >
> > > Full log is available here: https://patchwork.ozlabs.org/patch/
> > >
> > >
> > > adc@2198000: 'num-channels' does not match any of the regexes:
> > > 'pinctrl-[0-9]+'>
> > Looks like you need to add 'num-channels'?
>
> or a lot of wrong dtbs :)
>
> By which I mean ones providing a property that may or may not be actually
> used by any drivers...
This got already fixed by Baruch's patch which is currently in Shawn's imx-
fixes-5.19 branch at [1]
Best reagrds,
Alexander
[1] https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/
commit/?h=imx/dt&id=71b81f1cac29297769ec81fe29a3fcc40bc2c31c
> > > arch/arm/boot/dts/imx6ul-14x14-evk.dtb
> > > arch/arm/boot/dts/imx6ul-ccimx6ulsbcexpress.dtb
> > > arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dtb
> > > arch/arm/boot/dts/imx6ul-geam.dtb
> > > arch/arm/boot/dts/imx6ul-isiot-emmc.dtb
> > > arch/arm/boot/dts/imx6ul-isiot-nand.dtb
> > > arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dtb
> > > arch/arm/boot/dts/imx6ul-kontron-n6310-s.dtb
> > > arch/arm/boot/dts/imx6ull-14x14-evk.dtb
> > > arch/arm/boot/dts/imx6ull-colibri-aster.dtb
> > > arch/arm/boot/dts/imx6ull-colibri-emmc-aster.dtb
> > > arch/arm/boot/dts/imx6ull-colibri-emmc-eval-v3.dtb
> > > arch/arm/boot/dts/imx6ull-colibri-emmc-iris.dtb
> > > arch/arm/boot/dts/imx6ull-colibri-emmc-iris-v2.dtb
> > > arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtb
> > > arch/arm/boot/dts/imx6ull-colibri-iris.dtb
> > > arch/arm/boot/dts/imx6ull-colibri-iris-v2.dtb
> > > arch/arm/boot/dts/imx6ull-colibri-wifi-aster.dtb
> > > arch/arm/boot/dts/imx6ull-colibri-wifi-eval-v3.dtb
> > > arch/arm/boot/dts/imx6ull-colibri-wifi-iris.dtb
> > > arch/arm/boot/dts/imx6ull-colibri-wifi-iris-v2.dtb
> > > arch/arm/boot/dts/imx6ul-liteboard.dtb
> > > arch/arm/boot/dts/imx6ull-jozacp.dtb
> > > arch/arm/boot/dts/imx6ull-myir-mys-6ulx-eval.dtb
> > > arch/arm/boot/dts/imx6ull-opos6uldev.dtb
> > > arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-emmc.dtb
> > > arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-nand.dtb
> > > arch/arm/boot/dts/imx6ull-phytec-segin-lc-rdk-nand.dtb
> > > arch/arm/boot/dts/imx6ull-phytec-tauri-emmc.dtb
> > > arch/arm/boot/dts/imx6ull-phytec-tauri-nand.dtb
> > > arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dtb
> > > arch/arm/boot/dts/imx6ull-tqma6ull2-mba6ulx.dtb
> > > arch/arm/boot/dts/imx6ul-opos6uldev.dtb
> > > arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dtb
> > > arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dtb
> > > arch/arm/boot/dts/imx6ul-pico-dwarf.dtb
> > > arch/arm/boot/dts/imx6ul-pico-hobbit.dtb
> > > arch/arm/boot/dts/imx6ul-pico-pi.dtb
> > > arch/arm/boot/dts/imx6ul-prti6g.dtb
> > > arch/arm/boot/dts/imx6ul-tqma6ul1-mba6ulx.dtb
> > > arch/arm/boot/dts/imx6ul-tqma6ul2l-mba6ulx.dtb
> > > arch/arm/boot/dts/imx6ul-tqma6ul2-mba6ulx.dtb
> > > arch/arm/boot/dts/imx6ul-tx6ul-0010.dtb
> > > arch/arm/boot/dts/imx6ul-tx6ul-0011.dtb
> > > arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dtb
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: (EXT) Re: [PATCH] dt-bindings: iio: adc: Add imx6ul & imx6sx compatibles
2022-06-20 8:12 ` (EXT) " Alexander Stein
@ 2022-06-28 21:09 ` Rob Herring
2022-07-15 7:56 ` Alexander Stein
0 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2022-06-28 21:09 UTC (permalink / raw)
To: Alexander Stein
Cc: Jonathan Cameron, Krzysztof Kozlowski, linux-imx, linux-iio,
Lars-Peter Clausen, Haibo Chen, devicetree
On Mon, Jun 20, 2022 at 10:12:44AM +0200, Alexander Stein wrote:
> Hello,
>
> Am Samstag, 18. Juni 2022, 19:01:29 CEST schrieb Jonathan Cameron:
> > On Fri, 17 Jun 2022 16:44:48 -0600
> >
> > Rob Herring <robh@kernel.org> wrote:
> > > On Mon, Jun 13, 2022 at 11:34:46AM -0600, Rob Herring wrote:
> > > > On Mon, 13 Jun 2022 14:35:29 +0200, Alexander Stein wrote:
> > > > > Both are already using the vf610 compatible.
> > > > >
> > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > > ---
> > > > >
> > > > > .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml | 9
> > > > > ++++++++-
> > > > > 1 file changed, 8 insertions(+), 1 deletion(-)
> > > >
> > > > Running 'make dtbs_check' with the schema in this patch gives the
> > > > following warnings. Consider if they are expected or the schema is
> > > > incorrect. These may not be new warnings.
> > > >
> > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > > > This will change in the future.
> > > >
> > > > Full log is available here: https://patchwork.ozlabs.org/patch/
> > > >
> > > >
> > > > adc@2198000: 'num-channels' does not match any of the regexes:
> > > > 'pinctrl-[0-9]+'>
> > > Looks like you need to add 'num-channels'?
> >
> > or a lot of wrong dtbs :)
> >
> > By which I mean ones providing a property that may or may not be actually
> > used by any drivers...
>
> This got already fixed by Baruch's patch which is currently in Shawn's imx-
> fixes-5.19 branch at [1]
Great!
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re: [PATCH] dt-bindings: iio: adc: Add imx6ul & imx6sx compatibles
2022-06-28 21:09 ` Rob Herring
@ 2022-07-15 7:56 ` Alexander Stein
2022-07-16 14:52 ` Jonathan Cameron
0 siblings, 1 reply; 8+ messages in thread
From: Alexander Stein @ 2022-07-15 7:56 UTC (permalink / raw)
To: Rob Herring
Cc: Jonathan Cameron, Krzysztof Kozlowski, linux-imx, linux-iio,
Lars-Peter Clausen, Haibo Chen, devicetree
Am Dienstag, 28. Juni 2022, 23:09:19 CEST schrieb Rob Herring:
> On Mon, Jun 20, 2022 at 10:12:44AM +0200, Alexander Stein wrote:
> > Hello,
> >
> > Am Samstag, 18. Juni 2022, 19:01:29 CEST schrieb Jonathan Cameron:
> > > On Fri, 17 Jun 2022 16:44:48 -0600
> > >
> > > Rob Herring <robh@kernel.org> wrote:
> > > > On Mon, Jun 13, 2022 at 11:34:46AM -0600, Rob Herring wrote:
> > > > > On Mon, 13 Jun 2022 14:35:29 +0200, Alexander Stein wrote:
> > > > > > Both are already using the vf610 compatible.
> > > > > >
> > > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > > > ---
> > > > > >
> > > > > > .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml | 9
> > > > > > ++++++++-
> > > > > > 1 file changed, 8 insertions(+), 1 deletion(-)
> > > > >
> > > > > Running 'make dtbs_check' with the schema in this patch gives the
> > > > > following warnings. Consider if they are expected or the schema is
> > > > > incorrect. These may not be new warnings.
> > > > >
> > > > > Note that it is not yet a requirement to have 0 warnings for
> > > > > dtbs_check.
> > > > > This will change in the future.
> > > > >
> > > > > Full log is available here: https://patchwork.ozlabs.org/patch/
> > > > >
> > > > >
> > > > > adc@2198000: 'num-channels' does not match any of the regexes:
> > > > > 'pinctrl-[0-9]+'>
> > > >
> > > > Looks like you need to add 'num-channels'?
> > >
> > > or a lot of wrong dtbs :)
> > >
> > > By which I mean ones providing a property that may or may not be
> > > actually
> > > used by any drivers...
> >
> > This got already fixed by Baruch's patch which is currently in Shawn's
> > imx-
> > fixes-5.19 branch at [1]
>
> Great!
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Did this got missed? Or is it applied somwhere I' not aware of?
Best regards,
Alexander
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: Add imx6ul & imx6sx compatibles
2022-07-15 7:56 ` Alexander Stein
@ 2022-07-16 14:52 ` Jonathan Cameron
0 siblings, 0 replies; 8+ messages in thread
From: Jonathan Cameron @ 2022-07-16 14:52 UTC (permalink / raw)
To: Alexander Stein, linux-imx, linux-iio
Cc: Rob Herring, Krzysztof Kozlowski, Lars-Peter Clausen, Haibo Chen,
devicetree
On Fri, 15 Jul 2022 09:56:45 +0200
Alexander Stein <alexander.stein@ew.tq-group.com> wrote:
> Am Dienstag, 28. Juni 2022, 23:09:19 CEST schrieb Rob Herring:
> > On Mon, Jun 20, 2022 at 10:12:44AM +0200, Alexander Stein wrote:
> > > Hello,
> > >
> > > Am Samstag, 18. Juni 2022, 19:01:29 CEST schrieb Jonathan Cameron:
> > > > On Fri, 17 Jun 2022 16:44:48 -0600
> > > >
> > > > Rob Herring <robh@kernel.org> wrote:
> > > > > On Mon, Jun 13, 2022 at 11:34:46AM -0600, Rob Herring wrote:
> > > > > > On Mon, 13 Jun 2022 14:35:29 +0200, Alexander Stein wrote:
> > > > > > > Both are already using the vf610 compatible.
> > > > > > >
> > > > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > > > > ---
> > > > > > >
> > > > > > > .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml | 9
> > > > > > > ++++++++-
> > > > > > > 1 file changed, 8 insertions(+), 1 deletion(-)
> > > > > >
> > > > > > Running 'make dtbs_check' with the schema in this patch gives the
> > > > > > following warnings. Consider if they are expected or the schema is
> > > > > > incorrect. These may not be new warnings.
> > > > > >
> > > > > > Note that it is not yet a requirement to have 0 warnings for
> > > > > > dtbs_check.
> > > > > > This will change in the future.
> > > > > >
> > > > > > Full log is available here: https://patchwork.ozlabs.org/patch/
> > > > > >
> > > > > >
> > > > > > adc@2198000: 'num-channels' does not match any of the regexes:
> > > > > > 'pinctrl-[0-9]+'>
> > > > >
> > > > > Looks like you need to add 'num-channels'?
> > > >
> > > > or a lot of wrong dtbs :)
> > > >
> > > > By which I mean ones providing a property that may or may not be
> > > > actually
> > > > used by any drivers...
> > >
> > > This got already fixed by Baruch's patch which is currently in Shawn's
> > > imx-
> > > fixes-5.19 branch at [1]
> >
> > Great!
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
>
> Did this got missed? Or is it applied somwhere I' not aware of?
Missed it. Thanks for pointing it out!
Applied to the togreg branch of iio.git and pushed out initially as testing
for 0-day to poke at it. Note this may well not make this cycle now unfortunately
given the timing.
Thanks,
Jonathan
>
> Best regards,
> Alexander
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-07-16 14:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-13 12:35 [PATCH] dt-bindings: iio: adc: Add imx6ul & imx6sx compatibles Alexander Stein
2022-06-13 17:34 ` Rob Herring
2022-06-17 22:44 ` Rob Herring
2022-06-18 17:01 ` Jonathan Cameron
2022-06-20 8:12 ` (EXT) " Alexander Stein
2022-06-28 21:09 ` Rob Herring
2022-07-15 7:56 ` Alexander Stein
2022-07-16 14:52 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).