From: Jonathan Cameron <jic23@kernel.org>
To: Martin Kelly <martin@martingkelly.com>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Daniel Baluta <daniel.baluta@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 0/6] iio:bmi160: add drdy interrupt support
Date: Sat, 2 Feb 2019 09:46:41 +0000 [thread overview]
Message-ID: <20190202094641.6dad8095@archlinux> (raw)
In-Reply-To: <20190127203911.8696-1-martin@martingkelly.com>
On Sun, 27 Jan 2019 12:39:05 -0800
Martin Kelly <martin@martingkelly.com> wrote:
> From: Martin Kelly <martin@martingkelly.com>
>
> This patch series adds drdy interrupt support to the BMI160 IMU. It also updates
> the relevant DT bindings and does a little bit of related cleanup.
>
> v2:
> - Drop "BOTH" interrupt setting.
> - Change to "if (ret)" instead of "if (ret < 0)".
> - Stylistic changes suggested by Jonathan Cameron.
> - Fix bogus return check after iio_trigger_get.
>
> v3:
> - More cleanup changes.
> - Directly get INT1/INT2 by name instead of using I2C/SPI IRQs. Move this code
> to the probe function.
> - Fix EDGE/LEVEL #define naming. The code was correct but the names were wrong.
>
> Martin Kelly (6):
> iio:bmi160: add SPDX identifiers
> iio:bmi160: add drdy interrupt support
> dt-bindings: fix incorrect bmi160 IRQ note
> dt-bindings: document open-drain property
> iio:bmi160: use iio_pollfunc_store_time
> iio:bmi160: use if (ret) instead of if (ret < 0)
>
> .../devicetree/bindings/iio/imu/bmi160.txt | 6 +-
> drivers/iio/imu/bmi160/bmi160.h | 11 +
> drivers/iio/imu/bmi160/bmi160_core.c | 317 +++++++++++++++++++--
> drivers/iio/imu/bmi160/bmi160_i2c.c | 5 +-
> drivers/iio/imu/bmi160/bmi160_spi.c | 4 +-
> 5 files changed, 304 insertions(+), 39 deletions(-)
Other than addressing Rob's comments I think this is looking good.
Will take one last look at v4 of course!
Thanks,
Jonathan
>
> --
> 2.11.0
>
prev parent reply other threads:[~2019-02-02 9:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 20:39 [PATCH v3 0/6] iio:bmi160: add drdy interrupt support Martin Kelly
2019-01-27 20:39 ` [PATCH v3 1/6] iio:bmi160: add SPDX identifiers Martin Kelly
2019-01-27 20:39 ` [PATCH v3 2/6] iio:bmi160: add drdy interrupt support Martin Kelly
2019-01-27 20:39 ` [PATCH v3 3/6] dt-bindings: fix incorrect bmi160 IRQ note Martin Kelly
2019-01-30 16:56 ` Rob Herring
2019-01-27 20:39 ` [PATCH v3 4/6] dt-bindings: document open-drain property Martin Kelly
2019-01-30 16:57 ` Rob Herring
2019-01-31 3:02 ` Martin Kelly
2019-01-27 20:39 ` [PATCH v3 5/6] iio:bmi160: use iio_pollfunc_store_time Martin Kelly
2019-01-27 20:39 ` [PATCH v3 6/6] iio:bmi160: use if (ret) instead of if (ret < 0) Martin Kelly
2019-02-02 9:46 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190202094641.6dad8095@archlinux \
--to=jic23@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=martin@martingkelly.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).