From: Jonathan Cameron <jic23@kernel.org>
To: Camylla Cantanheide <c.cantanheide@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com,
Feulo <guifeulo@gmail.com>
Subject: Re: [PATCH] staging:iio:ad7152: align line to match open parenthesis
Date: Sat, 2 Feb 2019 09:56:47 +0000 [thread overview]
Message-ID: <20190202095647.489f6a36@archlinux> (raw)
In-Reply-To: <1548786660-11935-1-git-send-email-c.cantanheide@gmail.com>
On Tue, 29 Jan 2019 16:31:00 -0200
Camylla Cantanheide <c.cantanheide@gmail.com> wrote:
> From: Feulo <guifeulo@gmail.com>
>
> Align broken line to match upper line parenthesis. Solves the
> checkpatch.pl's message
>
> CHECK: Alignment should match open parenthesis.
>
> Signed-off-by: Feulo <guifeulo@gmail.com>
For reference should be full name (though I'm obviously making
assumptions).
Also, this is very unlucky timing as I have a patch sent on
Wednesday to drop this driver on the basis the part is going away
and we don't know of anyone who actually has hardware.
Given I'm going to apply that in a moment, adding this one would
just be noise.
Sorry. This happens sometimes in the churn of the kernel!
Jonathan
> Signed-off-by: Camylla Cantanheide <c.cantanheide@gmail.com>
> ---
> drivers/staging/iio/cdc/ad7152.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
> index 25f51db..e7f082f 100644
> --- a/drivers/staging/iio/cdc/ad7152.c
> +++ b/drivers/staging/iio/cdc/ad7152.c
> @@ -362,7 +362,7 @@ static int ad7152_read_raw(struct iio_dev *indio_dev,
> /* Trigger a single read */
> regval |= AD7152_CONF_MODE_SINGLE_CONV;
> ret = i2c_smbus_write_byte_data(chip->client, AD7152_REG_CFG,
> - regval);
> + regval);
> if (ret < 0)
> goto out;
>
prev parent reply other threads:[~2019-02-02 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 18:31 [PATCH] staging:iio:ad7152: align line to match open parenthesis Camylla Cantanheide
2019-02-02 9:56 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190202095647.489f6a36@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=c.cantanheide@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=guifeulo@gmail.com \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).