Linux-IIO Archive on lore.kernel.org
 help / Atom feed
* [PATCH] staging:iio:ad7152: align line to match open parenthesis
@ 2019-01-29 18:31 Camylla Cantanheide
  2019-02-02  9:56 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Camylla Cantanheide @ 2019-01-29 18:31 UTC (permalink / raw)
  To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
	Hartmut Knaack, Peter Meerwald-Stadler, Greg Kroah-Hartman
  Cc: linux-iio, devel, linux-kernel, kernel-usp, Feulo, Camylla Cantanheide

From: Feulo <guifeulo@gmail.com>

Align broken line to match upper line parenthesis. Solves the
checkpatch.pl's message

CHECK: Alignment should match open parenthesis.

Signed-off-by: Feulo <guifeulo@gmail.com>
Signed-off-by: Camylla Cantanheide <c.cantanheide@gmail.com>
---
 drivers/staging/iio/cdc/ad7152.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
index 25f51db..e7f082f 100644
--- a/drivers/staging/iio/cdc/ad7152.c
+++ b/drivers/staging/iio/cdc/ad7152.c
@@ -362,7 +362,7 @@ static int ad7152_read_raw(struct iio_dev *indio_dev,
 		/* Trigger a single read */
 		regval |= AD7152_CONF_MODE_SINGLE_CONV;
 		ret = i2c_smbus_write_byte_data(chip->client, AD7152_REG_CFG,
-				regval);
+						regval);
 		if (ret < 0)
 			goto out;
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging:iio:ad7152: align line to match open parenthesis
  2019-01-29 18:31 [PATCH] staging:iio:ad7152: align line to match open parenthesis Camylla Cantanheide
@ 2019-02-02  9:56 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-02-02  9:56 UTC (permalink / raw)
  To: Camylla Cantanheide
  Cc: Lars-Peter Clausen, Michael Hennerich, Hartmut Knaack,
	Peter Meerwald-Stadler, Greg Kroah-Hartman, linux-iio, devel,
	linux-kernel, kernel-usp, Feulo

On Tue, 29 Jan 2019 16:31:00 -0200
Camylla Cantanheide <c.cantanheide@gmail.com> wrote:

> From: Feulo <guifeulo@gmail.com>
> 
> Align broken line to match upper line parenthesis. Solves the
> checkpatch.pl's message
> 
> CHECK: Alignment should match open parenthesis.
> 
> Signed-off-by: Feulo <guifeulo@gmail.com>
For reference should be full name (though I'm obviously making
assumptions).

Also, this is very unlucky timing as I have a patch sent on 
Wednesday to drop this driver on the basis the part is going away
and we don't know of anyone who actually has hardware.
Given I'm going to apply that in a moment, adding this one would
just be noise.

Sorry.  This happens sometimes in the churn of the kernel!

Jonathan


> Signed-off-by: Camylla Cantanheide <c.cantanheide@gmail.com>
> ---
>  drivers/staging/iio/cdc/ad7152.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
> index 25f51db..e7f082f 100644
> --- a/drivers/staging/iio/cdc/ad7152.c
> +++ b/drivers/staging/iio/cdc/ad7152.c
> @@ -362,7 +362,7 @@ static int ad7152_read_raw(struct iio_dev *indio_dev,
>  		/* Trigger a single read */
>  		regval |= AD7152_CONF_MODE_SINGLE_CONV;
>  		ret = i2c_smbus_write_byte_data(chip->client, AD7152_REG_CFG,
> -				regval);
> +						regval);
>  		if (ret < 0)
>  			goto out;
>  


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 18:31 [PATCH] staging:iio:ad7152: align line to match open parenthesis Camylla Cantanheide
2019-02-02  9:56 ` Jonathan Cameron

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org linux-iio@archiver.kernel.org
	public-inbox-index linux-iio


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/ public-inbox