* [PATCH -next] counter: 104-quad-8: Make quad8_ops static
@ 2019-04-26 16:48 Yue Haibing
2019-04-27 0:27 ` William Breathitt Gray
0 siblings, 1 reply; 2+ messages in thread
From: Yue Haibing @ 2019-04-26 16:48 UTC (permalink / raw)
To: vilhelm.gray, gregkh; +Cc: linux-kernel, linux-iio, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
drivers/counter/104-quad-8.c:836:26: warning:
symbol 'quad8_ops' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/counter/104-quad-8.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
index 4fa2931..00b113f 100644
--- a/drivers/counter/104-quad-8.c
+++ b/drivers/counter/104-quad-8.c
@@ -833,7 +833,7 @@ static int quad8_action_get(struct counter_device *counter,
return 0;
}
-const struct counter_ops quad8_ops = {
+static const struct counter_ops quad8_ops = {
.signal_read = quad8_signal_read,
.count_read = quad8_count_read,
.count_write = quad8_count_write,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] counter: 104-quad-8: Make quad8_ops static
2019-04-26 16:48 [PATCH -next] counter: 104-quad-8: Make quad8_ops static Yue Haibing
@ 2019-04-27 0:27 ` William Breathitt Gray
0 siblings, 0 replies; 2+ messages in thread
From: William Breathitt Gray @ 2019-04-27 0:27 UTC (permalink / raw)
To: Yue Haibing; +Cc: gregkh, linux-kernel, linux-iio
On Sat, Apr 27, 2019 at 12:48:16AM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/counter/104-quad-8.c:836:26: warning:
> symbol 'quad8_ops' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/counter/104-quad-8.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
> index 4fa2931..00b113f 100644
> --- a/drivers/counter/104-quad-8.c
> +++ b/drivers/counter/104-quad-8.c
> @@ -833,7 +833,7 @@ static int quad8_action_get(struct counter_device *counter,
> return 0;
> }
>
> -const struct counter_ops quad8_ops = {
> +static const struct counter_ops quad8_ops = {
> .signal_read = quad8_signal_read,
> .count_read = quad8_count_read,
> .count_write = quad8_count_write,
> --
> 2.7.4
Yes, thank you, this should be static.
Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-27 0:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-26 16:48 [PATCH -next] counter: 104-quad-8: Make quad8_ops static Yue Haibing
2019-04-27 0:27 ` William Breathitt Gray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).