* [PATCH v2] iio: temperature: maxim_thermocouple: declare missing of table
@ 2019-04-23 21:42 Daniel Gomez
2019-04-25 1:35 ` Matt Ranostay
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Gomez @ 2019-04-23 21:42 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, open list:IIO SUBSYSTEM AND DRIVERS,
open list
Cc: dagmcr, javier, open list:IIO SUBSYSTEM AND DRIVERS, open list
Add missing <of_device_id> table for SPI driver relying on SPI
device match since compatible is in a DT binding or in a DTS.
Before this patch:
modinfo drivers/iio/temperature/maxim_thermocouple.ko | grep alias
alias: spi:max31855
alias: spi:max6675
After this patch:
modinfo drivers/iio/temperature/maxim_thermocouple.ko | grep alias
alias: spi:max31855
alias: spi:max6675
alias: of:N*T*Cmaxim,max31855C*
alias: of:N*T*Cmaxim,max31855
alias: of:N*T*Cmaxim,max6675C*
alias: of:N*T*Cmaxim,max6675
Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
---
drivers/iio/temperature/maxim_thermocouple.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/iio/temperature/maxim_thermocouple.c b/drivers/iio/temperature/maxim_thermocouple.c
index c31b963..c613a64 100644
--- a/drivers/iio/temperature/maxim_thermocouple.c
+++ b/drivers/iio/temperature/maxim_thermocouple.c
@@ -10,6 +10,8 @@
#include <linux/init.h>
#include <linux/mutex.h>
#include <linux/err.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
#include <linux/spi/spi.h>
#include <linux/iio/iio.h>
#include <linux/iio/trigger.h>
@@ -262,9 +264,17 @@ static const struct spi_device_id maxim_thermocouple_id[] = {
};
MODULE_DEVICE_TABLE(spi, maxim_thermocouple_id);
+static const struct of_device_id maxim_thermocouple_of_match[] = {
+ { .compatible = "maxim,max6675" },
+ { .compatible = "maxim,max31855" },
+ { },
+};
+MODULE_DEVICE_TABLE(of, maxim_thermocouple_of_match);
+
static struct spi_driver maxim_thermocouple_driver = {
.driver = {
.name = MAXIM_THERMOCOUPLE_DRV_NAME,
+ .of_match_table = maxim_thermocouple_of_match,
},
.probe = maxim_thermocouple_probe,
.remove = maxim_thermocouple_remove,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] iio: temperature: maxim_thermocouple: declare missing of table
2019-04-23 21:42 [PATCH v2] iio: temperature: maxim_thermocouple: declare missing of table Daniel Gomez
@ 2019-04-25 1:35 ` Matt Ranostay
2019-04-27 12:55 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Matt Ranostay @ 2019-04-25 1:35 UTC (permalink / raw)
To: Daniel Gomez
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, open list:IIO SUBSYSTEM AND DRIVERS,
open list, javier
On Wed, Apr 24, 2019 at 5:42 AM Daniel Gomez <dagmcr@gmail.com> wrote:
>
> Add missing <of_device_id> table for SPI driver relying on SPI
> device match since compatible is in a DT binding or in a DTS.
>
> Before this patch:
> modinfo drivers/iio/temperature/maxim_thermocouple.ko | grep alias
> alias: spi:max31855
> alias: spi:max6675
>
> After this patch:
> modinfo drivers/iio/temperature/maxim_thermocouple.ko | grep alias
> alias: spi:max31855
> alias: spi:max6675
> alias: of:N*T*Cmaxim,max31855C*
> alias: of:N*T*Cmaxim,max31855
> alias: of:N*T*Cmaxim,max6675C*
> alias: of:N*T*Cmaxim,max6675
Heh oops I missed that somehow in initial development.
Acked-by: Matt Ranostay <matt.ranostay@konsulko.com>
>
> Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
> Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
> ---
> drivers/iio/temperature/maxim_thermocouple.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/iio/temperature/maxim_thermocouple.c b/drivers/iio/temperature/maxim_thermocouple.c
> index c31b963..c613a64 100644
> --- a/drivers/iio/temperature/maxim_thermocouple.c
> +++ b/drivers/iio/temperature/maxim_thermocouple.c
> @@ -10,6 +10,8 @@
> #include <linux/init.h>
> #include <linux/mutex.h>
> #include <linux/err.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> #include <linux/spi/spi.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/trigger.h>
> @@ -262,9 +264,17 @@ static const struct spi_device_id maxim_thermocouple_id[] = {
> };
> MODULE_DEVICE_TABLE(spi, maxim_thermocouple_id);
>
> +static const struct of_device_id maxim_thermocouple_of_match[] = {
> + { .compatible = "maxim,max6675" },
> + { .compatible = "maxim,max31855" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, maxim_thermocouple_of_match);
> +
> static struct spi_driver maxim_thermocouple_driver = {
> .driver = {
> .name = MAXIM_THERMOCOUPLE_DRV_NAME,
> + .of_match_table = maxim_thermocouple_of_match,
> },
> .probe = maxim_thermocouple_probe,
> .remove = maxim_thermocouple_remove,
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] iio: temperature: maxim_thermocouple: declare missing of table
2019-04-25 1:35 ` Matt Ranostay
@ 2019-04-27 12:55 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-04-27 12:55 UTC (permalink / raw)
To: Matt Ranostay
Cc: Daniel Gomez, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, open list:IIO SUBSYSTEM AND DRIVERS,
open list, javier
On Thu, 25 Apr 2019 09:35:07 +0800
Matt Ranostay <matt.ranostay@konsulko.com> wrote:
> On Wed, Apr 24, 2019 at 5:42 AM Daniel Gomez <dagmcr@gmail.com> wrote:
> >
> > Add missing <of_device_id> table for SPI driver relying on SPI
> > device match since compatible is in a DT binding or in a DTS.
> >
> > Before this patch:
> > modinfo drivers/iio/temperature/maxim_thermocouple.ko | grep alias
> > alias: spi:max31855
> > alias: spi:max6675
> >
> > After this patch:
> > modinfo drivers/iio/temperature/maxim_thermocouple.ko | grep alias
> > alias: spi:max31855
> > alias: spi:max6675
> > alias: of:N*T*Cmaxim,max31855C*
> > alias: of:N*T*Cmaxim,max31855
> > alias: of:N*T*Cmaxim,max6675C*
> > alias: of:N*T*Cmaxim,max6675
>
> Heh oops I missed that somehow in initial development.
>
> Acked-by: Matt Ranostay <matt.ranostay@konsulko.com>
Applied to the togreg branch of iio.git. Given timing this may have
to wait for the next cycle to go upstream.
Thanks.
Jonathan
>
> >
> > Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
> > Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
> > ---
> > drivers/iio/temperature/maxim_thermocouple.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/iio/temperature/maxim_thermocouple.c b/drivers/iio/temperature/maxim_thermocouple.c
> > index c31b963..c613a64 100644
> > --- a/drivers/iio/temperature/maxim_thermocouple.c
> > +++ b/drivers/iio/temperature/maxim_thermocouple.c
> > @@ -10,6 +10,8 @@
> > #include <linux/init.h>
> > #include <linux/mutex.h>
> > #include <linux/err.h>
> > +#include <linux/of.h>
> > +#include <linux/of_device.h>
> > #include <linux/spi/spi.h>
> > #include <linux/iio/iio.h>
> > #include <linux/iio/trigger.h>
> > @@ -262,9 +264,17 @@ static const struct spi_device_id maxim_thermocouple_id[] = {
> > };
> > MODULE_DEVICE_TABLE(spi, maxim_thermocouple_id);
> >
> > +static const struct of_device_id maxim_thermocouple_of_match[] = {
> > + { .compatible = "maxim,max6675" },
> > + { .compatible = "maxim,max31855" },
> > + { },
> > +};
> > +MODULE_DEVICE_TABLE(of, maxim_thermocouple_of_match);
> > +
> > static struct spi_driver maxim_thermocouple_driver = {
> > .driver = {
> > .name = MAXIM_THERMOCOUPLE_DRV_NAME,
> > + .of_match_table = maxim_thermocouple_of_match,
> > },
> > .probe = maxim_thermocouple_probe,
> > .remove = maxim_thermocouple_remove,
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-27 12:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-23 21:42 [PATCH v2] iio: temperature: maxim_thermocouple: declare missing of table Daniel Gomez
2019-04-25 1:35 ` Matt Ranostay
2019-04-27 12:55 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).